Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gzbugfix #292

Merged
merged 2 commits into from
Oct 10, 2023
Merged

Gzbugfix #292

merged 2 commits into from
Oct 10, 2023

Conversation

JosephMouallem
Copy link
Contributor

Description:

Increase the dimension of the local variable gz to have enough points needed when remapping v.
Adjust array bounds in the remapping routine and then compute the extra point only when it is needed from moist_cv before remapping v.

Fixes #70

How Has This Been Tested?

Tests were performed on Gaea with no answer change.
The modified code is affected with iv=-2 when calling map1_ppm. It works fine with iv=-2

Checklist:

Please check all whether they apply or not

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@JosephMouallem
Copy link
Contributor Author

@bensonr @lharris4

Copy link
Contributor

@lharris4 lharris4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting this. This too should be brought into GitLab.

@laurenchilutti
Copy link
Contributor

I am merging this now and will be sure to bring this back to Gitlab and other branches.

@laurenchilutti laurenchilutti merged commit 17961a9 into NOAA-GFDL:main Oct 10, 2023
74 checks passed
@junwang-noaa
Copy link
Collaborator

@laurenchilutti may I ask if there is any plan to merge this bug fix to dev/emc branch? Thank

@laurenchilutti
Copy link
Contributor

@junwang-noaa I can bring this over to dev/emc. I would need assistance in testing and creating the fv3atm andufs-weather-model PRs as they require testing on systems I do not have allocation on. (I can only run on Gaea).

@junwang-noaa
Copy link
Collaborator

Sure, once you have a dycore branch from dev/emc with the changes, we can pick it up from there to test in ufs-weather-model. Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem with remapping?
5 participants