-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gzbugfix #292
Gzbugfix #292
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for submitting this. This too should be brought into GitLab.
I am merging this now and will be sure to bring this back to Gitlab and other branches. |
@laurenchilutti may I ask if there is any plan to merge this bug fix to dev/emc branch? Thank |
@junwang-noaa I can bring this over to dev/emc. I would need assistance in testing and creating the fv3atm andufs-weather-model PRs as they require testing on systems I do not have allocation on. (I can only run on Gaea). |
Sure, once you have a dycore branch from dev/emc with the changes, we can pick it up from there to test in ufs-weather-model. Thanks a lot! |
Description:
Increase the dimension of the local variable gz to have enough points needed when remapping v.
Adjust array bounds in the remapping routine and then compute the extra point only when it is needed from moist_cv before remapping v.
Fixes #70
How Has This Been Tested?
Tests were performed on Gaea with no answer change.
The modified code is affected with iv=-2 when calling map1_ppm. It works fine with iv=-2
Checklist:
Please check all whether they apply or not