fv_diagnostics update #332
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lharris4
suggested changes
Apr 3, 2024
There was a problem hiding this comment.
I think these are fine. The product variables are very useful for computing eddy fluxes and are a neat addition. I have a question and one requested fix.
@abrooks1085 @bensonr are there any steps that need to be done to get the CI working properly here?
Thanks,
Lucas
| @@ -1140,7 +1150,10 @@ subroutine fv_diag_init(Atm, axes, Time, npx, npy, npz, p_ref) | |||
| 'Vertically Integrated Snow', 'kg/m**2', missing_value=missing_value ) | |||
| id_intqg = register_diag_field ( trim(field), 'intqg', axes(1:2), Time, & | |||
| 'Vertically Integrated Graupel', 'kg/m**2', missing_value=missing_value ) | |||
|
|
|||
| id_inthght = register_diag_field ( trim(field), 'inthght', axes(1:2), Time, & | |||
There was a problem hiding this comment.
Are inthght and inttemp supposed to be proportional to the vertically-integrated potential and internal energies?
There was a problem hiding this comment.
Yes, that's correct. This could be overt by multiplying by the relevant constants 'grav' and 'cp_air' that are available in the module and changing the unit accordingly.
abrooks1085
reviewed
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fv_diagnostics.F90 and fv_diagnostics.h are updated to
i) include new diagnostics related to height (vertically integrated) and its horizontal fluxes (both 3d and vertically integrate), as these are components of the moist static energy
ii) correct the logic of existing vertically integrated horizontal T, q fluxes (previously, having just those in a diag table without the 3d version wouldn't work)
Fixes # (issue)
How Has This Been Tested?
The revision compiles and runs on on Princeton's Stellar platform with Intel Fortran Compiler.
There is now output if the diag table only has vertically integrated q and T fluxes.
Checklist:
Please check all whether they apply or not