Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug issues with preprocessor parsing pod settings file #682

Draft
wants to merge 47 commits into
base: main
Choose a base branch
from

Conversation

wrongkindofdoctor
Copy link
Collaborator

Description
Include a summary of the change, and link the associated issue (if applicable).
List any dependencies that are required for this change, including libraries and variables,
and their metadata (units, frequencies, etc...). Be sure to separate PRs and issues for new PODs and PODs currently under development.

Associated issue #681

How Has This Been Tested?
RHEL8 , Python 3.12, WWEs POD (incoming)
Checklist:

  • My branch is up-to-date with the NOAA-GFDL main branch, and all merge conflicts are resolved
  • The scripts are written in Python 3.12 or above (preferred; required if funded by a CPO grant), NCL, or R
  • All of my scripts are in the diagnostics/[POD short name] subdirectory, and include a main_driver script, template html, and settings.jsonc file
  • I have made corresponding changes to the documentation in the POD's doc/ subdirectory
  • I have requested that the framework developers add packages required by my POD to the python3, NCL, or R environment yaml file if necessary, and my environment builds with conda_env_setup.sh
  • I have added any necessary data to input_data/obs_data/[pod short name] and/or input_data/model/[pod short name]
  • My code is portable; it uses MDTF environment variables, and does not contain hard-coded file or directory paths
  • I have provided the code to generate digested data files from raw data files
  • Each digested data file generated by the script contains numerical data (no figures), and is 3 GB or less in size
  • I have included copies of the figures generated by the POD in the pull request
  • The repository contains no extra test scripts or data files

erileydellaripa and others added 30 commits August 19, 2024 13:30
Add WWE_diag_tools.py to git tracking

Add ID_WWEs.py to git tracking
Add WWE_diag_tools.py to git tracking

Add ID_WWEs.py to git tracking

Add text to code to analyze data

Delete files from discontinued folder

Add WWE diagnostic directory to git tracking

Comment out pip modules since error occurs when trying to get pip modules when compiling software package

Modify WWE.py to make simple plot for testing purposes

Modify path to eriley instead of jess in example_multicase csv file

Modify path to eriley instead of jess in example_multicase json file

Modify path in WWEs/esm...json file to reflect new name of POD...from taux_diag to WWEs

Modify path to reflect updated path to data files

Create WWEs.html and WWEs_run_config.yml

Create WWE.rst file

Create WWEs settings.jsonc file

Add config files to the example_multicase directory in diagnostics directory

Create test_builder_config file to build the esm-intake csv
@wrongkindofdoctor wrongkindofdoctor added bug Something isn't working framework Issue pertains to the framework code labels Sep 10, 2024
@wrongkindofdoctor wrongkindofdoctor self-assigned this Sep 10, 2024
wrongkindofdoctor and others added 15 commits September 10, 2024 17:37
… functions, but need a way to append static data open dataset with time variant data
…riables and concatenate along Y, X, or N dimension
Add WWE_diag_tools.py to git tracking

Add ID_WWEs.py to git tracking

Add text to code to analyze data

Delete files from discontinued folder

Add WWE diagnostic directory to git tracking

Comment out pip modules since error occurs when trying to get pip modules when compiling software package

Modify WWE.py to make simple plot for testing purposes

Modify path to eriley instead of jess in example_multicase csv file

Modify path to eriley instead of jess in example_multicase json file

Modify path in WWEs/esm...json file to reflect new name of POD...from taux_diag to WWEs

Modify path to reflect updated path to data files

Create WWEs.html and WWEs_run_config.yml

Create WWE.rst file

Create WWEs settings.jsonc file

Add config files to the example_multicase directory in diagnostics directory

Create test_builder_config file to build the esm-intake csv

Add global_land_mask module to python_base.yml

Add WWE_diag_tools.py to git tracking

Add ID_WWEs.py to git tracking

Add text to code to analyze data

Delete files from discontinued folder

Add WWE diagnostic directory to git tracking

Comment out pip modules since error occurs when trying to get pip modules when compiling software package

Modify WWE.py to make simple plot for testing purposes

Modify path to eriley instead of jess in example_multicase csv file

Modify path to eriley instead of jess in example_multicase json file

Modify path in WWEs/esm...json file to reflect new name of POD...from taux_diag to WWEs

Modify path to reflect updated path to data files

Create WWEs.html and WWEs_run_config.yml

Create WWE.rst file

Create WWEs settings.jsonc file

Add config files to the example_multicase directory in diagnostics directory

Create test_builder_config file to build the esm-intake csv

Add global_land_mask module to python_base.yml

Add WWE_diag_tools.py to git tracking

Add ID_WWEs.py to git tracking

Add text to code to analyze data

Delete files from discontinued folder

Add WWE diagnostic directory to git tracking

Comment out pip modules since error occurs when trying to get pip modules when compiling software package

Add global_land_mask module to python_base.yml

Add WWE_diag_tools.py to git tracking

Add ID_WWEs.py to git tracking

Add text to code to analyze data

Delete files from discontinued folder

Add WWE diagnostic directory to git tracking

Comment out pip modules since error occurs when trying to get pip modules when compiling software package

Modify WWE.py to make simple plot for testing purposes

Modify path to eriley instead of jess in example_multicase csv file

Modify path to eriley instead of jess in example_multicase json file

Modify path in WWEs/esm...json file to reflect new name of POD...from taux_diag to WWEs

Modify path to reflect updated path to data files

Create WWEs.html and WWEs_run_config.yml

Create WWE.rst file

Create WWEs settings.jsonc file

Add config files to the example_multicase directory in diagnostics directory

Create test_builder_config file to build the esm-intake csv

Add global_land_mask module to python_base.yml

Add WWE_diag_tools.py to git tracking

Add ID_WWEs.py to git tracking

Add text to code to analyze data

Delete files from discontinued folder

Add WWE diagnostic directory to git tracking

Comment out pip modules since error occurs when trying to get pip modules when compiling software package

Modify WWE.py to make simple plot for testing purposes

Modify path to eriley instead of jess in example_multicase csv file

Modify path to eriley instead of jess in example_multicase json file

Resolve conflict with esm catalog for CESM2 test case

Add global_land_mask module to python_base.yml

Add WWE_diag_tools.py to git tracking

Add ID_WWEs.py to git tracking

Add text to code to analyze data

Delete files from discontinued folder

Add WWE diagnostic directory to git tracking

Comment out pip modules since error occurs when trying to get pip modules when compiling software package

Modify WWE.py to make simple plot for testing purposes

Modify path to eriley instead of jess in example_multicase csv file

Modify path to eriley instead of jess in example_multicase json file

Modify path in WWEs/esm...json file to reflect new name of POD...from taux_diag to WWEs

Modify path to reflect updated path to data files

Create WWEs.html and WWEs_run_config.yml

Create WWE.rst file

Create WWEs settings.jsonc file

Add config files to the example_multicase directory in diagnostics directory

Create test_builder_config file to build the esm-intake csv

Add global_land_mask module to python_base.yml

Add WWE_diag_tools.py to git tracking

Add ID_WWEs.py to git tracking

Add text to code to analyze data

Delete files from discontinued folder

Add WWE diagnostic directory to git tracking

Comment out pip modules since error occurs when trying to get pip modules when compiling software package

Modify WWE.py to make simple plot for testing purposes

Modify path to eriley instead of jess in example_multicase csv file

Modify path to eriley instead of jess in example_multicase json file

Modify path in WWEs/esm...json file to reflect new name of POD...from taux_diag to WWEs

Modify path to reflect updated path to data files

Create WWEs.html and WWEs_run_config.yml

Create WWE.rst file

Create WWEs settings.jsonc file

Add config files to the example_multicase directory in diagnostics directory

Create test_builder_config file to build the esm-intake csv

Add first_yr, last_yr pod_env_vars to settings file

Remove extra call to compile module regionmask in yml file

Add Hovmoller plotting function to WWE_diag_tools.py

Add global_land_mask module to python_base.yml

Add WWE_diag_tools.py to git tracking

Add ID_WWEs.py to git tracking

Add text to code to analyze data

Delete files from discontinued folder

Add WWE diagnostic directory to git tracking

Comment out pip modules since error occurs when trying to get pip modules when compiling software package

Modify WWE.py to make simple plot for testing purposes

Modify path to eriley instead of jess in example_multicase csv file

Modify path to eriley instead of jess in example_multicase json file

Modify path in WWEs/esm...json file to reflect new name of POD...from taux_diag to WWEs

Modify path to reflect updated path to data files

Create WWEs.html and WWEs_run_config.yml

Create WWE.rst file

Create WWEs settings.jsonc file

Add config files to the example_multicase directory in diagnostics directory

Create test_builder_config file to build the esm-intake csv

Add global_land_mask module to python_base.yml

Add WWE_diag_tools.py to git tracking

Add ID_WWEs.py to git tracking

Add text to code to analyze data

Delete files from discontinued folder

Add WWE diagnostic directory to git tracking

Comment out pip modules since error occurs when trying to get pip modules when compiling software package

Modify WWE.py to make simple plot for testing purposes

Modify path to eriley instead of jess in example_multicase csv file

Modify path to eriley instead of jess in example_multicase json file

Modify path in WWEs/esm...json file to reflect new name of POD...from taux_diag to WWEs

Modify path to reflect updated path to data files

Create WWEs.html and WWEs_run_config.yml

Create WWE.rst file

Create WWEs settings.jsonc file

Add config files to the example_multicase directory in diagnostics directory

Create test_builder_config file to build the esm-intake csv

Add first_yr, last_yr pod_env_vars to settings file

Remove extra call to compile module regionmask in yml file

Add Hovmoller plotting function to WWE_diag_tools.py

Add preprocess to reading in model data, plot observations

Add land fraction variable to settings file

Add path to sftlf (i.e., land fraction) file

Add global_land_mask module to python_base.yml

Add WWE_diag_tools.py to git tracking

Add ID_WWEs.py to git tracking

Add text to code to analyze data

Delete files from discontinued folder

Add WWE diagnostic directory to git tracking

Comment out pip modules since error occurs when trying to get pip modules when compiling software package

Modify WWE.py to make simple plot for testing purposes

Modify path to eriley instead of jess in example_multicase csv file

Modify path to eriley instead of jess in example_multicase json file

Modify path in WWEs/esm...json file to reflect new name of POD...from taux_diag to WWEs

Modify path to reflect updated path to data files

Create WWEs.html and WWEs_run_config.yml

Create WWE.rst file

Create WWEs settings.jsonc file

Add config files to the example_multicase directory in diagnostics directory

Create test_builder_config file to build the esm-intake csv

Add global_land_mask module to python_base.yml

Add WWE_diag_tools.py to git tracking

Add ID_WWEs.py to git tracking

Add text to code to analyze data

Delete files from discontinued folder

Add WWE diagnostic directory to git tracking

Comment out pip modules since error occurs when trying to get pip modules when compiling software package

Modify WWE.py to make simple plot for testing purposes

Modify path to eriley instead of jess in example_multicase csv file

Modify path to eriley instead of jess in example_multicase json file

Modify path in WWEs/esm...json file to reflect new name of POD...from taux_diag to WWEs

Modify path to reflect updated path to data files

Create WWEs.html and WWEs_run_config.yml

Create WWE.rst file

Create WWEs settings.jsonc file

Add config files to the example_multicase directory in diagnostics directory

Create test_builder_config file to build the esm-intake csv

Add first_yr, last_yr pod_env_vars to settings file

Remove extra call to compile module regionmask in yml file

Add Hovmoller plotting function to WWE_diag_tools.py

Add preprocess to reading in model data, plot observations

Add land fraction variable to settings file

Add path to sftlf (i.e., land fraction) file

Update csv and json catalog files to include land fraction file information

Add data section to settings file

Change case name, data catalog name, run_pp to True

Change run_pp to False

Add csv and json files for WWEs POD

Remove defunct csv and json catalog files

Remove extraneous code

Change path to esm_catalog json file

Remove sftlf variable from settings file

Correct output_filename in test_builder_config.yml

Track changes on WWEs esm_catalog csv and json

Modify WWEs.py plot_model_Hovmollers_by_year function to handle many years

Add more years to esm_catalog csv file to encompase CESM 1980-20114

Add sftlf - land fraction - variable to settings.jsonc file

Update enddate to 20150101 from 19891231 in WWEs_run_config.yml

Update tauu file used in esm catalog csv file to find file that is from 1980-2014

Add import xesmf to WWE_diag_tools.py to do regridding

Add code to WWEs to apply land mask using land fraction from model file. Also add more POD_env_vars read in

Add lat lon limits and regrid method option to POD_env_vars in settings file

Correct syntax errors in WWEs.py

Add missing comma to WWEs settings file

Add regridding code to WWEs.py and change variable names to reflect tauu variable

Add do_static_threshold to POD_env_vars in settings file

Add tauu threshold for IDing WWEs and find_WWEs_and_characteristics function to WWEs.py

Modify WWEs.py to save netcdf file of WWE chracteristics and filtered tauu
Add code to plot Hovmollers for model
Move code that plots TropFlux Hovmollers to bottom of code to be with model code

Moved plot_model_Hovmollers_by_year function from WWEs.py to WWE_diag_tools.py

Remove functions from WWE_diag_tools.py that are not used in WWE.py, add hovmoller plot function to WWE_diag_tools.py

Add plot_WWE_likelihood_per_lon and events_per_lon functions to WWE_diag_tools.py

Add code to calculate and plot WWE likelihood per longitude

Add plot_WWE_likelihood_per_lon function to WWEs.py

Fix set_title name in WWE_dia_tools.py plot_WWE_likelihood_per_lon function

Change WWEs.html file to show WWE probability per longitude instead of test figure

Add ID_WWEs.ipynb and test_WWE_POD.ipynb to track changes

Add paragraph explaining WWE POD to WWEs.html

Add period in save filename of plot_model_Hovmollers_by_year function in WWE_diag_tools.py

Add endof20 and start2nd20 to POD env vars in settings file

Modify WWEs.html file to include Hovmoller figure text and their correct paths and frequency text and path as well

Added code to save WWE probability per longitude to test_WWE_POD.ipynb

Change save names for figures to be startdate and enddate, so that html file can find them properly

Add code to save WWE probability per day and change path and names for saving figures

Change file names to reflect changes in WWEs.py code

Modify WWE.rst to reflect new figures that have been added to the POD and to add details regarding the POD

Remove unnecessary modules from WWE_diag_tools.py

Remove unnecessary modules from WWEs.py

Add summary of WWE diagnostic to more about this diagnostic section in the WWE.rst file
…bute in set_query

remove unused date_range refs from set_query
…ar.T.range in preprocessor query

define frequency using variable-specific attribute in xarray dataset in write_pp_catalog
…e time units are None and check will skip comparing variable and dataset time units
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working framework Issue pertains to the framework code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants