Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pp time defs #750

Merged
merged 4 commits into from
Feb 25, 2025

Conversation

wrongkindofdoctor
Copy link
Collaborator

Description

  • Fix logic in preprocessor, data_sources, and xr_parser to check variable time is_static attribute
  • update frequency on a per-variable basis if the attribute is available when writing the post processed data catalog
  • fix env_vars attribute reference in the subprocessPodwrapper
    Associated issue Preprocessor running when set to False in config file #748

How Has This Been Tested?
Please describe the tests that you ran to verify your changes in enough detail that
someone can reproduce them. Include any relevant details for your test configuration
such as the Python version, package versions, expected POD wallclock time, and the
operating system(s) you ran your tests on.

Checklist:

  • My branch is up-to-date with the NOAA-GFDL main branch, and all merge conflicts are resolved
  • The scripts are written in Python 3.12 or above (preferred; required if funded by a CPO grant), NCL, or R
  • All of my scripts are in the diagnostics/[POD short name] subdirectory, and include a main_driver script, template html, and settings.jsonc file
  • I have made corresponding changes to the documentation in the POD's doc/ subdirectory
  • I have requested that the framework developers add packages required by my POD to the python3, NCL, or R environment yaml file if necessary, and my environment builds with conda_env_setup.sh
  • I have added any necessary data to input_data/obs_data/[pod short name] and/or input_data/model/[pod short name]
  • My code is portable; it uses MDTF environment variables, and does not contain hard-coded file or directory paths
  • I have provided the code to generate digested data files from raw data files
  • Each digested data file generated by the script contains numerical data (no figures), and is 3 GB or less in size
  • I have included copies of the figures generated by the POD in the pull request
  • The repository contains no extra test scripts or data files

remove unused references from data_sources.set_query
fix logic to set frequency in set_query to properly accommodate fx
check that var.is_static is false before defining variables using var.T attributes in preprocessor
check that var.translation is not None during catalog variable name clean up in the process function
skip time unit comparison if var.is_static is true in xr_parser check_time_units
@wrongkindofdoctor wrongkindofdoctor added the bug Something isn't working label Feb 25, 2025
@wrongkindofdoctor wrongkindofdoctor self-assigned this Feb 25, 2025
@wrongkindofdoctor wrongkindofdoctor merged commit a86e396 into NOAA-GFDL:main Feb 25, 2025
5 checks passed
@wrongkindofdoctor wrongkindofdoctor deleted the fix_pp_time_defs branch February 25, 2025 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant