Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure XPPM/YPPM consistency on CI #42

Merged
merged 1 commit into from
Feb 12, 2025
Merged

Ensure XPPM/YPPM consistency on CI #42

merged 1 commit into from
Feb 12, 2025

Conversation

romanc
Copy link
Contributor

@romanc romanc commented Feb 10, 2025 •
edited
Loading

Description

Add a step to the linting workflow that ensures consistency in the XPPM/YPPM codes as outlined in PR #40.

How Has This Been Tested?

  • Ran the scripts locally
  • (changed) CI is passing (after some iterations).

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation: N/A
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules: N/A
  • New check tests, if applicable, are included
  • Targeted model if this changed was triggered by a model need/shortcoming: N/A

@romanc romanc marked this pull request as ready for review February 10, 2025 17:18
@romanc
Ensure XPPM/YPPM consistency in CI
163f8c1 
Add a step to the linting workflow that ensures consistency in the
XPPM/YPPM codes.
@romanc romanc force-pushed the romanc/xppm-yppm-linting branch from 72d9d0f to 163f8c1 Compare February 10, 2025 17:20
@romanc
Copy link
Contributor Author

romanc commented Feb 10, 2025

@FlorianDeconinck I know, this is not a priority. I just had some time today.

FlorianDeconinck
FlorianDeconinck approved these changes Feb 10, 2025
View reviewed changes
Copy link
Collaborator

@FlorianDeconinck FlorianDeconinck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Hold for NOAA review

@FlorianDeconinck FlorianDeconinck merged commit d45fe1b into NOAA-GFDL:develop Feb 12, 2025
4 checks passed
@romanc romanc deleted the romanc/xppm-yppm-linting branch February 12, 2025 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FlorianDeconinck FlorianDeconinck FlorianDeconinck approved these changes

@fmalatino fmalatino fmalatino approved these changes

@oelbert oelbert Awaiting requested review from oelbert

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@romanc @FlorianDeconinck @fmalatino