Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename catchment tables and code to be the same name in all locations #981

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

RobHanna-NOAA
Copy link
Contributor

Fixing inconsistencies in database names, sql file names, lambda names etc for all catchment tables and code

Now all places follow the convention of / similar to:

  • catchments_0_branches
  • catchments_0_branches_hi
  • catchments_0_branches_prvi
  • catchments_gms_branches
  • catchments_gms_branches_hi
  • catchments_gms_branches_prvi

Testing

All TI code related to uploading branches have been completed successfully

@RobHanna-NOAA RobHanna-NOAA self-assigned this Nov 19, 2024
@RobHanna-NOAA RobHanna-NOAA added enhancement New feature or request Data Loads labels Nov 19, 2024
@RobHanna-NOAA RobHanna-NOAA added this to the V2.1.8 milestone Nov 19, 2024
@RobHanna-NOAA RobHanna-NOAA marked this pull request as ready for review November 19, 2024 06:01
Copy link
Collaborator

@shawncrawley shawncrawley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@shawncrawley shawncrawley merged commit a5b796a into ti Nov 19, 2024
1 check passed
@shawncrawley shawncrawley deleted the ti-fix-catchments-path branch November 19, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Data Loads enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants