501 add vision transformer model #542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 20 commits
July 12, 2023 17:44
This reverts commit 07dfeb5.
…into 501-add-vision-transformer-model
tests/dataset/test_aoi.py
Outdated
| @@ -95,7 +95,6 @@ def test_stac_input(self): | |||
| aoi = AOI( | |||
| raster=row['tif'], label=row['gpkg'], split=row['split'], | |||
| raster_bands_request=bands) | |||
| assert aoi.raster_bands_request == bands | |||
There was a problem hiding this comment.
Good catch, I removed it for testing before pulling recent changes in 'develop'. I would revert back
tests/model/test_models.py
Outdated
There was a problem hiding this comment.
Should we create a new test for a 3 bands model and keep this one a test for a 4 bands model?
There was a problem hiding this comment.
Yes, we can, but I think all models in GDL should work with at least 3 bands regardless of configuration. So can we keep the 3 band tests for validating all models in GDL
mpelchat04
previously approved these changes
Sep 18, 2023
CharlesAuthier
previously approved these changes
Sep 18, 2023
valhassan
dismissed stale reviews from CharlesAuthier and mpelchat04
via
1cec7b0
mpelchat04
approved these changes
Sep 18, 2023
CharlesAuthier
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting your PR and helping us with GDL.
Please read the template below, fill it out as appropriate, and make additional changes to your code as needed.
Please feel free to submit your PR even if it doesn't satisfy all of the requirements below.
If you need assistance or review from a maintainer, add the label Status: Help Needed or Status: Review Needed respectively.
After review, a maintainer will add the label Status: Revision Needed if further work is required for the PR to be merged.
Description
This PR adds a vision transformer (Segformer) model architecture. it completes feature #501
Type of change
What types of changes does your code introduce? Put an
xin all the boxes that apply:How Has This Been Tested?
Unit tests updated
Screenshots (if applicable):
Checklist:
If you're unsure about any of these, don't hesitate to ask. We're here to help!
If your PR does not fulfill all of the requirements in the checklist above, that's OK! If you need help, @-mention a maintainer and/or add the Status: Help Needed label.