Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

517 add configurable parent directory for patches #556

Conversation

valhassan
Copy link
Collaborator

Thank you for submitting your PR and helping us with GDL.
Please read the template below, fill it out as appropriate, and make additional changes to your code as needed.
Please feel free to submit your PR even if it doesn't satisfy all of the requirements below.
If you need assistance or review from a maintainer, add the label Status: Help Needed or Status: Review Needed respectively.
After review, a maintainer will add the label Status: Revision Needed if further work is required for the PR to be merged.

Description

The goal is to add a configurable parent path for patches which allows SegmentationDataset to work with flexible file paths of patches.
Fixes #517

Type of change

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other

How Has This Been Tested?

Added changes are already covered by tests.

Screenshots (if applicable):

Checklist:

If you're unsure about any of these, don't hesitate to ask. We're here to help!

  • My code follows the code style of this project
  • I have performed a self-review of my own code
  • My PR has a descriptive title
  • My code follows PEP8 (most of it)
  • My code has the proper documentation in the code
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new errors
  • My code is covered by the existing tests (if applicable)
  • My code includes tests that show that my feature works
  • My PR passes Travis CI tests

If your PR does not fulfill all of the requirements in the checklist above, that's OK! If you need help, @-mention a maintainer and/or add the Status: Help Needed label.

@valhassan valhassan merged commit e8fe9f8 into NRCan:develop Mar 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add configurable parent directory for patches
4 participants