Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix CD action to publish to pypi once per release #356

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

MatthewSteen
Copy link
Member

Fix #285.

Comment on lines -4 to -7
pull_request:
branches:
- develop
- main
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed this because:

  1. It doesn't look like this action is running on PRs
  2. I think we should do tests for building docs and Test PyPI in the CI action on PRs (approved?). So, when we finally push to develop and main we should know that those tests pass and we don't have to do it here.

@TShapinsky
Copy link
Member

This looks good, the only comment I have is that since the docs with release and docs without are completely separate it might make sense to just split it into two files so we don't have the conditionals on each job.

@MatthewSteen
Copy link
Member Author

This looks good, the only comment I have is that since the docs with release and docs without are completely separate it might make sense to just split it into two files so we don't have the conditionals on each job.

Yeah, I've thought about that too. I think we could do that in another PR later if we want to go in that direction. When I originally created the cd.yml I was trying to consolidate all the CD related action in one file. Same goes for the ci.yml, which I'd like to revisit later.

@MatthewSteen MatthewSteen merged commit 370da4b into develop Oct 16, 2024
18 checks passed
@MatthewSteen MatthewSteen deleted the fix/285-pypi-publish branch October 16, 2024 20:55
@MatthewSteen
Copy link
Member Author

Here's what the CD action does on a release now...

https://github.com/NREL/BuildingMOTIF/actions/runs/11373850305

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only push to PyPI once per release
2 participants