Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EUSS Demand Flexibility Measures new lighting control measure and thermostat control updates #199

Open
wants to merge 23 commits into
base: main
Choose a base branch
from

Conversation

JieXiong9119
Copy link
Collaborator

@JieXiong9119 JieXiong9119 commented Aug 14, 2024

Pull request overview

Code review for new and updated demand flexibility measures and tests

  • lighting control load shed (new)
  • thermostat control load shed (updated)
  • thermostat control load shift (updated)
  • dispatch schedule generation (updated)

Pull Request Author

This pull request makes changes to (select all the apply):

  • Documentation
  • Infrastructure (includes apptainer image, buildstock batch, dependencies, continuous integration tests)
  • Sampling
  • Workflow Measures
  • Upgrade Measures
  • Reporting Measures
  • Postprocessing

Author pull request checklist:

  • Tagged the pull request with the appropriate label (documentation, infrastructure, sampling, workflow measure, upgrade measure, reporting measure, postprocessing) to help categorize changes in the release notes.
  • Added tests for new measures
  • Updated measure .xml(s)
  • Register values added to comstock_column_definitions.csv
  • Both options_lookup.tsv files updated
  • 10k+ test run
  • Change documentation written
  • Measure documentation written
  • ComStock documentation updated
  • Changes reflected in example .yml files
  • Changes reflected in README.md files
  • Added 'See ComStock License' language to first two lines of each code file
  • Implements corresponding measure tests and indexing path in test/measure_tests.txt or/and test/resource_measure_tests.txt
  • All new and existing tests pass the CI

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a code review on GitHub
  • All related changes have been implemented: data and method additions, changes, tests
  • If fixing a defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • Reviewed change documentation
  • Ensured code files contain License reference
  • Results differences are reasonable
  • Make sure the newly added measures has been added with tests and indexed properly
  • CI status: all tests pass

ComStock Licensing Language - Add to Beginning of Each Code File

# ComStock™, Copyright (c) 2023 Alliance for Sustainable Energy, LLC. All rights reserved.
# See top level LICENSE.txt file for license terms.

@JieXiong9119 JieXiong9119 added the upgrade measure PR improves or adds upgrade measures label Aug 14, 2024
@JieXiong9119 JieXiong9119 self-assigned this Aug 14, 2024
Copy link
Contributor

@ChristopherCaradonna ChristopherCaradonna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments within code. Do the measure tests check for more than just success? If not, it would be good to add a test that checks for proper application. Additionally, add a link to the single model example when it's ready.

test_sets = []

# test: applicable building type
test_sets << {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should replace the example models with the most recent 3.7 versions.

"Office"
"Office",
"Warehouse",
"PrimarySchool",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are there space types in schools that you are excluding? Is it reasonable to apply these to gyms, cafeteria, etc.?

Copy link
Collaborator Author

@JieXiong9119 JieXiong9119 Sep 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We assume a uniform applicability to all space type to simplify the measure (for now) with the following considerations:

  1. The control is applicable to the majority of spaces in the building;
  2. The overestimated potential of applying the measure would compensate the underestimated potentia - for example, the lights in corridor area could be dimmed more while the lights in gym should be dimmed less (or skipped) - and such trade-offs are assumed to have negligible impact on the overall performance (especially in stock level).

These are explained in the documentation as well (in the applicability section). Let me know your opinion on this.

resources/tests/models/3340.osm Outdated Show resolved Hide resolved
Copy link
Contributor

@eringold eringold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI

resources/measures/upgrade_df_lighting_control/measure.rb Outdated Show resolved Hide resolved
resources/measures/upgrade_df_lighting_control/measure.rb Outdated Show resolved Hide resolved
JieXiong9119 and others added 6 commits August 20, 2024 16:29
update get sch ts from ruleset function
update timezone function
1. Fix issues in thermostat measures for thermostat not associated with thermal zones
2. Fix bug in load shift measure
3. Update test model names and test scripts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upgrade measure PR improves or adds upgrade measures
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants