Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix* emissions reporting #231

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Fix* emissions reporting #231

wants to merge 10 commits into from

Conversation

eringold
Copy link
Contributor

@eringold eringold commented Oct 14, 2024

Pull request overview

*Not quite a fix to #220 pending EnergyPlus version update. Until we upgrade to >24.2, the 'out.emissions.electricity.enduse_group.hvac.*' columns will be zero for almost all models. However, the 'calc.weighted.enduse_group.electricity.hvac.emissions.egrid_2021_subregion' column is still calculated in postprocessing from HVAC energy and total electricty emissions instead of the enduse_group as reported in the measure.

Once we use EnergyPlus with the fixed custom meters, we can use the reported HVAC emissions directly to calculate weighted enduse_group emissions.

This PR:

  • better aligns the emissions reporting with energy - instead of a 'CoolingHVAC' custom meter with cooling and HeatRejection, reports cooling and heating end-uses, and total HVAC including heating, cooling and associated energy
  • improves the parsing of registered value names to column definitions, including field_description column
  • updates measure test model with newer/smaller/cleaner one
  • a couple small changes to utility bills measure to have it always register a value for fuel dollars. For small runs that might not have fuel use/energy costs, no registered values means no columns are created. But comstockpostproc uses the full list of possible energy cost column names (e.g. here), so having the measure always register a value even if zero will avoid having to create them in postprocessing.
  • when generating a sample to test this change locally, ran into small issue running Parallel in tsv_resampling.py on my machine. It's happened before, and prefer='threads' fixes it.
  • added some notes on setting up env/running sampling in the sampling readme. @rHorsey todo.

Pull Request Author

This pull request makes changes to (select all the apply):

  • Documentation
  • Infrastructure (includes apptainer image, buildstock batch, dependencies, continuous integration tests)
  • Sampling (sort of/not really)
  • Workflow Measures
  • Upgrade Measures
  • Reporting Measures
  • Postprocessing

Author pull request checklist:

  • Tagged the pull request with the appropriate label (documentation, infrastructure, sampling, workflow measure, upgrade measure, reporting measure, postprocessing) to help categorize changes in the release notes.
  • Added tests for new measures
  • Updated measure .xml(s)
  • Register values added to comstock_column_definitions.csv
  • Both options_lookup.tsv files updated
  • 10k+ test run
  • Change documentation written
  • Measure documentation written
  • ComStock documentation updated
  • Changes reflected in example .yml files
  • Changes reflected in README.md files
  • Added 'See ComStock License' language to first two lines of each code file
  • Implements corresponding measure tests and indexing path in test/measure_tests.txt or/and test/resource_measure_tests.txt
  • All new and existing tests pass the CI

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a code review on GitHub
  • All related changes have been implemented: data and method additions, changes, tests
  • If fixing a defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • Reviewed change documentation
  • Ensured code files contain License reference
  • Results differences are reasonable
  • Make sure the newly added measures has been added with tests and indexed properly
  • CI status: all tests pass

ComStock Licensing Language - Add to Beginning of Each Code File

# ComStock™, Copyright (c) 2023 Alliance for Sustainable Energy, LLC. All rights reserved.
# See top level LICENSE.txt file for license terms.

@eringold eringold added the reporting measure PR improves or adds reporting measures label Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reporting measure PR improves or adds reporting measures
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant