Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate well drilling cost correlations into single definition; GEOPHIRES Version metadata; heating price output fix [3.4.34] #231

Merged
merged 24 commits into from
Jun 18, 2024
Merged

Consolidate well drilling cost correlations into single definition; GEOPHIRES Version metadata; heating price output fix [3.4.34] #231

merged 24 commits into from
Jun 18, 2024

Conversation

softwareengineerprogrammer
Copy link
Collaborator

@softwareengineerprogrammer softwareengineerprogrammer commented Jun 7, 2024 •
edited
Loading

  1. Code consolidation of duplicate cost correlations that were copy-pasted instead of put into a function. (No functional change); https://github.com/NREL/GEOPHIRES-X/pull/231/files#diff-8920f588011ea2bf4982df78ab3a67300e68ca139ed376951aa5aa14c17a4486R54-R74
  2. Include "Simulation Metadata" category with "GEOPHIRES Version" field in client result
  3. Fix example1_outputunits test case - unstable results #18 / Currency conversions disabled #236
  4. Heating price output as default value instead of input value #234

@softwareengineerprogrammer softwareengineerprogrammer changed the title Consolidate well drilling cost correlations into single definition Consolidate well drilling cost correlations into single definition; GEOPHIRES Version metadata Jun 7, 2024
@softwareengineerprogrammer softwareengineerprogrammer changed the title Consolidate well drilling cost correlations into single definition; GEOPHIRES Version metadata Consolidate well drilling cost correlations into single definition; GEOPHIRES Version metadata [3.4.31] Jun 7, 2024
@softwareengineerprogrammer softwareengineerprogrammer marked this pull request as ready for review June 7, 2024 19:17
@softwareengineerprogrammer softwareengineerprogrammer linked an issue Jun 13, 2024 that may be closed by this pull request
Fix example1_outputunits test case - unstable results #18
Closed
@softwareengineerprogrammer softwareengineerprogrammer changed the title Consolidate well drilling cost correlations into single definition; GEOPHIRES Version metadata [3.4.31] Consolidate well drilling cost correlations into single definition; GEOPHIRES Version metadata; heating price output fix [3.4.32] Jun 17, 2024
@softwareengineerprogrammer softwareengineerprogrammer changed the title Consolidate well drilling cost correlations into single definition; GEOPHIRES Version metadata; heating price output fix [3.4.32] Consolidate well drilling cost correlations into single definition; GEOPHIRES Version metadata; heating price output fix [3.4.33] Jun 17, 2024
@softwareengineerprogrammer softwareengineerprogrammer changed the title Consolidate well drilling cost correlations into single definition; GEOPHIRES Version metadata; heating price output fix [3.4.33] Consolidate well drilling cost correlations into single definition; GEOPHIRES Version metadata; heating price output fix [3.4.34] Jun 17, 2024
@softwareengineerprogrammer softwareengineerprogrammer mentioned this pull request Jun 17, 2024
Closed
malcolm-dsider
malcolm-dsider approved these changes Jun 18, 2024
View reviewed changes
Copy link
Collaborator

@malcolm-dsider malcolm-dsider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That Heat/Cooling bug was an insidious little sucker! Thanks for finding it!

@softwareengineerprogrammer softwareengineerprogrammer merged commit 90ff58b into NREL:main Jun 18, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malcolm-dsider malcolm-dsider malcolm-dsider approved these changes

@kfbeckers kfbeckers Awaiting requested review from kfbeckers

@bpulluta bpulluta Awaiting requested review from bpulluta

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix example1_outputunits test case - unstable results
2 participants
@softwareengineerprogrammer @malcolm-dsider