Set fixed internal rate default value to same as discount rate #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es fixes/tweaks to outputting interest rate unit/percent. TODO: resolve missing interest rate percent sign in SUTRAExample1.out; set discount rate/fixed internal rate to same value if exactly one is provided
…ears to have no effect
This reverts commit 7c008fa.
…nt-rate-and-fixed-internal-rate Set fixed internal rate default value to same as discount rate
jeffbourdier
approved these changes
Oct 15, 2024
There was a problem hiding this comment.
Looks OK to me. This should help with resolving #95 as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #301
Remaining work to synchronize the values if one or the other is provided will be done in a separate PR from https://github.com/softwareengineerprogrammer/GEOPHIRES-X/tree/combine-discount-rate-and-fixed-internal-rate-2 - synchronization logic runs into some thorny unit conversion issues that will take more time to address
TODO:
(Originally self-reviewed in softwareengineerprogrammer#37)