-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Greensteel eco sync #330
Closed
jaredthomas68
wants to merge
361
commits into
NREL:dev/refactor
from
jaredthomas68:greensteel-eco-sync
Closed
Greensteel eco sync #330
jaredthomas68
wants to merge
361
commits into
NREL:dev/refactor
from
jaredthomas68:greensteel-eco-sync
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d updated keys in electrolyzer_physics_results[H2_Results]
…ctionality Feature/onshore offshore functionality
…ctionality correct onshore tests
…onality Feature/onshore offshore functionality
Dev/refactor back merge into greensteel-eco-sync
…put to run_electrolyzer_physics
…put, the hydrogen_dmd input of greenheart_config has to be None
… when wind is offshore
Added Electrolyzer Physics Tests
move greensteel tests resource files
Gs propagate
Output component areas to csv
…sizing Rudimentary hydrogen dispatch estimation and saving hydrogen SOC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update greenheart to more closely match the original framework from the GreenSteel project.
This PR brings in many changes to align the greenheart framework with the framework from the original analysis in the GreenSteel project. It allows makes adjustments so that most components can be placed either onshore or offshore. A rudimentary hydrogen dispatch estimation has been included, but is only calculated if hydrogen storage is being sized based the desired load or average hydrogen production.
Related issue
#283
#282
#281
Impacted areas of the software
Additional supporting information
Test results, if applicable