Bug Fix Load Following Dispatch Strategy #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HOPP v2.2.0
…to calculate lifetime schedule used for dispatch
genevievestarke
requested changes
Aug 24, 2024
bayc
approved these changes
Aug 27, 2024
jaredthomas68
requested changes
Aug 27, 2024
hopp/simulation/technologies/grid.py
Outdated
| zip(lifetime_schedule, self.generation_profile)]) | ||
| self.missed_load_percentage = sum(self.missed_load)/sum(lifetime_schedule) | ||
|
|
||
| if self.site.curtailment_value_type == "grid": |
There was a problem hiding this comment.
why is this type called "grid"?
There was a problem hiding this comment.
Let's change this to interconnect_kw
| self.missed_load_percentage = sum(self.missed_load)/sum(lifetime_schedule) | ||
|
|
||
| if self.site.curtailment_value_type == "grid": | ||
| lifetime_schedule: NDArrayFloat = np.tile([self.interconnect_kw], |
There was a problem hiding this comment.
Why call this "lifetime_schedule"? Isn't this the maximum allowed generation?
There was a problem hiding this comment.
I guess it is legacy
There was a problem hiding this comment.
Thanks for the correction. I think this is much more clear.
genevievestarke
approved these changes
Aug 27, 2024
jaredthomas68
approved these changes
Aug 29, 2024
| self.missed_load_percentage = sum(self.missed_load)/sum(lifetime_schedule) | ||
|
|
||
| if self.site.curtailment_value_type == "grid": | ||
| lifetime_schedule: NDArrayFloat = np.tile([self.interconnect_kw], |
There was a problem hiding this comment.
Thanks for the correction. I think this is much more clear.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug Fix Load Following Dispatch Strategy
grid.pyto calculate missed load, missed load percentage and load met using thedesired_scheduleeven when curtailing at grid interconnection limit.04-load-following-batteryto usecurtailement_value_type = "grid"and updated explanation and outputs.Related issue
Impacted areas of the software
Additional supporting information
Test results, if applicable
test_hybrid.pyandtest_detailed_pv_plant.pyupdated with cherry-picked commit 7cddc6a for CI integration tests.