Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reenabling pysam windpower with greenheart #352

Merged
merged 3 commits into from
Oct 14, 2024

Conversation

jmartin4nrel
Copy link
Collaborator

@jmartin4nrel jmartin4nrel commented Oct 1, 2024

hopp_mgmt.py needs to see "pysam" not "sam" from .yaml for the wind technology if we want to use pysam instead of floris
turbine_rating_kw needs to be a float for pysam, was coming in as a tuple
Error message threw syntax error when I first tried "windpower" in the .yaml

@jmartin4nrel jmartin4nrel changed the title Dev/refactor Reenabling pysam windpower with greenheart Oct 1, 2024
@jmartin4nrel
Copy link
Collaborator Author

Test appears to be failing due to a deprecated numpy call in ORBIT code, idk how to handle that...

@RHammond2
Copy link
Collaborator

@jmartin4nrel the easiest way to resolve this is to set the "numpy<2" in the requirements.txt, which works on my end for both your updates and the base branch. That said this should be resolved with ORBIT v1.1, but that's not relevant to this PR and should be addressed separately. I believe any existing environments would have to be updated with pip install --upgrade numpy<2 in order to work.

Copy link
Collaborator

@jaredthomas68 jaredthomas68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. Looks good to me.

@johnjasa johnjasa added this to the v2.3 - HOPP stable for CRADA milestone Oct 14, 2024
@jmartin4nrel jmartin4nrel merged commit db2e65a into NREL:dev/refactor Oct 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants