Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug_Fix: Property Recursion - Develop #361

Merged
merged 5 commits into from
Oct 16, 2024

Conversation

kbrunik
Copy link
Collaborator

@kbrunik kbrunik commented Oct 15, 2024

Update cost property that was causing a recursion loop when accessed

This PR is based on PR #350 but cherry-picked to be able to be merged into develop instead of dev/refactor. PR #350 was an update to #345 based on reviewer feedback.

  • Renamed property om_total_expense to om_total_expenses following naming convention in HybridSimulation.
  • Updated type om_total_expense in the Outputs class and the om_total_expenses property to a Sequence.
  • Changed cf_operating_expenses from a Numpy Array type to a Tuple to avoid additional errors when accessing the property.
  • No recursion loop occurred when accessing the property after these updates.

Related issue

Impacted areas of the software

Additional supporting information

PR #350 was approved by @dguittet.

Test results, if applicable

@kbrunik kbrunik requested a review from johnjasa October 15, 2024 21:46
@kbrunik kbrunik added the bug Something isn't working label Oct 15, 2024
@kbrunik kbrunik added this to the v2.3 - HOPP stable for CRADA milestone Oct 15, 2024
@johnjasa johnjasa merged commit 45a1fb9 into NREL:develop Oct 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants