Issue 356: Move NEBs out of Energy Opps. #359
Conversation
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://gray-tree-06c66911e-359.westus2.4.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://gray-tree-06c66911e-359.westus2.4.azurestaticapps.net |
There was a problem hiding this comment.
Just a suggestion of tweaking the variable name from "EEM" to ""EEO" to align with energy efficiency opportunity.
Also, we discussed about acronym for the tab title/sidebar navs, @koay9f mentioned about switching all to acronyms (we have "NEBs" now, so change "energy efficiency opportunities" to "EEOs". I am fine with either, use acronyms or full names, as long as they are consistent everywhere.
| @@ -10,5 +10,8 @@ export const LabelTooltips = { | |||
| }, | |||
| "calculationMethod": { | |||
| "tooltip": "The method used to calculate impacts on the metric." | |||
| }, | |||
| "associatedEEM": { | |||
There was a problem hiding this comment.
should be "associatedEEO"?
| <!-- <label class="col-sm-5 col-form-label" for="{{'associatedEEM'+nonEnergyBenefit.guid}}">Connected EEM</label> --> | ||
|
|
||
| <div class="col-sm-5 col-form-label"> | ||
| <app-label-with-tooltip [field]="'associatedEEM'" [labelId]="'associatedEEM'+nonEnergyBenefit.guid" |
There was a problem hiding this comment.
associatedEEM to associatedEEO?
connects #356
This moves the form for NEBs out of the Energy Opportunitites form.
Can link to energy opportunity using dropdown in NEB form now
This PR has all the changes from the re-designed sidebar. That one should be merged first and then I will update this one to clean up the number of file changes.