Skip to content

Commit

Permalink
Merge pull request #1472 from NREL/gshp_curve_update
Browse files Browse the repository at this point in the history
Update GSHP curves
  • Loading branch information
shorowit authored Dec 11, 2023
2 parents 62b24ec + 90df35f commit bbe7db1
Show file tree
Hide file tree
Showing 6 changed files with 68 additions and 55 deletions.
1 change: 1 addition & 0 deletions Changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ __New Features__
- Allows optional detailed inputs related to geothermal loop (`HVACPlant/GeothermalLoop`).
- Allows optional ground diffusivity input.
- Updates to using G-Functions from the [G-Function Library for Modeling Vertical Bore Ground Heat Exchanger](https://gdr.openei.org/submissions/1325).
- Updated heating/cooling performance curves to reflect newer equipment.
- BuildResidentialHPXML measure:
- Add soil and moisture type arguments (for determining ground conductivity and diffusivity) and optional geothermal loop arguments for ground source heat pumps.
- Adds more error-checking for inappropriate inputs (e.g., HVAC SHR=0 or clothes washer IMEF=0).
Expand Down
6 changes: 3 additions & 3 deletions HPXMLtoOpenStudio/measure.xml
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
<schema_version>3.1</schema_version>
<name>hpxm_lto_openstudio</name>
<uid>b1543b30-9465-45ff-ba04-1d1f85e763bc</uid>
<version_id>779527cf-9f97-4b93-aa6a-c8c2dc92caff</version_id>
<version_modified>2023-12-08T21:26:22Z</version_modified>
<version_id>d3ebdd06-09aa-4e9e-9f1c-6b169852eacc</version_id>
<version_modified>2023-12-11T16:23:56Z</version_modified>
<xml_checksum>D8922A73</xml_checksum>
<class_name>HPXMLtoOpenStudio</class_name>
<display_name>HPXML to OpenStudio Translator</display_name>
Expand Down Expand Up @@ -340,7 +340,7 @@
<filename>hvac.rb</filename>
<filetype>rb</filetype>
<usage_type>resource</usage_type>
<checksum>944F044E</checksum>
<checksum>4CEA3B45</checksum>
</file>
<file>
<filename>hvac_sizing.rb</filename>
Expand Down
30 changes: 21 additions & 9 deletions HPXMLtoOpenStudio/resources/hvac.rb
Original file line number Diff line number Diff line change
Expand Up @@ -295,6 +295,9 @@ def self.apply_ground_to_air_heat_pump(model, runner, weather, heat_pump,
clg_coil.setRatioofInitialMoistureEvaporationRateandSteadyStateLatentCapacity(1.5)
clg_coil.setRatedAirFlowRate(UnitConversions.convert(clg_cfm_rated, 'cfm', 'm^3/s'))
clg_coil.setRatedWaterFlowRate(UnitConversions.convert(geothermal_loop.loop_flow, 'gal/min', 'm^3/s'))
clg_coil.setRatedEnteringWaterTemperature(UnitConversions.convert(80, 'F', 'C'))
clg_coil.setRatedEnteringAirDryBulbTemperature(UnitConversions.convert(80, 'F', 'C'))
clg_coil.setRatedEnteringAirWetBulbTemperature(UnitConversions.convert(67, 'F', 'C'))
clg_coil.setRatedTotalCoolingCapacity(UnitConversions.convert(heat_pump.cooling_capacity, 'Btu/hr', 'W'))
clg_coil.setRatedSensibleCoolingCapacity(UnitConversions.convert(hp_ap.cooling_capacity_sensible, 'Btu/hr', 'W'))
clg_coil.additionalProperties.setFeature('HPXML_ID', heat_pump.id) # Used by reporting measure
Expand All @@ -307,6 +310,8 @@ def self.apply_ground_to_air_heat_pump(model, runner, weather, heat_pump,
htg_coil.setRatedHeatingCoefficientofPerformance(hp_ap.heat_rated_cops[0])
htg_coil.setRatedAirFlowRate(UnitConversions.convert(htg_cfm_rated, 'cfm', 'm^3/s'))
htg_coil.setRatedWaterFlowRate(UnitConversions.convert(geothermal_loop.loop_flow, 'gal/min', 'm^3/s'))
htg_coil.setRatedEnteringWaterTemperature(UnitConversions.convert(60, 'F', 'C'))
htg_coil.setRatedEnteringAirDryBulbTemperature(UnitConversions.convert(70, 'F', 'C'))
htg_coil.setRatedHeatingCapacity(UnitConversions.convert(heat_pump.heating_capacity, 'Btu/hr', 'W'))
htg_coil.additionalProperties.setFeature('HPXML_ID', heat_pump.id) # Used by reporting measure

Expand Down Expand Up @@ -1444,20 +1449,27 @@ def self.set_curves_gshp(heat_pump)
hp_ap = heat_pump.additional_properties

# E+ equation fit coil coefficients generated following approach in Tang's thesis:
# See Appendix B of https://hvac.okstate.edu/sites/default/files/pubs/theses/MS/27-Tang_Thesis_05.pdf
# See Appendix B of https://shareok.org/bitstream/handle/11244/10075/Tang_okstate_0664M_1318.pdf?sequence=1&isAllowed=y
# Coefficients generated by catalog data: https://files.climatemaster.com/Genesis-GS-Series-Product-Catalog.pdf, p180
# Data point taken as rated condition:
# EWT: 80F EAT:80/67F, AFR: 1200cfm, WFR: 4.5gpm
hp_ap.cool_cap_curve_spec = [[-1.57177156131221, 4.60343712716819, -2.15976622898044, 0.0590964827802021, 0.0194696644460315]]
hp_ap.cool_power_curve_spec = [[-4.42471086639888, 0.658017281046304, 4.37331801294626, 0.174096187531254, -0.0526514790164159]]
hp_ap.cool_sh_curve_spec = [[4.54172823345154, 14.7653304889134, -18.3541272090485, -0.74401391092935, 0.545560799548833, 0.0182620032235494]]

# Cooling Curves
hp_ap.cool_cap_curve_spec = [[-5.45013866666657, 7.42301402824225, -1.43760846638838, 0.249103937703341, 0.0378875477019811]]
hp_ap.cool_power_curve_spec = [[-4.21572180554818, 0.322682268675807, 4.56870615863483, 0.154605773589744, -0.167531037948482]]
hp_ap.cool_sh_curve_spec = [[0.56143829895505, 18.7079597251858, -19.1482655264078, -0.138154731772664, 0.4823357726442, -0.00164644360129174]]

hp_ap.cool_rated_shrs_gross = [heat_pump.cooling_shr]

# E+ equation fit coil coefficients from Tang's thesis:
# See Appendix B Figure B.3 of https://hvac.okstate.edu/sites/default/files/pubs/theses/MS/27-Tang_Thesis_05.pdf
# Coefficients generated by catalog data
hp_ap.heat_cap_curve_spec = [[-5.12650150, -0.93997630, 7.21443206, 0.121065721, 0.051809805]]
hp_ap.heat_power_curve_spec = [[-7.73235249, 6.43390775, 2.29152262, -0.175598629, 0.005888871]]
# E+ equation fit coil coefficients following approach from Tang's thesis:
# See Appendix B Figure B.3 of https://shareok.org/bitstream/handle/11244/10075/Tang_okstate_0664M_1318.pdf?sequence=1&isAllowed=y
# Coefficients generated by catalog data: https://www.climatemaster.com/download/18.274be999165850ccd5b5b73/1535543867815/lc377-climatemaster-commercial-tranquility-20-single-stage-ts-series-water-source-heat-pump-submittal-set.pdf
# Data point taken as rated condition:
# EWT: 60F EAT: 70F AFR: 1200 cfm, WFR: 4.5 gpm

# Heating Curves
hp_ap.heat_cap_curve_spec = [[-3.75031847962047, -2.18062040443483, 6.8363364819032, 0.188376814356582, 0.0869274802923634]]
hp_ap.heat_power_curve_spec = [[-8.4754723813072, 8.10952801956388, 1.38771494628738, -0.33766445915032, 0.0223085217874051]]

# Fan/pump adjustments calculations
power_f = heat_pump.fan_watts_per_cfm * 400.0 / UnitConversions.convert(1.0, 'ton', 'Btu/hr') * UnitConversions.convert(1.0, 'W', 'kW') # 400 cfm/ton, result is in kW per Btu/hr of capacity
Expand Down
54 changes: 27 additions & 27 deletions workflow/tests/base_results/results_sizing.csv
Original file line number Diff line number Diff line change
Expand Up @@ -92,18 +92,18 @@ denver-hvac-autosize-furnace-oil-only.xml,32235.0,0.0,0.0,712.0,0.0
denver-hvac-autosize-furnace-propane-only.xml,32235.0,0.0,0.0,712.0,0.0
denver-hvac-autosize-furnace-wood-only.xml,32235.0,0.0,0.0,712.0,0.0
denver-hvac-autosize-furnace-x3-dse.xml,23876.0,15265.0,0.0,527.0,635.0
denver-hvac-autosize-ground-to-air-heat-pump-cooling-only-sizing-methodology-ACCA.xml,0.0,24224.0,0.0,0.0,912.0
denver-hvac-autosize-ground-to-air-heat-pump-cooling-only-sizing-methodology-HERS.xml,0.0,18787.0,0.0,0.0,708.0
denver-hvac-autosize-ground-to-air-heat-pump-cooling-only-sizing-methodology-MaxLoad.xml,0.0,24224.0,0.0,0.0,912.0
denver-hvac-autosize-ground-to-air-heat-pump-detailed-geothermal-loop-sizing-methodology-ACCA.xml,31565.0,31565.0,31565.0,996.0,1189.0
denver-hvac-autosize-ground-to-air-heat-pump-cooling-only-sizing-methodology-ACCA.xml,0.0,24963.0,0.0,0.0,873.0
denver-hvac-autosize-ground-to-air-heat-pump-cooling-only-sizing-methodology-HERS.xml,0.0,18787.0,0.0,0.0,657.0
denver-hvac-autosize-ground-to-air-heat-pump-cooling-only-sizing-methodology-MaxLoad.xml,0.0,24963.0,0.0,0.0,873.0
denver-hvac-autosize-ground-to-air-heat-pump-detailed-geothermal-loop-sizing-methodology-ACCA.xml,31565.0,31565.0,31565.0,996.0,1104.0
denver-hvac-autosize-ground-to-air-heat-pump-detailed-geothermal-loop-sizing-methodology-HERS.xml,31565.0,31565.0,31565.0,996.0,1313.0
denver-hvac-autosize-ground-to-air-heat-pump-detailed-geothermal-loop-sizing-methodology-MaxLoad.xml,38768.0,38768.0,31565.0,1223.0,1612.0
denver-hvac-autosize-ground-to-air-heat-pump-detailed-geothermal-loop-sizing-methodology-MaxLoad.xml,34979.0,34979.0,31565.0,1103.0,1455.0
denver-hvac-autosize-ground-to-air-heat-pump-heating-only-sizing-methodology-ACCA.xml,31147.0,0.0,31147.0,982.0,0.0
denver-hvac-autosize-ground-to-air-heat-pump-heating-only-sizing-methodology-HERS.xml,31147.0,0.0,31147.0,982.0,0.0
denver-hvac-autosize-ground-to-air-heat-pump-heating-only-sizing-methodology-MaxLoad.xml,31147.0,0.0,31147.0,982.0,0.0
denver-hvac-autosize-ground-to-air-heat-pump-sizing-methodology-ACCA.xml,31147.0,31147.0,31147.0,982.0,1173.0
denver-hvac-autosize-ground-to-air-heat-pump-sizing-methodology-ACCA.xml,31147.0,31147.0,31147.0,982.0,1090.0
denver-hvac-autosize-ground-to-air-heat-pump-sizing-methodology-HERS.xml,31147.0,31147.0,31147.0,982.0,1295.0
denver-hvac-autosize-ground-to-air-heat-pump-sizing-methodology-MaxLoad.xml,38456.0,38456.0,31147.0,1213.0,1599.0
denver-hvac-autosize-ground-to-air-heat-pump-sizing-methodology-MaxLoad.xml,34704.0,34704.0,31147.0,1095.0,1443.0
denver-hvac-autosize-install-quality-air-to-air-heat-pump-1-speed-sizing-methodology-ACCA.xml,25873.0,26950.0,31147.0,612.0,840.0
denver-hvac-autosize-install-quality-air-to-air-heat-pump-1-speed-sizing-methodology-HERS.xml,35174.0,36638.0,31147.0,832.0,1143.0
denver-hvac-autosize-install-quality-air-to-air-heat-pump-1-speed-sizing-methodology-MaxLoad.xml,74430.0,77528.0,31147.0,1761.0,2418.0
Expand All @@ -117,9 +117,9 @@ denver-hvac-autosize-install-quality-furnace-gas-central-ac-1-speed.xml,32235.0,
denver-hvac-autosize-install-quality-furnace-gas-central-ac-2-speed.xml,32235.0,24373.0,0.0,534.0,760.0
denver-hvac-autosize-install-quality-furnace-gas-central-ac-var-speed.xml,32235.0,23459.0,0.0,534.0,732.0
denver-hvac-autosize-install-quality-furnace-gas-only.xml,32235.0,0.0,0.0,534.0,0.0
denver-hvac-autosize-install-quality-ground-to-air-heat-pump-sizing-methodology-ACCA.xml,35169.0,36836.0,31147.0,832.0,1040.0
denver-hvac-autosize-install-quality-ground-to-air-heat-pump-sizing-methodology-ACCA.xml,35169.0,36836.0,31147.0,832.0,967.0
denver-hvac-autosize-install-quality-ground-to-air-heat-pump-sizing-methodology-HERS.xml,35169.0,36836.0,31147.0,832.0,1149.0
denver-hvac-autosize-install-quality-ground-to-air-heat-pump-sizing-methodology-MaxLoad.xml,43421.0,45480.0,31147.0,1027.0,1418.0
denver-hvac-autosize-install-quality-ground-to-air-heat-pump-sizing-methodology-MaxLoad.xml,39186.0,41044.0,31147.0,927.0,1280.0
denver-hvac-autosize-install-quality-mini-split-air-conditioner-only-ducted.xml,0.0,20424.0,0.0,0.0,637.0
denver-hvac-autosize-install-quality-mini-split-heat-pump-ducted-sizing-methodology-ACCA.xml,23855.0,24848.0,26181.0,564.0,775.0
denver-hvac-autosize-install-quality-mini-split-heat-pump-ducted-sizing-methodology-HERS.xml,29578.0,30810.0,26181.0,700.0,961.0
Expand Down Expand Up @@ -153,9 +153,9 @@ denver-hvac-autosize-mini-split-heat-pump-ductless-heating-capacity-17f-sizing-m
denver-hvac-autosize-mini-split-heat-pump-ductless-sizing-methodology-ACCA.xml,18566.0,18566.0,0.0,619.0,619.0
denver-hvac-autosize-mini-split-heat-pump-ductless-sizing-methodology-HERS.xml,23640.0,23640.0,0.0,788.0,788.0
denver-hvac-autosize-mini-split-heat-pump-ductless-sizing-methodology-MaxLoad.xml,37131.0,37131.0,0.0,1238.0,1238.0
denver-hvac-autosize-multiple-sizing-methodology-ACCA.xml,41122.0,28997.0,12678.0,953.0,982.0
denver-hvac-autosize-multiple-sizing-methodology-HERS.xml,37122.0,24997.0,12678.0,824.0,858.0
denver-hvac-autosize-multiple-sizing-methodology-MaxLoad.xml,46282.0,34157.0,12678.0,1117.0,1192.0
denver-hvac-autosize-multiple-sizing-methodology-ACCA.xml,42834.0,30709.0,12678.0,1007.0,1013.0
denver-hvac-autosize-multiple-sizing-methodology-HERS.xml,37122.0,24997.0,12678.0,824.0,854.0
denver-hvac-autosize-multiple-sizing-methodology-MaxLoad.xml,47994.0,35869.0,12678.0,1171.0,1223.0
denver-hvac-autosize-none.xml,0.0,0.0,0.0,0.0,0.0
denver-hvac-autosize-ptac-with-heating-electricity.xml,23640.0,14272.0,0.0,522.0,371.0
denver-hvac-autosize-ptac-with-heating-natural-gas.xml,23640.0,14272.0,0.0,522.0,371.0
Expand Down Expand Up @@ -276,18 +276,18 @@ houston-hvac-autosize-furnace-oil-only.xml,21260.0,0.0,0.0,388.0,0.0
houston-hvac-autosize-furnace-propane-only.xml,21260.0,0.0,0.0,388.0,0.0
houston-hvac-autosize-furnace-wood-only.xml,21260.0,0.0,0.0,388.0,0.0
houston-hvac-autosize-furnace-x3-dse.xml,14219.0,18120.0,0.0,260.0,753.0
houston-hvac-autosize-ground-to-air-heat-pump-cooling-only-sizing-methodology-ACCA.xml,0.0,32400.0,0.0,0.0,972.0
houston-hvac-autosize-ground-to-air-heat-pump-cooling-only-sizing-methodology-HERS.xml,0.0,25329.0,0.0,0.0,760.0
houston-hvac-autosize-ground-to-air-heat-pump-cooling-only-sizing-methodology-MaxLoad.xml,0.0,32400.0,0.0,0.0,972.0
houston-hvac-autosize-ground-to-air-heat-pump-detailed-geothermal-loop-sizing-methodology-ACCA.xml,32400.0,32400.0,20288.0,844.0,972.0
houston-hvac-autosize-ground-to-air-heat-pump-detailed-geothermal-loop-sizing-methodology-HERS.xml,25329.0,25329.0,20288.0,660.0,760.0
houston-hvac-autosize-ground-to-air-heat-pump-detailed-geothermal-loop-sizing-methodology-MaxLoad.xml,32400.0,32400.0,20288.0,844.0,972.0
houston-hvac-autosize-ground-to-air-heat-pump-cooling-only-sizing-methodology-ACCA.xml,0.0,33269.0,0.0,0.0,924.0
houston-hvac-autosize-ground-to-air-heat-pump-cooling-only-sizing-methodology-HERS.xml,0.0,25329.0,0.0,0.0,703.0
houston-hvac-autosize-ground-to-air-heat-pump-cooling-only-sizing-methodology-MaxLoad.xml,0.0,33269.0,0.0,0.0,924.0
houston-hvac-autosize-ground-to-air-heat-pump-detailed-geothermal-loop-sizing-methodology-ACCA.xml,33269.0,33269.0,20288.0,867.0,924.0
houston-hvac-autosize-ground-to-air-heat-pump-detailed-geothermal-loop-sizing-methodology-HERS.xml,25329.0,25329.0,20288.0,660.0,703.0
houston-hvac-autosize-ground-to-air-heat-pump-detailed-geothermal-loop-sizing-methodology-MaxLoad.xml,33269.0,33269.0,20288.0,867.0,924.0
houston-hvac-autosize-ground-to-air-heat-pump-heating-only-sizing-methodology-ACCA.xml,20038.0,0.0,20038.0,522.0,0.0
houston-hvac-autosize-ground-to-air-heat-pump-heating-only-sizing-methodology-HERS.xml,20038.0,0.0,20038.0,522.0,0.0
houston-hvac-autosize-ground-to-air-heat-pump-heating-only-sizing-methodology-MaxLoad.xml,20038.0,0.0,20038.0,522.0,0.0
houston-hvac-autosize-ground-to-air-heat-pump-sizing-methodology-ACCA.xml,32400.0,32400.0,20038.0,844.0,972.0
houston-hvac-autosize-ground-to-air-heat-pump-sizing-methodology-HERS.xml,25329.0,25329.0,20038.0,660.0,760.0
houston-hvac-autosize-ground-to-air-heat-pump-sizing-methodology-MaxLoad.xml,32400.0,32400.0,20038.0,844.0,972.0
houston-hvac-autosize-ground-to-air-heat-pump-sizing-methodology-ACCA.xml,33269.0,33269.0,20038.0,867.0,924.0
houston-hvac-autosize-ground-to-air-heat-pump-sizing-methodology-HERS.xml,25329.0,25329.0,20038.0,660.0,703.0
houston-hvac-autosize-ground-to-air-heat-pump-sizing-methodology-MaxLoad.xml,33269.0,33269.0,20038.0,867.0,924.0
houston-hvac-autosize-install-quality-air-to-air-heat-pump-1-speed-sizing-methodology-ACCA.xml,33330.0,31852.0,20038.0,651.0,993.0
houston-hvac-autosize-install-quality-air-to-air-heat-pump-1-speed-sizing-methodology-HERS.xml,31158.0,29777.0,20038.0,609.0,929.0
houston-hvac-autosize-install-quality-air-to-air-heat-pump-1-speed-sizing-methodology-MaxLoad.xml,37544.0,35880.0,20038.0,733.0,1119.0
Expand All @@ -301,9 +301,9 @@ houston-hvac-autosize-install-quality-furnace-gas-central-ac-1-speed.xml,21260.0
houston-hvac-autosize-install-quality-furnace-gas-central-ac-2-speed.xml,21260.0,31949.0,0.0,291.0,996.0
houston-hvac-autosize-install-quality-furnace-gas-central-ac-var-speed.xml,21260.0,28785.0,0.0,291.0,898.0
houston-hvac-autosize-install-quality-furnace-gas-only.xml,21260.0,0.0,0.0,291.0,0.0
houston-hvac-autosize-install-quality-ground-to-air-heat-pump-sizing-methodology-ACCA.xml,39778.0,38295.0,20038.0,777.0,862.0
houston-hvac-autosize-install-quality-ground-to-air-heat-pump-sizing-methodology-HERS.xml,31097.0,29938.0,20038.0,608.0,674.0
houston-hvac-autosize-install-quality-ground-to-air-heat-pump-sizing-methodology-MaxLoad.xml,39778.0,38295.0,20038.0,777.0,862.0
houston-hvac-autosize-install-quality-ground-to-air-heat-pump-sizing-methodology-ACCA.xml,40845.0,39322.0,20038.0,798.0,819.0
houston-hvac-autosize-install-quality-ground-to-air-heat-pump-sizing-methodology-HERS.xml,31097.0,29938.0,20038.0,608.0,624.0
houston-hvac-autosize-install-quality-ground-to-air-heat-pump-sizing-methodology-MaxLoad.xml,40845.0,39322.0,20038.0,798.0,819.0
houston-hvac-autosize-install-quality-mini-split-air-conditioner-only-ducted.xml,0.0,24438.0,0.0,0.0,762.0
houston-hvac-autosize-install-quality-mini-split-heat-pump-ducted-sizing-methodology-ACCA.xml,25560.0,24438.0,16055.0,499.0,762.0
houston-hvac-autosize-install-quality-mini-split-heat-pump-ducted-sizing-methodology-HERS.xml,24097.0,23040.0,16055.0,471.0,719.0
Expand Down Expand Up @@ -337,9 +337,9 @@ houston-hvac-autosize-mini-split-heat-pump-ductless-heating-capacity-17f-sizing-
houston-hvac-autosize-mini-split-heat-pump-ductless-sizing-methodology-ACCA.xml,17967.0,17967.0,0.0,599.0,599.0
houston-hvac-autosize-mini-split-heat-pump-ductless-sizing-methodology-HERS.xml,16939.0,16939.0,0.0,565.0,565.0
houston-hvac-autosize-mini-split-heat-pump-ductless-sizing-methodology-MaxLoad.xml,19413.0,19413.0,0.0,647.0,647.0
houston-hvac-autosize-multiple-sizing-methodology-ACCA.xml,54257.0,50447.0,12670.0,1251.0,1651.0
houston-hvac-autosize-multiple-sizing-methodology-HERS.xml,48792.0,44982.0,12670.0,1107.0,1508.0
houston-hvac-autosize-multiple-sizing-methodology-MaxLoad.xml,56380.0,52570.0,12670.0,1307.0,1736.0
houston-hvac-autosize-multiple-sizing-methodology-ACCA.xml,56823.0,53013.0,12670.0,1318.0,1681.0
houston-hvac-autosize-multiple-sizing-methodology-HERS.xml,48792.0,44982.0,12670.0,1107.0,1490.0
houston-hvac-autosize-multiple-sizing-methodology-MaxLoad.xml,58946.0,55136.0,12670.0,1374.0,1766.0
houston-hvac-autosize-none.xml,0.0,0.0,0.0,0.0,0.0
houston-hvac-autosize-ptac-with-heating-electricity.xml,14077.0,18120.0,0.0,257.0,471.0
houston-hvac-autosize-ptac-with-heating-natural-gas.xml,14077.0,18120.0,0.0,257.0,471.0
Expand Down
Loading

0 comments on commit bbe7db1

Please sign in to comment.