-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding flexibility to specify location of the radiant barrier #1473
Conversation
Here is the ASTM Standard Specification for Radiant Barriers: ASTM C1313 I would like to see a default value of 0.1 emissivity with an input available for soiling that increases the emissivity as over time dust will accumulate and increase the amount of radiative heat transfer. |
It looks like we are currently assuming a radiant barrier emittance of 0.05: OpenStudio-HPXML/HPXMLtoOpenStudio/resources/materials.rb Lines 302 to 311 in 4fd2701
As far as I can tell, we have been using this number since at least 2010 (in BEopt). |
|
For soiling of radiant barriers on the attic floor, ORNL published an article that gives an anecdotal estimate of reduced performance RADIANT BARRIER: There is probably a technical report somewhere with actual reductions in performance. But if an emittance required by ASTM C1313 is 0.1 and wood emittance is 0.9, then half the difference would be 0.5. |
…o radiant_barrier # Conflicts: # workflow/sample_files/base-hvac-air-to-air-heat-pump-1-speed-autosized-backup.xml # workflow/sample_files/base-hvac-autosize-air-to-air-heat-pump-1-speed-cooling-only.xml # workflow/sample_files/base-hvac-autosize-air-to-air-heat-pump-1-speed-heating-only.xml # workflow/sample_files/base-hvac-autosize-air-to-air-heat-pump-1-speed-sizing-methodology-acca.xml # workflow/sample_files/base-hvac-autosize-air-to-air-heat-pump-1-speed-sizing-methodology-hers.xml # workflow/sample_files/base-hvac-autosize-air-to-air-heat-pump-1-speed-sizing-methodology-maxload-miami-fl.xml # workflow/sample_files/base-hvac-autosize-air-to-air-heat-pump-1-speed-sizing-methodology-maxload.xml # workflow/sample_files/base-hvac-autosize-air-to-air-heat-pump-2-speed-sizing-methodology-acca.xml # workflow/sample_files/base-hvac-autosize-air-to-air-heat-pump-2-speed-sizing-methodology-hers.xml # workflow/sample_files/base-hvac-autosize-air-to-air-heat-pump-2-speed-sizing-methodology-maxload.xml # workflow/sample_files/base-hvac-autosize-air-to-air-heat-pump-var-speed-backup-boiler.xml # workflow/sample_files/base-hvac-autosize-air-to-air-heat-pump-var-speed-backup-furnace.xml # workflow/sample_files/base-hvac-autosize-air-to-air-heat-pump-var-speed-sizing-methodology-acca.xml # workflow/sample_files/base-hvac-autosize-air-to-air-heat-pump-var-speed-sizing-methodology-hers.xml # workflow/sample_files/base-hvac-autosize-air-to-air-heat-pump-var-speed-sizing-methodology-maxload.xml # workflow/sample_files/base-hvac-autosize-boiler-elec-only.xml # workflow/sample_files/base-hvac-autosize-boiler-gas-central-ac-1-speed.xml # workflow/sample_files/base-hvac-autosize-boiler-gas-only.xml # workflow/sample_files/base-hvac-autosize-central-ac-only-1-speed.xml # workflow/sample_files/base-hvac-autosize-central-ac-only-2-speed.xml # workflow/sample_files/base-hvac-autosize-central-ac-only-var-speed.xml # workflow/sample_files/base-hvac-autosize-central-ac-plus-air-to-air-heat-pump-heating.xml # workflow/sample_files/base-hvac-autosize-dual-fuel-air-to-air-heat-pump-1-speed-sizing-methodology-acca.xml # workflow/sample_files/base-hvac-autosize-dual-fuel-air-to-air-heat-pump-1-speed-sizing-methodology-hers.xml # workflow/sample_files/base-hvac-autosize-dual-fuel-air-to-air-heat-pump-1-speed-sizing-methodology-maxload.xml # workflow/sample_files/base-hvac-autosize-dual-fuel-mini-split-heat-pump-ducted-backup-hardsized.xml # workflow/sample_files/base-hvac-autosize-dual-fuel-mini-split-heat-pump-ducted.xml # workflow/sample_files/base-hvac-autosize-elec-resistance-only.xml # workflow/sample_files/base-hvac-autosize-evap-cooler-furnace-gas.xml # workflow/sample_files/base-hvac-autosize-floor-furnace-propane-only.xml # workflow/sample_files/base-hvac-autosize-furnace-elec-only.xml # workflow/sample_files/base-hvac-autosize-furnace-gas-central-ac-2-speed.xml # workflow/sample_files/base-hvac-autosize-furnace-gas-central-ac-var-speed.xml # workflow/sample_files/base-hvac-autosize-furnace-gas-only.xml # workflow/sample_files/base-hvac-autosize-furnace-gas-room-ac.xml # workflow/sample_files/base-hvac-autosize-ground-to-air-heat-pump-cooling-only.xml # workflow/sample_files/base-hvac-autosize-ground-to-air-heat-pump-heating-only.xml # workflow/sample_files/base-hvac-autosize-ground-to-air-heat-pump-sizing-methodology-acca.xml # workflow/sample_files/base-hvac-autosize-ground-to-air-heat-pump-sizing-methodology-hers.xml # workflow/sample_files/base-hvac-autosize-ground-to-air-heat-pump-sizing-methodology-maxload.xml # workflow/sample_files/base-hvac-autosize-mini-split-air-conditioner-only-ducted.xml # workflow/sample_files/base-hvac-autosize-mini-split-heat-pump-ducted-cooling-only.xml # workflow/sample_files/base-hvac-autosize-mini-split-heat-pump-ducted-heating-only.xml # workflow/sample_files/base-hvac-autosize-mini-split-heat-pump-ducted-sizing-methodology-acca.xml # workflow/sample_files/base-hvac-autosize-mini-split-heat-pump-ducted-sizing-methodology-hers.xml # workflow/sample_files/base-hvac-autosize-mini-split-heat-pump-ducted-sizing-methodology-maxload.xml # workflow/sample_files/base-hvac-autosize-mini-split-heat-pump-ductless-backup-baseboard.xml # workflow/sample_files/base-hvac-autosize-mini-split-heat-pump-ductless-backup-stove.xml # workflow/sample_files/base-hvac-autosize-ptac-with-heating.xml # workflow/sample_files/base-hvac-autosize-ptac.xml # workflow/sample_files/base-hvac-autosize-pthp-sizing-methodology-acca.xml # workflow/sample_files/base-hvac-autosize-pthp-sizing-methodology-hers.xml # workflow/sample_files/base-hvac-autosize-pthp-sizing-methodology-maxload.xml # workflow/sample_files/base-hvac-autosize-room-ac-only.xml # workflow/sample_files/base-hvac-autosize-room-ac-with-heating.xml # workflow/sample_files/base-hvac-autosize-room-ac-with-reverse-cycle-sizing-methodology-acca.xml # workflow/sample_files/base-hvac-autosize-room-ac-with-reverse-cycle-sizing-methodology-hers.xml # workflow/sample_files/base-hvac-autosize-room-ac-with-reverse-cycle-sizing-methodology-maxload.xml # workflow/sample_files/base-hvac-autosize-stove-oil-only.xml # workflow/sample_files/base-hvac-autosize-wall-furnace-elec-only.xml # workflow/tests/base_results/results.csv # workflow/tests/base_results/results_bills.csv
…o radiant_barrier # Conflicts: # BuildResidentialHPXML/README.md # BuildResidentialHPXML/measure.rb # BuildResidentialHPXML/measure.xml # HPXMLtoOpenStudio/measure.xml # HPXMLtoOpenStudio/resources/hotwater_appliances.rb # workflow/sample_files/base-appliances-oil-location-miami-fl.xml # workflow/sample_files/base-appliances-propane-location-portland-or.xml # workflow/sample_files/base-hvac-air-to-air-heat-pump-var-speed-backup-boiler-switchover-temperature2.xml # workflow/sample_files/base-hvac-floor-furnace-propane-only-pilot-light.xml # workflow/sample_files/base-hvac-undersized-allow-increased-fixed-capacities.xml # workflow/sample_files/base-misc-bills-none.xml # workflow/sample_files/base-schedules-detailed-occupancy-stochastic-vacancy-year-round.xml # workflow/sample_files/base-schedules-simple-power-outage-natvent-available.xml # workflow/sample_files/base-schedules-simple-power-outage-natvent-unavailable.xml # workflow/sample_files/base-schedules-simple-vacancy-year-round.xml # workflow/tests/base_results/results_bills.csv # workflow/tests/base_results/results_workflow_simulations1.csv
…o radiant_barrier
…o radiant_barrier
…o radiant_barrier # Conflicts: # HPXMLtoOpenStudio/measure.xml
…emented through materials.rb
…o radiant_barrier # Conflicts: # BuildResidentialHPXML/measure.xml # HPXMLtoOpenStudio/measure.xml # docs/source/workflow_inputs.rst
… Remove radiant_barrier arg since we are making breaking changes (renaming args) anyway.
…HPXML into radiant_barrier
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran the HPXML test files and inspected the IDFs; the attic floor case is definitely not correct. I pointed out a couple places where the code looks wrong. Please diff the IDF for the attic floor case against another similar file and verify that you see the expected changes.
…HPXML into radiant_barrier
…o radiant_barrier # Conflicts: # HPXMLtoOpenStudio/measure.xml
…o radiant_barrier # Conflicts: # BuildResidentialHPXML/measure.xml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Will double-check final results from the CI but this should be good to merge. Nice work, @prsh5175!
@@ -13,7 +13,8 @@ base-appliances-wood.xml,59.618,59.618,33.14,33.14,21.613,0.0,0.0,4.866,0.0,0.0, | |||
base-atticroof-cathedral.xml,61.345,61.345,35.725,35.725,25.62,0.0,0.0,0.0,0.0,0.0,0.0,0.423,0.0,0.0,4.212,0.796,9.018,0.0,0.0,4.51,0.0,0.334,0.0,0.0,0.0,0.0,2.22,0.0,0.0,0.319,0.365,1.513,1.528,0.0,2.114,8.374,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,25.62,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,23.973,0.0,13.668,9.075,0.615,0.0,0.0,0.0,0.0,2143.4,3112.0,3112.0,22.717,16.559,6.771,0.0,4.231,0.513,7.508,0.633,12.688,-15.638,0.0,0.0,0.0,8.371,-0.086,9.316,0.0,0.729,0.0,0.0,-8.932,-2.503,0.124,0.0,-0.517,-0.049,2.739,-0.02,-1.228,15.662,0.0,0.0,0.0,-6.364,-0.061,-2.102,-3.934,-0.159,0.0,0.0,7.847,2.006,1354.8,997.6,11171.6,2563.5,0.0,36000.0,24000.0,0.0,6.8,91.76,29821.0,0.0,9510.0,0.0,575.0,7194.0,3697.0,0.0,1949.0,0.0,6896.0,15704.0,0.0,9971.0,0.0,207.0,302.0,975.0,0.0,0.0,0.0,929.0,3320.0,0.0,0.0,0.0,0.0 | |||
base-atticroof-conditioned.xml,63.091,63.091,40.489,40.489,22.603,0.0,0.0,0.0,0.0,0.0,0.0,0.373,0.0,0.0,4.868,0.953,8.922,0.0,0.0,5.751,0.0,0.398,0.0,0.0,0.0,0.0,2.22,0.0,0.0,0.319,0.365,1.513,1.528,0.0,2.114,11.166,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,22.603,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,21.151,0.0,16.414,9.023,0.613,0.0,0.0,0.0,0.0,2374.2,3660.6,3660.6,22.528,19.797,4.57,1.168,5.569,0.52,7.699,0.639,14.497,-17.149,0.0,0.0,0.0,8.589,-0.089,7.111,0.0,0.733,0.0,0.273,-10.225,-3.182,-0.013,0.016,-0.589,-0.055,2.657,-0.033,-1.932,17.689,0.0,0.0,0.0,-6.404,-0.083,-1.707,-4.231,-0.168,0.0,0.093,8.938,2.569,1354.8,997.6,11171.6,2471.3,0.0,36000.0,24000.0,0.0,6.8,91.76,31468.0,778.0,10436.0,0.0,575.0,7982.0,2464.0,0.0,1949.0,724.0,6561.0,18531.0,0.0,11700.0,0.0,207.0,1098.0,650.0,0.0,0.0,670.0,886.0,3320.0,0.0,0.0,0.0,0.0 | |||
base-atticroof-flat.xml,54.457,54.457,35.005,35.005,19.452,0.0,0.0,0.0,0.0,0.0,0.0,0.321,0.0,0.0,3.708,0.682,9.017,0.0,0.0,4.51,0.0,0.334,0.0,0.0,0.0,0.0,2.22,0.0,0.0,0.319,0.365,1.513,1.528,0.0,2.114,8.374,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,19.452,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,18.203,0.0,11.696,9.075,0.614,0.0,0.0,0.0,0.0,2104.8,2704.0,2704.0,17.648,12.83,6.045,0.0,3.619,0.509,7.464,0.625,10.031,-12.687,0.0,0.0,0.0,8.217,-0.076,4.799,0.0,0.728,0.0,0.0,-8.908,-2.5,0.291,0.0,-0.456,-0.051,2.711,-0.025,-1.387,11.721,0.0,0.0,0.0,-6.302,-0.051,-1.158,-3.067,-0.164,0.0,0.0,7.87,2.01,1354.8,997.6,11171.6,2563.5,0.0,36000.0,24000.0,0.0,6.8,91.76,24776.0,0.0,7508.0,0.0,575.0,6840.0,3307.0,0.0,1949.0,0.0,4597.0,12320.0,0.0,7037.0,0.0,207.0,265.0,872.0,0.0,0.0,0.0,619.0,3320.0,0.0,0.0,0.0,0.0 | |||
base-atticroof-radiant-barrier.xml,37.3,37.3,33.148,33.148,4.152,0.0,0.0,0.0,0.0,0.0,0.0,0.018,0.0,0.0,9.336,1.949,6.714,0.0,0.0,2.647,0.0,0.238,0.0,0.0,0.0,0.0,2.22,0.0,0.0,0.319,0.365,1.513,1.528,0.0,2.114,4.187,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,4.152,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,3.834,0.0,32.579,6.562,0.579,0.0,0.0,0.0,0.0,1903.9,3231.2,3231.2,13.531,18.845,0.0,6.126,1.575,0.0,0.0,0.335,4.353,-5.899,0.0,0.0,0.0,0.826,-0.36,0.993,0.0,0.397,0.0,0.103,-3.998,-0.844,0.0,2.403,0.135,0.0,0.0,0.203,2.884,16.272,0.0,0.0,0.0,2.056,-0.352,-0.28,-1.733,-0.052,0.0,0.379,9.165,1.803,1354.8,997.6,9789.3,2412.1,0.0,24000.0,24000.0,0.0,25.88,98.42,25739.0,1416.0,5241.0,0.0,401.0,1535.0,0.0,0.0,8539.0,6846.0,1760.0,22161.0,65.0,7662.0,0.0,313.0,637.0,0.0,0.0,0.0,9596.0,568.0,3320.0,1630.0,438.0,393.0,800.0 | |||
base-atticroof-radiant-barrier-ceiling.xml,38.324,38.324,33.559,33.559,4.764,0.0,0.0,0.0,0.0,0.0,0.0,0.021,0.0,0.0,9.672,2.02,6.716,0.0,0.0,2.647,0.0,0.238,0.0,0.0,0.0,0.0,2.22,0.0,0.0,0.319,0.365,1.513,1.528,0.0,2.114,4.187,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,4.764,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,4.4,0.0,33.765,6.562,0.58,0.0,0.0,0.0,0.0,2084.5,3439.0,3439.0,14.269,20.47,0.0,7.066,1.548,0.0,0.0,0.336,4.349,-5.952,0.0,0.0,0.0,0.661,-0.417,0.994,0.0,0.4,0.0,0.117,-4.051,-0.857,0.0,3.679,0.137,0.0,0.0,0.211,2.951,16.245,0.0,0.0,0.0,1.975,-0.409,-0.262,-1.694,-0.044,0.0,0.392,9.113,1.79,1354.8,997.6,9789.2,2412.1,0.0,24000.0,24000.0,0.0,25.88,98.42,25739.0,1416.0,5241.0,0.0,401.0,1535.0,0.0,0.0,8539.0,6846.0,1760.0,25263.0,63.0,7662.0,0.0,313.0,637.0,0.0,0.0,0.0,12699.0,568.0,3320.0,1630.0,438.0,393.0,800.0 | |||
base-atticroof-radiant-barrier.xml,37.175,37.175,33.122,33.122,4.053,0.0,0.0,0.0,0.0,0.0,0.0,0.017,0.0,0.0,9.316,1.945,6.714,0.0,0.0,2.647,0.0,0.238,0.0,0.0,0.0,0.0,2.22,0.0,0.0,0.319,0.365,1.513,1.528,0.0,2.114,4.187,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,4.053,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,0.0,3.742,0.0,32.49,6.562,0.579,0.0,0.0,0.0,0.0,1884.8,3231.7,3231.7,13.389,18.802,0.0,5.961,1.573,0.0,0.0,0.336,4.356,-5.864,0.0,0.0,0.0,0.842,-0.36,0.991,0.0,0.396,0.0,0.1,-3.98,-0.839,0.0,2.287,0.128,0.0,0.0,0.203,2.872,16.307,0.0,0.0,0.0,2.055,-0.353,-0.284,-1.739,-0.054,0.0,0.377,9.183,1.808,1354.8,997.6,9789.3,2412.1,0.0,24000.0,24000.0,0.0,25.88,98.42,25739.0,1416.0,5241.0,0.0,401.0,1535.0,0.0,0.0,8539.0,6846.0,1760.0,22161.0,65.0,7662.0,0.0,313.0,637.0,0.0,0.0,0.0,9596.0,568.0,3320.0,1630.0,438.0,393.0,800.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Energy use went down slightly in this test file because we added radiant barriers to the attic gable walls. All other files are unchanged. Results look good.
Pull Request Description
Allowing Radiant Barrier for Attic Floor
Addresses: #1435
Checklist
PR Author: Check these when they're done. Not all may apply.
strikethroughand check any that do not apply.PR Reviewer: Verify each has been completed.
EPvalidator.xml
) has been updatedtasks.rb
)HPXMLtoOpenStudio/tests
and/orworkflow/tests/hpxml_translator_test.rb
)openstudio tasks.rb update_measures
has been run