Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BuildResidentialHPXML: expose blower W/cfm #1531

Closed
wants to merge 9 commits into from

Conversation

joseph-robertson
Copy link
Collaborator

@joseph-robertson joseph-robertson commented Oct 27, 2023

Pull Request Description

Closes #1530.

Adds optional argument to BuildResHPXML:

  • hvac_distribution_fan_watts_per_cfm

Checklist

PR Author: Check these when they're done. Not all may apply. strikethrough and check any that do not apply.

PR Reviewer: Verify each has been completed.

  • Schematron validator (EPvalidator.xml) has been updated
  • Sample files have been added/updated (via tasks.rb)
  • Tests have been added/updated (e.g., HPXMLtoOpenStudio/tests and/or workflow/tests/hpxml_translator_test.rb)
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected changes to simulation results of sample files

@joseph-robertson joseph-robertson self-assigned this Oct 27, 2023
@shorowit
Copy link
Contributor

shorowit commented Oct 27, 2023

Just add a single argument. We only support a single air distribution system in the BuildResHPXML measure, in which there will be a single blower. Can apply to heating or cooling or heat pump depending on system type. For a central AC + furnace, the heating and cooling values need to be the same anyway.

@shorowit shorowit added the enhancement New feature or request label Oct 31, 2023
@joseph-robertson
Copy link
Collaborator Author

Superseded by #1547.

@joseph-robertson joseph-robertson deleted the watts-per-cfm-args branch November 30, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose blower W/cfm
2 participants