Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

120 v hpwh #1534

Draft
wants to merge 16 commits into
base: unmet_wh_loads
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions BuildResidentialScheduleFile/measure.xml
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
<schema_version>3.1</schema_version>
<name>build_residential_schedule_file</name>
<uid>f770b2db-1a9f-4e99-99a7-7f3161a594b1</uid>
<version_id>88f0b216-fd7b-44ac-bae8-6e65898aa224</version_id>
<version_modified>2024-03-14T23:17:21Z</version_modified>
<version_id>a110985a-4bd3-4d90-8ae5-85ac26de0edb</version_id>
<version_modified>2024-04-18T19:34:47Z</version_modified>
<xml_checksum>03F02484</xml_checksum>
<class_name>BuildResidentialScheduleFile</class_name>
<display_name>Schedule File Builder</display_name>
Expand All @@ -22,7 +22,7 @@
<argument>
<name>schedules_column_names</name>
<display_name>Schedules: Column Names</display_name>
<description>A comma-separated list of the column names to generate. If not provided, defaults to all columns. Possible column names are: occupants, lighting_interior, lighting_garage, cooking_range, dishwasher, clothes_washer, clothes_dryer, ceiling_fan, plug_loads_other, plug_loads_tv, hot_water_dishwasher, hot_water_clothes_washer, hot_water_fixtures.</description>
<description>A comma-separated list of the column names to generate. If not provided, defaults to all columns. Possible column names are: occupants, lighting_interior, lighting_garage, cooking_range, dishwasher, clothes_washer, clothes_dryer, ceiling_fan, plug_loads_other, plug_loads_tv, hot_water_dishwasher, hot_water_clothes_washer, hot_water_fixtures, hot_water_showers.</description>
<type>String</type>
<required>false</required>
<model_dependent>false</model_dependent>
Expand Down Expand Up @@ -116,7 +116,7 @@
<filename>README.md</filename>
<filetype>md</filetype>
<usage_type>readme</usage_type>
<checksum>5852D2EF</checksum>
<checksum>1FB083ED</checksum>
</file>
<file>
<filename>README.md.erb</filename>
Expand Down Expand Up @@ -223,7 +223,7 @@
<filename>schedules.rb</filename>
<filetype>rb</filetype>
<usage_type>resource</usage_type>
<checksum>B5E26248</checksum>
<checksum>F588B60A</checksum>
</file>
<file>
<filename>schedules_config.md</filename>
Expand Down
5 changes: 5 additions & 0 deletions Changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,8 @@ __New Features__
- Other plug load schedules now use Other schedule fractions per ANSI/RESNET/ICC 301-2022 Addendum C.
- TV plug load schedules now use TV schedule fractions from the American Time Use Survey and monthly multipliers from the 2010 Building America Analysis Spreadsheets.
- Ceiling fan schedules now use ceiling fan schedule fractions and monthly multipliers from ANSI/RESNET/ICC 301-2022 Addendum C.
- Added calculations of unmet water heating load.
- Added capability to model 120V HPWHs

__Bugfixes__
- Fixes error if using AllowIncreasedFixedCapacities=true w/ HP detailed performance data.
Expand Down Expand Up @@ -109,7 +111,10 @@ __New Features__
- Allows above-grade basements/crawlspaces defined solely with Wall (not FoundationWall) elements.
- Updates to 2022 EIA energy costs.
- Added README.md documentation for all OpenStudio measures.
<<<<<<< HEAD
=======
- Added metrics for unmet hot water loads
>>>>>>> 6421080f9a642df9c9d7e3ae032c8467af5a1a4d

__Bugfixes__
- Fixes battery resilience output to properly incorporate battery losses.
Expand Down
3 changes: 1 addition & 2 deletions HPXMLtoOpenStudio/measure.rb
Original file line number Diff line number Diff line change
Expand Up @@ -1553,8 +1553,7 @@ def add_hot_water_and_appliances(runner, model, weather, spaces)
showers_peak_flows = HotWaterAndAppliances.apply(model, runner, @hpxml_header, @hpxml_bldg, weather, spaces, hot_water_distribution,
solar_thermal_system, @eri_version, @schedules_file, plantloop_map,
@hpxml_header.unavailable_periods, @hpxml_bldg.building_construction.number_of_units,
@apply_ashrae140_assumptions)

@apply_ashrae140_assumptions)

if (not solar_thermal_system.nil?) && (not solar_thermal_system.collector_area.nil?) # Detailed solar water heater
loc_space, loc_schedule = get_space_or_schedule_from_location(solar_thermal_system.water_heating_system.location, model, spaces)
Expand Down
26 changes: 13 additions & 13 deletions HPXMLtoOpenStudio/measure.xml
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
<schema_version>3.1</schema_version>
<name>hpxm_lto_openstudio</name>
<uid>b1543b30-9465-45ff-ba04-1d1f85e763bc</uid>
<version_id>a29c684e-60c6-4228-8d59-8f6c311f1172</version_id>
<version_modified>2024-04-09T20:34:32Z</version_modified>
<version_id>d949db95-7c4c-40f1-bb13-4723a63ebd5b</version_id>
<version_modified>2024-04-18T19:34:48Z</version_modified>
<xml_checksum>D8922A73</xml_checksum>
<class_name>HPXMLtoOpenStudio</class_name>
<display_name>HPXML to OpenStudio Translator</display_name>
Expand Down Expand Up @@ -142,7 +142,7 @@
<filename>measure.rb</filename>
<filetype>rb</filetype>
<usage_type>script</usage_type>
<checksum>CA17B170</checksum>
<checksum>FA0D32C8</checksum>
</file>
<file>
<filename>airflow.rb</filename>
Expand All @@ -160,7 +160,7 @@
<filename>constants.rb</filename>
<filetype>rb</filetype>
<usage_type>resource</usage_type>
<checksum>2568BDAC</checksum>
<checksum>EB133043</checksum>
</file>
<file>
<filename>constructions.rb</filename>
Expand Down Expand Up @@ -274,7 +274,7 @@
<filename>data/unavailable_periods.csv</filename>
<filetype>csv</filetype>
<usage_type>resource</usage_type>
<checksum>73BFECE2</checksum>
<checksum>DDE30F98</checksum>
</file>
<file>
<filename>energyplus.rb</filename>
Expand All @@ -298,7 +298,7 @@
<filename>hotwater_appliances.rb</filename>
<filetype>rb</filetype>
<usage_type>resource</usage_type>
<checksum>063242D8</checksum>
<checksum>8BDCB4FD</checksum>
</file>
<file>
<filename>hpxml.rb</filename>
Expand Down Expand Up @@ -388,7 +388,7 @@
<filename>output.rb</filename>
<filetype>rb</filetype>
<usage_type>resource</usage_type>
<checksum>7AC7F779</checksum>
<checksum>00CDE355</checksum>
</file>
<file>
<filename>psychrometrics.rb</filename>
Expand Down Expand Up @@ -424,19 +424,19 @@
<filename>schedule_files/occupancy-stochastic-10-mins.csv</filename>
<filetype>csv</filetype>
<usage_type>resource</usage_type>
<checksum>F88479B3</checksum>
<checksum>811F8B96</checksum>
</file>
<file>
<filename>schedule_files/occupancy-stochastic-30-mins.csv</filename>
<filetype>csv</filetype>
<usage_type>resource</usage_type>
<checksum>F88479B3</checksum>
<checksum>811F8B96</checksum>
</file>
<file>
<filename>schedule_files/occupancy-stochastic.csv</filename>
<filetype>csv</filetype>
<usage_type>resource</usage_type>
<checksum>B0187567</checksum>
<checksum>EDB7F257</checksum>
</file>
<file>
<filename>schedule_files/occupancy-stochastic_2.csv</filename>
Expand Down Expand Up @@ -526,7 +526,7 @@
<filename>schedules.rb</filename>
<filetype>rb</filetype>
<usage_type>resource</usage_type>
<checksum>42F9AD9E</checksum>
<checksum>97729642</checksum>
</file>
<file>
<filename>simcontrols.rb</filename>
Expand Down Expand Up @@ -562,7 +562,7 @@
<filename>waterheater.rb</filename>
<filetype>rb</filetype>
<usage_type>resource</usage_type>
<checksum>80D00EE1</checksum>
<checksum>07CD9978</checksum>
</file>
<file>
<filename>weather.rb</filename>
Expand Down Expand Up @@ -658,7 +658,7 @@
<filename>test_schedules.rb</filename>
<filetype>rb</filetype>
<usage_type>test</usage_type>
<checksum>C6CCF641</checksum>
<checksum>683CFFF2</checksum>
</file>
<file>
<filename>test_simcontrols.rb</filename>
Expand Down
12 changes: 10 additions & 2 deletions HPXMLtoOpenStudio/resources/hotwater_appliances.rb
Original file line number Diff line number Diff line change
Expand Up @@ -417,6 +417,14 @@ def self.apply(model, runner, hpxml_header, hpxml_bldg, weather, spaces, hot_wat
end
end

# FIXME: quick fix for tempering valves. Since the tempering valves are set to the setpoint of the normal WH, this only affects 120V Shared HPWHs with higher tank setpoints
# TODO: Formal support of tempering valves? Probably requires an HPXML change?
t_hot = 125.0 # F
hw_temp_schedule = OpenStudio::Model::ScheduleConstant.new(model)
hw_temp_schedule.setName('hot water temperature schedule')
hw_temp_schedule.setValue(UnitConversions.convert(t_hot, 'F', 'C'))
Schedule.set_schedule_type_limits(model, hw_temp_schedule, Constants.ScheduleTypeLimitsTemperature)

# Clothes washer
if not clothes_washer.nil?
gpd_frac = nil
Expand All @@ -438,7 +446,7 @@ def self.apply(model, runner, hpxml_header, hpxml_bldg, weather, spaces, hot_wat
cw_peak_flow = cw_schedule_obj.calc_design_level_from_daily_gpm(cw_gpd)
water_cw_schedule = cw_schedule_obj.schedule
end
add_water_use_equipment(model, cw_object_name, cw_peak_flow * gpd_frac * non_solar_fraction, water_cw_schedule, water_use_connections[water_heating_system.id], unit_multiplier)
add_water_use_equipment(model, cw_object_name, cw_peak_flow * gpd_frac * non_solar_fraction, water_cw_schedule, water_use_connections[water_heating_system.id], unit_multiplier, hw_temp_schedule)
end
end

Expand All @@ -465,7 +473,7 @@ def self.apply(model, runner, hpxml_header, hpxml_bldg, weather, spaces, hot_wat
dw_peak_flow = dw_schedule_obj.calc_design_level_from_daily_gpm(dw_gpd)
water_dw_schedule = dw_schedule_obj.schedule
end
add_water_use_equipment(model, dw_obj_name, dw_peak_flow * gpd_frac * non_solar_fraction, water_dw_schedule, water_use_connections[water_heating_system.id], unit_multiplier)
add_water_use_equipment(model, dw_obj_name, dw_peak_flow * gpd_frac * non_solar_fraction, water_dw_schedule, water_use_connections[water_heating_system.id], unit_multiplier, hw_temp_schedule)
end

if not apply_ashrae140_assumptions
Expand Down
4 changes: 2 additions & 2 deletions HPXMLtoOpenStudio/resources/schedules.rb
Original file line number Diff line number Diff line change
Expand Up @@ -948,7 +948,7 @@ def self.ShowersWeekendFractions
def self.ShowersMonthlyMultipliers
return '1.0, 1.0, 1.0, 1.0, 1.0, 1.0, 1.0, 1.0, 1.0, 1.0, 1.0, 1.0'
end

def self.GeneralWaterUseWeekdayFractions
return '0.023, 0.021, 0.021, 0.025, 0.027, 0.038, 0.044, 0.039, 0.037, 0.037, 0.034, 0.035, 0.035, 0.035, 0.039, 0.043, 0.051, 0.064, 0.065, 0.072, 0.073, 0.063, 0.045, 0.034'
end
Expand Down Expand Up @@ -1433,7 +1433,7 @@ def initialize(name, used_by_unavailable_periods, can_be_stochastic, type)
HotWaterDishwasher: Column.new('hot_water_dishwasher', false, true, :frac),
HotWaterClothesWasher: Column.new('hot_water_clothes_washer', false, true, :frac),
HotWaterFixtures: Column.new('hot_water_fixtures', true, true, :frac),
HotWaterShowers: Column.new('hot_water_showers', true, true, :frac),
HotWaterShowers: Column.new('hot_water_showers', true, true, :frac),
HotWaterRecirculationPump: Column.new('hot_water_recirculation_pump', true, false, :frac),
GeneralWaterUse: Column.new('general_water_use', true, false, :frac),
Sleeping: Column.new('sleeping', false, false, nil),
Expand Down
Loading
Loading