Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow crawlspaces/basements with only Walls #1548

Merged
merged 4 commits into from
Nov 10, 2023

Conversation

shorowit
Copy link
Contributor

@shorowit shorowit commented Nov 10, 2023

Pull Request Description

Allow users to define above-grade crawlspaces/basements that only use Wall elements (i.e., no FoundationWall elements) for flexibility. Previously our Schematron rules would prevent it.

Checklist

PR Author: Check these when they're done. Not all may apply. strikethrough and check any that do not apply.

PR Reviewer: Verify each has been completed.

  • Schematron validator (EPvalidator.xml) has been updated
  • Sample files have been added/updated (openstudio tasks.rb update_hpxmls)
  • Tests have been added/updated (e.g., HPXMLtoOpenStudio/tests/test*.rb and/or workflow/tests/test*.rb)
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected changes to simulation results of sample files

@shorowit shorowit added the enhancement New feature or request label Nov 10, 2023
@shorowit shorowit self-assigned this Nov 10, 2023
@shorowit shorowit marked this pull request as ready for review November 10, 2023 16:13
@shorowit shorowit merged commit 22d9e4d into master Nov 10, 2023
@shorowit shorowit deleted the foundations_with_walls_only branch November 10, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant