Refactor constants #1808
Merged
Refactor constants #1808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o constants_refactor # Conflicts: # BuildResidentialHPXML/measure.xml # BuildResidentialHPXML/resources/geometry.rb [ci skip]
shorowit
commented
Aug 21, 2024
joseph-robertson
approved these changes
Aug 21, 2024
…o constants_refactor # Conflicts: # BuildResidentialScheduleFile/measure.xml # HPXMLtoOpenStudio/measure.xml # HPXMLtoOpenStudio/resources/hotwater_appliances.rb # HPXMLtoOpenStudio/resources/schedules.rb # HPXMLtoOpenStudio/tests/test_hotwater_appliance.rb # ReportUtilityBills/measure.xml
This was referenced Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Addresses #1759. Refactors
HPXMLtoOpenStudio/resources/constants.rbinto an actual set of constants (previously methods). Also creates a new:HPXMLtoOpenStudio/resources/calendar.rbresource file that pulls methods fromschedules.rbandconstants.rbBuildResidentialHPXML/resources/constants.rbresource file that collects hardcoded stringsNo diffs expected.
Checklist
Not all may apply:
EPvalidator.xml) has been updatedopenstudio tasks.rb update_hpxmls)HPXMLtoOpenStudio/tests/test*.rband/orworkflow/tests/test*.rb)openstudio tasks.rb update_measureshas been run