Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use E+ 24.2 "Keep Site Location Information" field #1830

Draft
wants to merge 1 commit into
base: os390
Choose a base branch
from
Draft

Use E+ 24.2 "Keep Site Location Information" field #1830

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion HPXMLtoOpenStudio/resources/location.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,16 @@ def self.apply(model, weather, hpxml_header, hpxml_bldg)
# @param hpxml_bldg [HPXML::Building] HPXML Building object representing an individual dwelling unit
# @return [nil]
def self.apply_site(model, hpxml_bldg)
# Note: None of these affect the model; see https://github.com/NREL/EnergyPlus/issues/10579.
site = model.getSite
site.setName("#{hpxml_bldg.city}_#{hpxml_bldg.state_code}")
site.setLatitude(hpxml_bldg.latitude)
site.setLongitude(hpxml_bldg.longitude)
site.setTimeZone(hpxml_bldg.time_zone_utc_offset)
site.setElevation(UnitConversions.convert(hpxml_bldg.elevation, 'ft', 'm').round)

# Tell EnergyPlus to use these values, not what's in the weather station (which
# may be at a very different, e.g., elevation)
site.setKeepSiteLocationInformation(true)
end

# Set calendar year on the OpenStudio YearDescription object.
Expand Down
4 changes: 0 additions & 4 deletions workflow/tests/util.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,10 +382,6 @@ def _verify_outputs(rundir, hpxml_path, results, hpxml, unit_multiplier)
if timestep > 15
next if message.include?('Timestep: Requested number') && message.include?('is less than the suggested minimum')
end
# Location doesn't match EPW station (see https://github.com/NREL/EnergyPlus/issues/10579)
if hpxml_path.include? 'base-location-detailed.xml'
next if message.include? 'Weather file location will be used rather than entered (IDF) Location object.'
end
# Coil speed level EMS
if hpxml_header.hvac_onoff_thermostat_deadband
next if message.include?('Wrong coil speed EMS override value, for unit=') && message.include?('Exceeding maximum coil speed level.') # Speed level actuator throws this error when speed is set to 1 but no load
Expand Down