Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPWH capacity inputs #1857

Merged
merged 9 commits into from
Oct 16, 2024
Merged

HPWH capacity inputs #1857

merged 9 commits into from
Oct 16, 2024

Conversation

shorowit
Copy link
Contributor

@shorowit shorowit commented Oct 14, 2024

Pull Request Description

Addresses #1427. Allows optional HeatingCapacity and BackupHeatingCapacity inputs for HPWHs. Defaults same as before.

Checklist

Not all may apply:

  • Schematron validator (EPvalidator.xml) has been updated
  • Sample files have been added/updated (openstudio tasks.rb update_hpxmls)
  • Tests have been added/updated (e.g., HPXMLtoOpenStudio/tests/test*.rb and/or workflow/tests/test*.rb)
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected changes to simulation results of sample files

@shorowit shorowit added the enhancement New feature or request label Oct 14, 2024
@shorowit shorowit self-assigned this Oct 14, 2024
@shorowit shorowit mentioned this pull request Oct 14, 2024
4 tasks
@shorowit
Copy link
Contributor Author

Should probably disallow HeatingCapacity=0 for all water heaters in either the HPXML schema or OS-HPXML Schematron.

Base automatically changed from cfis_continued to master October 16, 2024 16:55
@shorowit
Copy link
Contributor Author

Should probably disallow HeatingCapacity=0 for all water heaters in either the HPXML schema or OS-HPXML Schematron.

@joseph-robertson I am going to prevent zero for a water heater's HeatingCapacity, so e.g. that should prevent ResStock from modeling a HPWH with zero heat pump capacity. However, ResStock could still have an issue where a HPWH's BackupHeatingCapacity would end up zero. That is a legitimate possibility for some 120V HPWHs, so we can't disallow zero, but probably not what ResStock should use for its HPWH options.

@shorowit shorowit merged commit 2de51a2 into master Oct 16, 2024
7 checks passed
@shorowit shorowit deleted the hpwh_capacities branch October 16, 2024 21:57
@joseph-robertson joseph-robertson mentioned this pull request Oct 23, 2024
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant