Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HVAC models per RESNET HVAC addendum #1879

Draft
wants to merge 113 commits into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from 61 commits
Commits
Show all changes
113 commits
Select commit Hold shift + click to select a range
7e5af49
updated fan watts per cfm default, added fan model type
yzhou601 Nov 9, 2024
bee0df1
update measures
yzhou601 Nov 9, 2024
54e3ad7
Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…
yzhou601 Nov 13, 2024
a7d4806
fix tests, changed defrost fan power cubic calculation to follow the …
yzhou601 Nov 13, 2024
b40b1e6
one more fix
yzhou601 Nov 14, 2024
06c27af
Latest results.
Nov 14, 2024
2d1fb0c
revert measured w/cfm defaults, updated rated fan power default, docs…
yzhou601 Nov 14, 2024
22af55b
Merge branch 'resnet_heat_pump' of https://github.com/NREL/OpenStudio…
yzhou601 Nov 14, 2024
554f49a
Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…
yzhou601 Nov 14, 2024
bf5d323
update_measures
yzhou601 Nov 14, 2024
ac9c0e1
temporarily reverted indoor sensibility change
yzhou601 Nov 15, 2024
c2c484d
Latest results.
Nov 15, 2024
f05a5bf
Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…
yzhou601 Nov 25, 2024
a322dc4
update measures
yzhou601 Nov 25, 2024
9c9d5be
Merge branch 'resnet_heat_pump' of https://github.com/NREL/OpenStudio…
yzhou601 Nov 25, 2024
3cae1a8
Latest results.
Nov 25, 2024
f2f9135
Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…
yzhou601 Dec 11, 2024
1edbedd
Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…
yzhou601 Dec 12, 2024
7a5f48a
Updated indoor sensitivity coefficients
yzhou601 Dec 13, 2024
abb9663
added temperature bounds for indoor sensitivity
yzhou601 Dec 13, 2024
01c5315
Latest results.
Dec 13, 2024
c495f89
Latest results.
Dec 13, 2024
f1e8a75
renamed fanmotortype, and started variable speed assumption update
yzhou601 Dec 13, 2024
7ffcbff
Merge branch 'resnet_heat_pump' of https://github.com/NREL/OpenStudio…
yzhou601 Dec 13, 2024
ab5d5eb
one more rename
yzhou601 Dec 13, 2024
f0fe87e
Allows optional EER or EER2 inputs for central air conditioners/heat …
shorowit Dec 13, 2024
32d32c9
Merge branch 'resnet_heat_pump' of https://github.com/NREL/OpenStudio…
shorowit Dec 13, 2024
96c7f41
A couple more comments [ci skip]
shorowit Dec 13, 2024
4c4b2bf
Fix approach, use placeholder.
shorowit Dec 13, 2024
f0c441f
Allow CI simulation results even when unit tests fail.
shorowit Dec 13, 2024
0ad8ce4
Latest results.
Dec 13, 2024
4fa0b69
Merge branch 'resnet_heat_pump' of https://github.com/NREL/OpenStudio…
shorowit Dec 13, 2024
f5de7a6
Latest results.
Dec 13, 2024
d9e50cb
changed room ac/ ptac eer to ceer to follow similar logic, some rename
yzhou601 Dec 16, 2024
2d3dee3
remove use_eer, use_eer_cop variables, address comments
yzhou601 Dec 16, 2024
6c97afb
update measures
yzhou601 Dec 16, 2024
ac32c75
Latest results.
Dec 17, 2024
e759a59
Create is_room_dx_hvac_system method to centralize logic, and other m…
shorowit Dec 17, 2024
1a574b7
Merge pull request #1897 from NREL/eer_inputs
shorowit Dec 17, 2024
17f9051
fix unit tests
yzhou601 Dec 17, 2024
00db61d
Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…
yzhou601 Dec 17, 2024
2bd0386
Latest results.
Dec 17, 2024
9fa94f3
Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…
shorowit Dec 24, 2024
2e79ad3
Add EER2 defaults based on regression of ENERGY STAR products.
shorowit Dec 24, 2024
de85bbb
Latest results.
Dec 24, 2024
d96cf24
Merge branch 'resnet_heat_pump' of https://github.com/NREL/OpenStudio…
shorowit Dec 24, 2024
f5d763a
Remove EER defaulting from defaults.rb, update tests in test_defaults…
shorowit Dec 24, 2024
8fdffff
Latest results.
Dec 24, 2024
e067c09
Eliminate diffs
shorowit Dec 24, 2024
74696c4
Merge branch 'eer_defaults' of https://github.com/NREL/OpenStudio-HPX…
shorowit Dec 24, 2024
7a1d223
Latest results.
Dec 24, 2024
b4beb83
Merge pull request #1902 from NREL/eer_defaults
shorowit Dec 26, 2024
6b2f3e8
Update default crankcase heater power.
shorowit Dec 26, 2024
c18ed4f
Small bugfix and cleanup.
shorowit Dec 26, 2024
3a1c29b
First pass.
shorowit Dec 26, 2024
c36aa2f
Merge branch 'resnet_heat_pump' of https://github.com/NREL/OpenStudio…
shorowit Dec 26, 2024
d1b6749
Update Changelog.md
shorowit Dec 26, 2024
fc157cf
Latest results.
Dec 26, 2024
8a55975
Update comment [ci skip]
shorowit Dec 27, 2024
29708df
Use uppercase letters for PSC/BPM, add full names in docs
shorowit Dec 27, 2024
889667d
Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…
shorowit Jan 3, 2025
26b721a
Latest results.
Jan 3, 2025
85effef
Merge branch 'resnet_heat_pump' of https://github.com/NREL/OpenStudio…
shorowit Jan 3, 2025
46c1362
update EPvalidator.xml
yzhou601 Jan 3, 2025
f317c36
simplify calculate_fan_power_from_curve and minor doc fix
yzhou601 Jan 3, 2025
5bdc554
update calculate_fan_power_from_curve
yzhou601 Jan 3, 2025
80776d1
Add capacity & power datapoint checks.
shorowit Jan 3, 2025
5a8c811
Merge branch 'resnet_heat_pump' of https://github.com/NREL/OpenStudio…
shorowit Jan 3, 2025
143b37e
Simplify extrapolation bounds.
shorowit Jan 3, 2025
11d271c
Minor code cleanup.
shorowit Jan 3, 2025
3ea0043
Perform extrapolation until values become negative.
shorowit Jan 6, 2025
f865e5c
Simplify implementation to remove step search [ci skip]
shorowit Jan 6, 2025
b90c066
Restrict outdoor temperatures for detailed datapoints so we can apply…
shorowit Jan 7, 2025
bb03af4
power calculation for ptac/pthp
yzhou601 Jan 7, 2025
b2caf33
elsif instead of else
yzhou601 Jan 7, 2025
d67c410
simplify indoor temperature bounds
yzhou601 Jan 7, 2025
63bff27
Latest results.
Jan 7, 2025
fc63ba3
Merge branch 'resnet_heat_pump' of https://github.com/NREL/OpenStudio…
shorowit Jan 7, 2025
d01e7ff
Fixes some CI failures.
shorowit Jan 7, 2025
631fd33
Revert max compressor temp input.
shorowit Jan 9, 2025
061a46a
fix max power program
yzhou601 Jan 10, 2025
f3738bb
update measure
yzhou601 Jan 10, 2025
63204b7
Merge branch 'datapoint_extrapolation' of https://github.com/NREL/Ope…
yzhou601 Jan 10, 2025
4727080
Latest results.
Jan 10, 2025
4e79872
Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…
shorowit Jan 11, 2025
814cce1
Latest results.
Jan 11, 2025
ba5a075
Merge branch 'resnet_heat_pump' of https://github.com/NREL/OpenStudio…
shorowit Jan 13, 2025
5634c0a
Small docs image improvement [ci skip]
shorowit Jan 13, 2025
da7b493
Fix adaptive step size method and address PR review comments.
shorowit Jan 15, 2025
03f284c
Remove debug code
shorowit Jan 15, 2025
c986342
Latest results.
Jan 15, 2025
03cd5f1
Disallow 60F heating/cooling datapoints and address additional review…
shorowit Jan 15, 2025
5848d90
Forgot to commit these changes too
shorowit Jan 15, 2025
e3badf5
Update test.
shorowit Jan 15, 2025
a803ed6
Latest results.
Jan 15, 2025
bb1638b
Double tolerance to reduce number of datapoints by 2x with minimal im…
shorowit Jan 16, 2025
2851dd1
Merge branch 'datapoint_extrapolation' of https://github.com/NREL/Ope…
shorowit Jan 16, 2025
f2412b2
Latest results.
Jan 16, 2025
df1499e
Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…
shorowit Jan 16, 2025
ab23aaf
Merge branch 'resnet_heat_pump' of https://github.com/NREL/OpenStudio…
shorowit Jan 16, 2025
2d40a2c
Implement 50% RESNET rule for min cooling ODB extrapolation. Code cle…
shorowit Jan 16, 2025
e698b9b
Bugfix and rename variables for clarity.
shorowit Jan 16, 2025
3f93237
Latest results.
Jan 16, 2025
1dfc3c6
Bugfix for situation where cooling input power is increasing at lower…
shorowit Jan 17, 2025
00efee5
Latest results.
Jan 17, 2025
0ea97fd
Using a more conservative min ODB temperature for cooling performance…
shorowit Jan 17, 2025
0f16d7c
Merge branch 'datapoint_extrapolation' of https://github.com/NREL/Ope…
shorowit Jan 17, 2025
259226a
Latest results.
Jan 17, 2025
b9e3429
Merge pull request #1904 from NREL/datapoint_extrapolation
shorowit Jan 17, 2025
5d2d34e
Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…
yzhou601 Jan 28, 2025
706672c
update measures
yzhou601 Jan 28, 2025
3f0b0e3
implemented most default assumptions into OS-HPXML, still needs to re…
yzhou601 Jan 30, 2025
f191e0b
fix a few issues to run test files
yzhou601 Jan 30, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ jobs:

merge-results:
runs-on: ubuntu-22.04
needs: [run-workflow1-tests, run-workflow2-tests, run-unit-tests]
needs: [run-workflow1-tests, run-workflow2-tests]
steps:
- uses: actions/checkout@v4
with:
Expand Down
3 changes: 1 addition & 2 deletions BuildResidentialHPXML/measure.rb
Original file line number Diff line number Diff line change
Expand Up @@ -6435,8 +6435,7 @@ def self.set_ventilation_fans(hpxml_bldg, args)
if distribution_system_idref.nil?
# Allow for PTAC/PTHP by automatically adding a DSE=1 distribution system to attach the CFIS to
hpxml_bldg.hvac_systems.each do |hvac_system|
next unless (hvac_system.is_a?(HPXML::CoolingSystem) && [HPXML::HVACTypePTAC, HPXML::HVACTypeRoomAirConditioner].include?(hvac_system.cooling_system_type)) ||
(hvac_system.is_a?(HPXML::HeatPump) && [HPXML::HVACTypeHeatPumpPTHP, HPXML::HVACTypeHeatPumpRoom].include?(hvac_system.heat_pump_type))
next unless HVAC.is_room_dx_hvac_system(hvac_system)

hpxml_bldg.hvac_distributions.add(id: "HVACDistribution#{hpxml_bldg.hvac_distributions.size + 1}",
distribution_system_type: HPXML::HVACDistributionTypeDSE,
Expand Down
6 changes: 3 additions & 3 deletions BuildResidentialHPXML/measure.xml
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
<schema_version>3.1</schema_version>
<name>build_residential_hpxml</name>
<uid>a13a8983-2b01-4930-8af2-42030b6e4233</uid>
<version_id>9020722b-d574-4332-96a0-10d947d437fc</version_id>
<version_modified>2025-01-02T23:48:53Z</version_modified>
<version_id>9b36b792-68b7-48ff-a053-8581e5fbb4fa</version_id>
<version_modified>2025-01-03T03:34:13Z</version_modified>
<xml_checksum>2C38F48B</xml_checksum>
<class_name>BuildResidentialHPXML</class_name>
<display_name>HPXML Builder</display_name>
Expand Down Expand Up @@ -7544,7 +7544,7 @@
<filename>measure.rb</filename>
<filetype>rb</filetype>
<usage_type>script</usage_type>
<checksum>DF604C07</checksum>
<checksum>CD62272E</checksum>
</file>
<file>
<filename>constants.rb</filename>
Expand Down
6 changes: 6 additions & 0 deletions Changelog.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
## OpenStudio-HPXML v1.10.0

__New Features__
- HVAC modeling updates:
- Updated DX heat pump and air conditioner models per RESNET MINHERS Addendum 82.
- Allows optional EER or EER2 inputs for central air conditioners/heat pumps and mini-splits.

__Bugfixes__
- Fixes zero occupants specified for one unit in a whole MF building from being treated like zero occupants for every unit.
Expand Down Expand Up @@ -52,6 +55,9 @@ __New Features__
- Optional input `SimulationControl/AdvancedResearchFeatures/OnOffThermostatDeadbandTemperature` to model on/off thermostat deadband with start-up degradation for single and two speed AC/ASHP systems and time-based realistic staging for two speed AC/ASHP systems.
- Optional input `SimulationControl/AdvancedResearchFeatures/HeatPumpBackupCapacityIncrement` to model multi-stage electric backup coils with time-based staging.
- Maximum power ratio detailed schedule for variable-speed HVAC systems can now be used with `NumberofUnits` dwelling unit multiplier.
- RESNET HVAC modeling appendix:
- Added optional `extension/FanMotorType`, changed rated fan power (w/cfm) and measured FanPowerWattsPerCFM assumptions to be based on fan motor type.
- Updated the fan power calculation at each speed to be based on fan model type and whether ducted.
- BuildResidentialHPXML measure:
- **Breaking change**: Replaced `slab_under_width` and `slab_perimeter_depth` arguments with `slab_under_insulation_width` and `slab_perimeter_insulation_depth`
- **Breaking change**: Replaced `schedules_vacancy_periods`, `schedules_power_outage_periods`, and `schedules_power_outage_periods_window_natvent_availability` arguments with `schedules_unavailable_period_types`, `schedules_unavailable_period_dates`, and `schedules_unavailable_period_window_natvent_availabilities`; this improves flexibility for handling more unavailable period types.
Expand Down
20 changes: 10 additions & 10 deletions HPXMLtoOpenStudio/measure.xml
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
<schema_version>3.1</schema_version>
<name>hpxm_lto_openstudio</name>
<uid>b1543b30-9465-45ff-ba04-1d1f85e763bc</uid>
<version_id>95e76879-5bd0-4f40-9bc9-a6f07b622400</version_id>
<version_modified>2025-01-03T03:27:12Z</version_modified>
<version_id>7fcc111a-b955-4915-915b-1782dd485bf7</version_id>
<version_modified>2025-01-03T20:32:45Z</version_modified>
<xml_checksum>D8922A73</xml_checksum>
<class_name>HPXMLtoOpenStudio</class_name>
<display_name>HPXML to OpenStudio Translator</display_name>
Expand Down Expand Up @@ -327,7 +327,7 @@
<filename>defaults.rb</filename>
<filetype>rb</filetype>
<usage_type>resource</usage_type>
<checksum>EB4D5A1A</checksum>
<checksum>7646CD36</checksum>
</file>
<file>
<filename>energyplus.rb</filename>
Expand Down Expand Up @@ -357,7 +357,7 @@
<filename>hpxml.rb</filename>
<filetype>rb</filetype>
<usage_type>resource</usage_type>
<checksum>270F2EEB</checksum>
<checksum>DC04D304</checksum>
</file>
<file>
<filename>hpxml_schema/HPXML.xsd</filename>
Expand All @@ -375,7 +375,7 @@
<filename>hpxml_schematron/EPvalidator.xml</filename>
<filetype>xml</filetype>
<usage_type>resource</usage_type>
<checksum>105F837D</checksum>
<checksum>0AC30606</checksum>
</file>
<file>
<filename>hpxml_schematron/iso-schematron.xsd</filename>
Expand All @@ -387,13 +387,13 @@
<filename>hvac.rb</filename>
<filetype>rb</filetype>
<usage_type>resource</usage_type>
<checksum>0A9C42C1</checksum>
<checksum>A5094D87</checksum>
</file>
<file>
<filename>hvac_sizing.rb</filename>
<filetype>rb</filetype>
<usage_type>resource</usage_type>
<checksum>A079BB8E</checksum>
<checksum>8F69ECDF</checksum>
</file>
<file>
<filename>internal_gains.rb</filename>
Expand Down Expand Up @@ -663,7 +663,7 @@
<filename>test_defaults.rb</filename>
<filetype>rb</filetype>
<usage_type>test</usage_type>
<checksum>7E9FC2FA</checksum>
<checksum>25AB39F0</checksum>
</file>
<file>
<filename>test_enclosure.rb</filename>
Expand All @@ -687,7 +687,7 @@
<filename>test_hvac.rb</filename>
<filetype>rb</filetype>
<usage_type>test</usage_type>
<checksum>7954392A</checksum>
<checksum>20BDB294</checksum>
</file>
<file>
<filename>test_hvac_sizing.rb</filename>
Expand Down Expand Up @@ -735,7 +735,7 @@
<filename>test_validation.rb</filename>
<filetype>rb</filetype>
<usage_type>test</usage_type>
<checksum>86EC5703</checksum>
<checksum>DEFF0AA8</checksum>
</file>
<file>
<filename>test_water_heater.rb</filename>
Expand Down
Loading
Loading