Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up weather processing #1941

Merged
merged 7 commits into from
Mar 3, 2025
Merged

Speed up weather processing #1941

merged 7 commits into from
Mar 3, 2025

Conversation

shorowit
Copy link
Contributor

@shorowit shorowit commented Mar 1, 2025

Pull Request Description

Internally cache weather-processed data so that if, e.g., WeatherFile.new is called from different OpenStudio measures, we don't have to re-process the data. Also found a couple other opportunities to reduce processing related to weather.

Primarily speeds things up when:

  1. Running unit tests (when measures are run repeatedly within the same openstudio/ruby call)
  2. Running simulations where the BuildResidentialHPXML and/or BuildResidentialScheduleFile measures are used

CI results from running unit tests on:

  • master: 43:43
  • this branch: 36:49

Checklist

Not all may apply:

  • Schematron validator (EPvalidator.xml) has been updated
  • Sample files have been added/updated (openstudio tasks.rb update_hpxmls)
  • Tests have been added/updated (e.g., HPXMLtoOpenStudio/tests/test*.rb and/or workflow/tests/test*.rb)
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected changes to simulation results of sample files

… from, e.g., different OpenStudio measures, we don't have to re-process the data. Also found a couple other opportunities to reduce processing related to weather.
@shorowit shorowit self-assigned this Mar 1, 2025
@shorowit shorowit marked this pull request as ready for review March 3, 2025 16:11
@shorowit shorowit mentioned this pull request Mar 3, 2025
12 tasks
@shorowit shorowit merged commit fd722bb into master Mar 3, 2025
7 checks passed
@shorowit shorowit deleted the speedup_weather branch March 3, 2025 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant