Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comment out debug print statements #5200

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
+2 −2
Open

Comment out debug print statements #5200

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ruby/engine/RubyEngine.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ RubyEngine::~RubyEngine() {
// ruby_cleanup calls ruby_finalize
int ex = ruby_cleanup(0);
if (ex != 0) {
fmt::print("RubyEngine return code was {}\n", ex);
// fmt::print("RubyEngine return code was {}\n", ex);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I want this one gone...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't seem like standard practice to print the exit code? After all, anyone can easily obtain the exit code themself.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The message was to explain why it returned a non zero exit code.

When running something like

OpenStudio/src/cli/test/at_exit.rb

Lines 1 to 3 in 20d91f5

at_exit {
exit 12
}

But sure, I suppose that's fine removing it

exit(ex);
}
//ruby_finalize();
Expand Down
2 changes: 1 addition & 1 deletion src/cli/RunCommand.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ namespace cli {
app->add_flag(
"-m,--measures_only",
[opt](std::int64_t val) {
fmt::print("val={}\n", val);
// fmt::print("val={}\n", val);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally ok here

opt->no_simulation = (val == 1);
},
"Only run the OpenStudio and EnergyPlus measures");
Expand Down
Loading