Fix #5343 - Design Range Temperature for OS:CoolingTower:SingleSpeed is not being converted into EnergyPlus

[jmarrec]

Pull request overview

• Fixes Design Range Temperature for OS:CoolingTower:SingleSpeed is not being converted into EnergyPlus #5343
• Fixes CoolingTower:SingleSpeed forward translates design approach temperature as design temperature range #5338

Pull Request Author

• Model API Changes / Additions: None
• Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate): Corrected
• Model API methods are tested (in src/model/test): No Change
• EnergyPlus ForwardTranslator Tests (in src/energyplus/Test): Added a new unit test file
• If a new object or method, added a test in NREL/OpenStudio-resources: N/A, but could cause regressions
  • Could cause regression in water_economizer.osm and coolingtowers.osm
• If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
• Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
• All new and existing tests passes
• If methods have been deprecated, update rest of code to use the new methods

Labels:

• If change to an IDD file, add the label IDDChange
• If breaking existing API, add the label APIChange
• If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

• Perform a Code Review on GitHub
• Code Style, strip trailing whitespace, etc.
• All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
• Labeling is ok
• If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
• If feature, test running new feature, try creative ways to break it
• CI status: all green or justified

[jmarrec]

There was no FT test for the object, so I started by adding one

[jmarrec]

Note

[jmarrec]

$ ninja && Products/openstudio_energyplus_tests -- --gtest_filter=*ForwardTranslator_CoolingTowerSingleSpeed*
[100%][2/2] Linking CXX executable Products/openstudio_energyplus_tests
Running main() from gmock_main.cc
Note: Google Test filter = *ForwardTranslator_CoolingTowerSingleSpeed*
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from EnergyPlusFixture
[ RUN      ] EnergyPlusFixture.ForwardTranslator_CoolingTowerSingleSpeed
/media/DataExt4/Software/Others/OpenStudio3/src/energyplus/Test/CoolingTowerSingleSpeed_GTest.cpp:115: Failure
Expected equality of these values:
  5.55
  idfObject.getDouble(CoolingTower_SingleSpeedFields::DesignRangeTemperature).get()
    Which is: 3.89

[  FAILED  ] EnergyPlusFixture.ForwardTranslator_CoolingTowerSingleSpeed (217 ms)
[----------] 1 test from EnergyPlusFixture (217 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test suite ran. (218 ms total)
[  PASSED  ] 0 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] EnergyPlusFixture.ForwardTranslator_CoolingTowerSingleSpeed

[jmarrec]

This was a copy paste error

[ci-commercialbuildings]

CI Results for d438c3b:

• Ubuntu 24.04:

  • OpenStudio-3.9.1-alpha+d438c3bc5a-Ubuntu-24.04-x86_64.deb
  • OpenStudio-3.9.1-alpha+d438c3bc5a-Ubuntu-24.04-x86_64.tar.gz

• Ubuntu 22.04:

• Darwin:

  • OpenStudio-3.9.1-alpha+d438c3bc5a-Darwin-x86_64.dmg
  • OpenStudio-3.9.1-alpha+d438c3bc5a-Darwin-x86_64.tar.gz

• Windows:

  • OpenStudio-3.9.1-alpha+d438c3bc5a-Windows.exe
  • OpenStudio-3.9.1-alpha+d438c3bc5a-Windows.tar.gz

• Code Coverage:

[eringold]

also fixes (duplicate issue): #5338

[jmarrec]

Thanks @eringold I just took the issue list from the top down and didn't get there!

[joseph-robertson]

Probably a copy-paste mistake of modelObject.designApproachTemperature()? New FT test 👍

[jmarrec]

Yeah, defiitely a copy paste issue. Strange that it took us (and I mean the entire community) 8 years to notice it though.