Merge pull request #341 from NREL/develop

Migrate Xpress tests to HiGHS, Fix Wind on Windows OS

CHANGELOG.md

@@ -23,6 +23,12 @@ Classify the change according to the following categories:
     ### Deprecated
     ### Removed
 
+## Develop 2023-12-16
+### Changed
+- Changed testing suite from using Xpress to using HiGHS, an open-source solver.  This has led to a reduction in the number of tests due to incompatibility with indicator constraints.
+### Fixed
+- Fixed issue with running Wind on Windows: add execute permission for ssc.dll
+
 ## v0.39.0
 ### Added
 - Added new technology `ElectricHeater` which uses electricity as input and provides heating as output; load balancing constraints have been updated accordingly

src/core/production_factor.jl

@@ -139,6 +139,7 @@ function get_production_factor(wind::Wind, latitude::Real, longitude::Real, time
         end
 
         global hdl = joinpath(@__DIR__, "..", "sam", libfile)
+        chmod(hdl, filemode(hdl) | 0o755)
         wind_module = @ccall hdl.ssc_module_create("windpower"::Cstring)::Ptr{Cvoid}
         wind_resource = @ccall hdl.ssc_data_create()::Ptr{Cvoid}  # data pointer
         @ccall hdl.ssc_module_exec_set_print(0::Cint)::Cvoid

test/broken_tests.txt

@@ -0,0 +1,11 @@
+This is a breakdown of testsets that include broken and updated tests due to the migration from Xpress to HiGHS in GitHub Actions.
+
+- CHP sizing: 1 test value updated due to new obtained solution within 1% optimality
+- CHP Supplementary firing and standby: 11 tests broken due to solver incompatibility (indicator constraints) 
+- Single RC Model Heating only: 9 tests broken due to solver incompatibility or tests that use prior results from an incompatible test
+- Do not allow_simultaneous_export_import: 1 test broken due to solver incompatibility
+- Solar and ElectricStorage w/BAU and degradation: 6 tests broken due to solver incompatibility
+- Minimize Unserved Load: 18 tests broken due to solver incompatibility
+- Outages with Wind and supply-to-load no greater than critical load: 2 tests broken due to either incompatibility or infeasibility
+- Wind: 3 tests broken due to incompatibility or infeasibility
+- Emissions and Renewable Energy Percent: ~50 tests broken or skipped due to incompatibility or tests use prior results from an incompatible test