MPC TLDRD #418

hdunham · 2024-06-18T19:22:02Z

No description provided.

…h kw remaining after bin shift bug fixed in 013bfaf)

hdunham · 2024-07-31T22:05:04Z

src/mpc/structs.jl

+    can_grid_charge::Bool = true
+    grid_charge_efficiency::Float64 = can_grid_charge ? charge_efficiency : 0.0
+    size_kw::Float64 = charge_limit_kw + discharge_limit_kw
+    max_kw::Float64 = min(charge_limit_kw, discharge_limit_kw)


what's the reason that we need these max fields in all the MPC storage structs when the sizes are fixed?

hdunham · 2024-07-31T22:11:30Z

src/mpc/structs.jl

+    soc_init_fraction::Float64 = 0.5
+    can_grid_charge::Bool = true
+    grid_charge_efficiency::Float64 = can_grid_charge ? charge_efficiency : 0.0
+    size_kw::Float64 = charge_limit_kw + discharge_limit_kw


why would the size be this sum? do we even want this field? looks like the constraint that uses it is commented out and would be duplicative since we already have the charge and discharge limits.

hdunham · 2024-08-01T16:47:07Z

src/results/electric_heater.jl

+- `thermal_to_space_heating_load_series_mmbtu_per_hour`  # Thermal power production to serve the space heating load series [MMBtu/hr]
+- `thermal_to_process_heat_load_series_mmbtu_per_hour`  # Thermal power production to serve the process heating load series [MMBtu/hr]
+
+!!! note "'Series' and 'Annual' energy outputs are average annual"


I don't think this note applies to MPC?

hdunham · 2024-08-01T16:56:26Z

src/results/electric_heater.jl

+    end
+    r["thermal_to_space_heating_load_series_mmbtu_per_hour"] = round.(value.(ElectricHeaterToSpaceHeatingKW ./ KWH_PER_MMBTU), digits=5)
+
+    if "ProcessHeat" in p.heating_loads && p.s.electric_heater.can_serve_space_heating


Is this supposed to be can_use_process_heat instead of can_serve_space_heating?

hdunham · 2024-08-01T17:00:23Z

src/results/electric_heater.jl

+        @expression(m, ElectricHeaterToHotTESKW[ts in p.time_steps], 0.0)
+        @expression(m, ElectricHeaterToHotTESByQualityKW[q in p.heating_loads, ts in p.time_steps], 0.0)
+    end
+	r["thermal_to_storage_series_mmbtu_per_hour"] = round.(value.(ElectricHeaterToHotTESKW) / KWH_PER_MMBTU, digits=3)


should time_steps_per_hour be considered in these calcs? I see they aren't in the non-MPC version above either

actually never mind maybe not since it's thermal_to_storage_series_mmbtu_per_hour so we want the hour in the units

hdunham · 2024-08-01T18:16:26Z

src/results/electric_storage.jl

@@ -5,6 +5,8 @@
 - `size_kwh` Optimal storage capacity
 - `soc_series_fraction` Vector of normalized (0-1) state of charge values over the first year
 - `storage_to_load_series_kw` Vector of power used to meet load over the first year
+- `storage_to_electrolyzer_series_kw` Vector of power used by electrolyzer over the first year


does storage to electric heater also need to be added?

hdunham · 2024-08-01T18:20:15Z

src/results/electric_storage.jl

@@ -43,9 +45,21 @@ function add_electric_storage_results(m::JuMP.AbstractModel, p::REoptInputs, d::
                ))
            end
         end
+
+        if !isempty(p.techs.electrolyzer)


For consistency, I think either storage_to_electrolyzer_series_kw and storage_to_compressor_series_kw should be created and set to [] if these tech sets are empty, or they should only be created in the else below if the corresponding sets aren't empty.

I think the latter for consistency with elsewhere

hdunham · 2024-08-01T18:23:59Z

src/results/electric_utility.jl

@@ -4,6 +4,8 @@
 - `annual_energy_supplied_kwh` # Total energy supplied from the grid in an average year.
 - `electric_to_load_series_kw` # Vector of power drawn from the grid to serve load.
 - `electric_to_storage_series_kw` # Vector of power drawn from the grid to charge the battery.
+- `electric_to_electrolyzer_series_kw` # Vector of power drawn from the grid to be used by electrolyzer.


does electric heater need to be added too?

hdunham · 2024-08-01T18:33:02Z

src/results/electric_utility.jl


    if p.s.storage.attr["ElectricStorage"].size_kwh > 0
        GridToBatt = @expression(m, [ts in p.time_steps], 
            sum(m[Symbol("dvGridToStorage"*_n)][b, ts] for b in p.s.storage.types.elec) 
 		)
-        r["to_battery_series_kw"] = round.(value.(GridToBatt), digits=3).data
+        r["electric_to_storage_series_kw"] = round.(value.(GridToBatt), digits=3).data
    else
        GridToBatt = zeros(length(p.time_steps))
    end
    GridToLoad = @expression(m, [ts in p.time_steps], 


need to subtract out grid to other things here too? e.g. electrolyzer

hdunham · 2024-08-01T18:34:41Z

src/results/electric_utility.jl

+        r["electric_to_compressor_series_kw"] = round.(value.(GridToCompressor), digits=3)
+    end
+
+    if _n=="" #only output emissions results if not a multinode model


is this because we output all the nodes combined for multinode?

hdunham · 2024-08-01T18:37:35Z

src/results/generator.jl

- `to_grid_series_kw`
- `to_load_series_kw`
- `annual_fuel_consumption_gal`
+- `electric_to_storage_series_kw`


why can't generator supply hydrogen techs?

hdunham · 2024-08-01T18:43:39Z

src/results/heating_cooling_load.jl

+
+"""
+MPC `HeatingLoad` results keys:
+- `process_heat_thermal_load_series_mmbtu_per_hour` vector of site space heating boiler load in every time step


I'm slightly confused about why it's only process heat some places but others there's also dhw and space heating

hdunham · 2024-08-01T18:49:15Z

src/results/thermal_storage.jl

@@ -77,6 +77,9 @@ function add_hot_storage_results(m::JuMP.AbstractModel, p::MPCInputs, d::Dict, b
    soc = (m[Symbol("dvStoredEnergy"*_n)][b, ts] for ts in p.time_steps)
    r["soc_series_fraction"] = round.(value.(soc) ./ p.s.storage.attr[b].size_kwh, digits=3)

+    discharge = (sum(m[Symbol("dvHeatFromStorage"*_n)][b,q,ts] for b in p.s.storage.types.hot, q in p.heating_loads) for ts in p.time_steps)


why sum all the separate heating loads?

hdunham · 2024-08-01T19:09:11Z

src/results/wind.jl

@@ -69,3 +69,64 @@ function add_wind_results(m::JuMP.AbstractModel, p::REoptInputs, d::Dict; _n="")
 	d[t] = r
    nothing
 end
+
+"""
+MPC `Wind` results keys:


can wind serve electric heater too?

hdunham · 2024-08-02T17:15:16Z

src/results/wind.jl

+	r["electric_to_storage_series_kw"] = WindtoBatt
+
+	if !isempty(p.s.electric_tariff.export_bins)
+		WindtoGrid = @expression(m, [ts in p.time_steps],


I've seen issues with results being expressions and thus the type is JuMP.Containers.DenseAxisArray instead of vector

hdunham · 2024-08-02T17:45:00Z

src/results/wind.jl

+
+	WindtoCUR = (m[Symbol("dvCurtail"*_n)][t, ts] for ts in p.time_steps)
+	r["electric_curtailed_series_kw"] = round.(value.(WindtoCUR), digits=3)
+	WindtoLoad = (m[Symbol("dvRatedProduction"*_n)][t, ts] * p.production_factor[t, ts] * p.levelization_factor[t]


does levelization factor apply in MPC?

hdunham · 2024-08-02T18:55:02Z

src/mpc/results.jl

@@ -8,6 +8,8 @@ MPC Scenarios will return a results Dict with the following keys:
 - `ElectricUtility`
 - `PV`
 - `Generator`
+- `Electrolyzer`


should electric heater be added to this list?

hdunham and others added 30 commits September 6, 2023 15:01

use correct FuelCell key

3bd5135

use correct FuelCell key

16c1c94

fix bug applying (dis)charge effic in erp (cancelled out in tests wit…

e7f8a46

…h kw remaining after bin shift bug fixed in 013bfaf)

fix bug applying (dis)charge effic in erp (cancelled out in tests wit…

cc831c7

…h kw remaining after bin shift bug fixed in 013bfaf)

temp comment out non-erp tests

0dec629

temp comment out non-erp tests

365d983

change erp H2 storage units from kwh to kg

baf450a

change erp H2 storage units from kwh to kg

cb5f9b8

temp revert accessing HydrogenStorageLP input model

40cac50

temp revert accessing HydrogenStorageLP input model

8fff514

round not Int to avoid inexact error

e77701b

round not Int to avoid inexact error

bc4ba26

use consistent names for H2 power capacities

e15581b

use consistent names for H2 power capacities

0509813

update use of num_storage_bins_default for H2 due to units change

6058313

update use of num_storage_bins_default for H2 due to units change

8ecc96c

reorder args for dependency

71679a1

reorder args for dependency

cd9935e

use H2 REopt models in ERP and tests

44028a9

use H2 REopt models in ERP and tests

a143876

update test input filenames

6f775b6

update test input filenames

2bc811f

Fix hydrogen bugs

c2b2e34

Fix hydrogen bugs

ca60dd5

ERP testing

da421b7

ERP testing

fda0c53

remove debug file

27e0561

remove debug file

9bddb1c

correct accessing electrolyzer/fuel cell effic inputs

f8bacdb

correct accessing electrolyzer/fuel cell effic inputs

24b6872

hdunham commented Jul 31, 2024

View reviewed changes

hdunham commented Aug 1, 2024

View reviewed changes

add to add_hot_storage_results docstring

82eccb8

hdunham commented Aug 1, 2024

View reviewed changes

hdunham commented Aug 2, 2024

View reviewed changes

indu-manogaran and others added 12 commits August 5, 2024 01:29

Hydrogen model debug

e63a83d

Merge branch 'h2-erp' into h2-tldrd-mpc

d1eaaad

Bug fix

6174dfd

Allow init soc to be read for MPCElectricStorage

14fd1f0

Add time series intermediary emissions variables for MPC

65dcdd6

Hydrogen model update

48424e1

Merge branch 'h2-erp' into h2-tldrd-mpc

cec4cca

Change sum operator to expression emissions

3e4f8b1

Change sum operator to expression emissions

cde2917

RE accounting hydrogen

13ede1e

Merge branch 'develop' into h2-tldrd-mpc

04ed96e

Hydrogen bug fixes

036d516

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MPC TLDRD #418

MPC TLDRD #418

hdunham commented Jun 18, 2024

hdunham Jul 31, 2024

hdunham Jul 31, 2024

hdunham Aug 1, 2024

hdunham Aug 1, 2024

hdunham Aug 1, 2024

hdunham Aug 1, 2024

hdunham Aug 1, 2024

hdunham Aug 1, 2024

hdunham Aug 1, 2024

hdunham Aug 1, 2024

hdunham Aug 1, 2024

hdunham Aug 1, 2024

hdunham Aug 1, 2024

hdunham Aug 1, 2024

hdunham Aug 1, 2024

hdunham Aug 1, 2024

hdunham Aug 2, 2024

hdunham Aug 2, 2024

hdunham Aug 2, 2024

MPC TLDRD #418

Are you sure you want to change the base?

MPC TLDRD #418

Conversation

hdunham commented Jun 18, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment