REopt.jl v0.50.0: Load Year Alignment #625
Merged
+169
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…electric Since heating and cooling loads will now use whatever load year is input for electric, if not otherwise input, we don't want to assign 2017 year for heating and cooling loads, even if they are using CRBs
To shift CRB profiles to the calendar year of the input
zolanaj
approved these changes
Jan 21, 2025
There was a problem hiding this comment.
@Bill-Becker this looks good, thanks! Reviewing for the ASHP force-dispatch update: handling of the new parameter looks correct - I like that null=True, blank=False so that the databse allows an empty value but the Web Tool does not - and the new defaults are working on my end. I made a minor edit to the help text to match closer to what's on the REopt.jl side (tests passed when I sent to a separate branch and then I cherry-picked this over). Under the premise that @adfarth approved the Ghx defaults update, this is good to merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See these updates from REopt.jl PRs:
Also, add db migration file for previous PR merged in: