Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a broken test. (This is the cause of broken tests on other open PRs.)
Pull Request Description
Test broke after the release of a new version of pytest-mock today.
Specifically,
mocked_boto3.mock_calls
changed from this:to this:
The
call.resource().Bucket()
call (from line 136) moved from index 1 to 2, which broke the assert on line 168.This just uses the same params everywhere, so the setup calls don't have to be excluded from the checks.
Checklist
Not all may apply
minimum_coverage
in.github/workflows/coverage.yml
as necessary.Update validation for project config yaml file changesUpdate existing documentationRun a small batch run on Kestrel/Eagle to make sure it all works if you made changes that will affect Kestrel/EagleAdd to the changelog_dev.rst file and propose migration text in the pull request