Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it work both in PR and in the branch #460

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Make it work both in PR and in the branch #460

merged 1 commit into from
Jul 17, 2024

Conversation

rajeee
Copy link
Contributor

@rajeee rajeee commented Jul 17, 2024

Fixes failing pip test in develop ci.

Pull Request Description

Use proper branch reference.

Checklist

Not all may apply

  • Code changes (must work)
  • Tests exercising your feature/bug fix (check coverage report on Checks -> BuildStockBatch Tests -> Artifacts)
  • Coverage has increased or at least not decreased. Update minimum_coverage in .github/workflows/coverage.yml as necessary.
  • All other unit and integration tests passing
  • Update validation for project config yaml file changes
  • Update existing documentation
  • Run a small batch run on Kestrel/Eagle to make sure it all works if you made changes that will affect Kestrel/Eagle
  • Add to the changelog_dev.rst file and propose migration text in the pull request

Copy link

File Coverage
All files 88%
base.py 91%
exc.py 57%
hpc.py 79%
local.py 70%
postprocessing.py 84%
utils.py 92%
cloud/docker_base.py 88%
sampler/base.py 78%
sampler/downselect.py 33%
sampler/precomputed.py 93%
sampler/residential_quota.py 61%
test/shared_testing_stuff.py 85%
test/test_docker.py 33%
test/test_local.py 97%
test/test_validation.py 97%
workflow_generator/base.py 89%
workflow_generator/commercial/commercial.py 52%
workflow_generator/residential/residential_hpxml.py 91%
workflow_generator/residential/test_residential_workflow_generator.py 99%

Minimum allowed coverage is 33%

Generated by 🐒 cobertura-action against 9a3f3d4

@rajeee rajeee merged commit 383b1b8 into develop Jul 17, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants