Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ResStock-HPXML: optional utility bill reporting arguments, try 3 #461

Merged
merged 9 commits into from
Jul 19, 2024

Conversation

joseph-robertson
Copy link
Contributor

Pull Request Description

Supersedes #451 and #457.

Checklist

Not all may apply

  • Code changes (must work)
  • Tests exercising your feature/bug fix (check coverage report on Checks -> BuildStockBatch Tests -> Artifacts)
  • Coverage has increased or at least not decreased. Update minimum_coverage in .github/workflows/coverage.yml as necessary.
  • All other unit and integration tests passing
  • Update validation for project config yaml file changes
  • Update existing documentation
  • Run a small batch run on Kestrel/Eagle to make sure it all works if you made changes that will affect Kestrel/Eagle
  • Add to the changelog_dev.rst file and propose migration text in the pull request

@joseph-robertson joseph-robertson added this to the v2024.07.0 milestone Jul 19, 2024
@joseph-robertson joseph-robertson self-assigned this Jul 19, 2024
@joseph-robertson joseph-robertson marked this pull request as ready for review July 19, 2024 20:10
with:
path: buildstockbatch
- uses: actions/checkout@v3
- uses: actions/checkout@v4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any particular reason to switch to v4 or just updating?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a ton of deprecation annotations on the Actions tab about these...

Copy link
Contributor

@rajeee rajeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@joseph-robertson joseph-robertson merged commit 0096d4c into develop Jul 19, 2024
6 checks passed
@joseph-robertson joseph-robertson deleted the bill-outputs3 branch July 19, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants