Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apptainer mount fix for ResStock and OpenStudio 3.8 #467

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

nmerket
Copy link
Member

@nmerket nmerket commented Aug 21, 2024

Pull Request Description

In ResStock with OpenStudio 3.8 the BuildExistingModel measure is trying to access the buildstock.rb file in the resources directory using a relative path. We weren't mounting that in in apptainer, but just the hpxml-measures subdirectory. This should fix that.

Checklist

Not all may apply

  • Code changes (must work)
  • Tests exercising your feature/bug fix (check coverage report on Checks -> BuildStockBatch Tests -> Artifacts)
  • Coverage has increased or at least not decreased. Update minimum_coverage in .github/workflows/coverage.yml as necessary.
  • All other unit and integration tests passing
  • Update validation for project config yaml file changes
  • Update existing documentation
  • Run a small batch run on Kestrel/Eagle to make sure it all works if you made changes that will affect Kestrel/Eagle
  • Add to the changelog_dev.rst file and propose migration text in the pull request

@whiphi92
Copy link

This change fixed the problem @joseph-robertson and I were running into on Kestrel.

@afontani
Copy link
Collaborator

afontani commented Sep 4, 2024

Probably need a test and changelog before moving forward with merging.

@nmerket nmerket marked this pull request as ready for review September 4, 2024 20:24
@nmerket nmerket requested a review from rajeee September 4, 2024 20:24
Copy link
Contributor

@rajeee rajeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nmerket Tested it and it works in Kestrel. So, LGTM.

@nmerket nmerket merged commit 5d24803 into develop Oct 10, 2024
6 checks passed
@nmerket nmerket deleted the os380_apptainer_mount_fix branch October 10, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants