Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add measure based upgrade workflow #471

Closed
wants to merge 1 commit into from
Closed

Conversation

rajeee
Copy link
Contributor

@rajeee rajeee commented Oct 14, 2024

Pull Request Description

Add a new measure based upgrade workflow to work with LoadFlexibility measure

This new workflow supports "measures" block within upgrades in addition to the options. The measures block can include the desired list of measures to run and arguments to be passed to the measures. Unlike options block, the measures block do not support applyl_logic or costs - those are to be handled within the measure code themselves. One can pass necessary cost/apply_logic related parameters as an argument to the measure.

Example upgrades specification below:
`

upgrades:
  - upgrade_name: Medium Moderate Load Flexibility
    measures:
      - measure_name: LoadFlexibility
        args:
          offset_type: relative
          heating_pre_peak_offset: 4
          heating_on_peak_offset: 4
          cooling_pre_peak_offset: 4
          cooling_on_peak_offset: 4
          heating_pre_peak_duration: 2
          cooling_pre_peak_duration: 2
          heating_on_peak_duration: 2
          cooling_on_peak_duration: 2

  - upgrade_name: No-pre-peak Medium Moderate Load Flexibility
    measures:
      - measure_name: LoadFlexibility
        args:
          offset_type: relative
          heating_on_peak_offset: 4
          cooling_on_peak_offset: 4
          heating_pre_peak_duration: 0
          cooling_pre_peak_duration: 0
          heating_on_peak_duration: 2
          cooling_on_peak_duration: 2

  - upgrade_name: Medium Moderate Load Flexibility with ENERGY STAR heat pump with elec backup
    measures:
      - measure_name: LoadFlexibility
        args:
          offset_type: relative
          heating_pre_peak_offset: 4
          heating_on_peak_offset: 4
          cooling_pre_peak_offset: 4
          cooling_on_peak_offset: 4
          heating_pre_peak_duration: 2
          cooling_pre_peak_duration: 2
          heating_on_peak_duration: 2
          cooling_on_peak_duration: 2
    options:
      ### -- ENERGY STAR ASHP applies to all dwellings with ducts
      - &ducted_ASHP_ENERGYSTAR_elec_backup
        option: HVAC Heating Efficiency|ASHP, SEER 16, 9.0 HSPF
        costs: &costs_ashp_ducted_SEER_16_9-2_HSPF
          - value: 4821.83 # for HSPF 9.2
            multiplier: Fixed (1)
          - value: 167.64
            multiplier: Size, Heating System Primary (kBtu/h)
        lifetime: &lifetime_ducted_ASHP 15

        ### -- ENERGY STAR MSHP applies to all dwellings without ducts
      - &nonducted_MSHP_ENERGYSTAR_elec_backup
        option: HVAC Heating Efficiency|MSHP, SEER 17, 9.5 HSPF, Ducted
        apply_logic: &nonducted_MSHP_apply_logic
          - or:
              - HVAC Has Ducts|No
              - or:
                  - or:
                      - HVAC Shared Efficiencies|Boiler Baseboards Heating Only, Electricity
                      - HVAC Shared Efficiencies|Boiler Baseboards Heating Only, Fuel
                      - HVAC Shared Efficiencies|Fan Coil Heating and Cooling, Electricity
                      - HVAC Shared Efficiencies|Fan Coil Heating and Cooling, Fuel
                      - HVAC Shared Efficiencies|Fan Coil Cooling Only
        costs: &costs_mshp_nonducted_SEER_16_9-2_HSPF
          #### costs not accurate or final, need to adjust inflation and re-calculate regressions - PRW 1/2/2024 ####
          # Source: Custom regression by Brennan Less. Ductless heat pump project costs were regressed on nameplate tons,
          # from data described in in Less et al. https://doi.org/10.20357/B7FP4D. January 2019 $ inflated to April 2023 $ using 1.21 factor.
          # Ductless MSHP n=173, HSPF median 11, range 9.3–14.2. Implicitly includes multiple zones and electrical upgrades.
          # Regression results in costs that are 15–30% higher than costs from The Heat Pump Store as documented in https://redwoodenergy.net/wp-content/uploads/2021/02/Pocket-Guide-to-All-Electric-Retrofits-of-Single-Family-Homes.pdf
          # LBNL data were not sufficient to include a relationship between SEER or HSPF and cost, so cost deltas for higher
          # and lower HSPF were added using the relationship between HSPF and cost for ductless MSHPs in REMDB: 2.2% addition or subtraction per point
          # according to how many points above or below the HSPF rating is from 10.5 (https://remdb.nrel.gov/).
          - value: 2733.38
            multiplier: Fixed (1)
          - value: 354.96
            multiplier: Size, Heating System Primary (kBtu/h)
        lifetime: &lifetime_nonducted_MSHP 15

        ### -- Apply no setpoint offsets to heat pumps that are variable speed -- ###
      - &cooling_setpoint_no_offset_nonducted
        option: Cooling Setpoint Has Offset|No
        apply_logic: *nonducted_MSHP_apply_logic

      - &cooling_setpoint_offset_magnitude_0_nonducted
        option: Cooling Setpoint Offset Magnitude|0F
        apply_logic: *nonducted_MSHP_apply_logic

      - &cooling_setpoint_offset_period_none_nonducted
        option: Cooling Setpoint Offset Period|None
        apply_logic: *nonducted_MSHP_apply_logic

      - &heating_setpoint_no_offset_nonducted
        option: Heating Setpoint Has Offset|No
        apply_logic: *nonducted_MSHP_apply_logic

      - &heating_setpoint_offset_magnitude_0_nonducted
        option: Heating Setpoint Offset Magnitude|0F
        apply_logic: *nonducted_MSHP_apply_logic

      - &heating_setpoint_offset_period_none_nonducted
        option: Heating Setpoint Offset Period|None
        apply_logic: *nonducted_MSHP_apply_logic

      - &HP_cooling_efficiency_nonducted
        option: HVAC Cooling Efficiency|Non-Ducted Heat Pump
        apply_logic: *nonducted_MSHP_apply_logic

      - &HP_cooling_efficiency_ducted
        option: HVAC Cooling Efficiency|Ducted Heat Pump
        # apply_logic: *ducted_ASHP_apply_logic

        ### -- Apply 100% conditioned to all dwellings -- ###
      - &100_percent_conditioned
        option: HVAC Cooling Partial Space Conditioning|100% Conditioned
        apply_logic: &yes_and_no_has_ducts_apply_logic
          - or:
              - HVAC Has Ducts|Yes
              - HVAC Has Ducts|No

`

Checklist

Not all may apply

  • Code changes (must work)
  • Tests exercising your feature/bug fix (check coverage report on Checks -> BuildStockBatch Tests -> Artifacts)
  • Coverage has increased or at least not decreased. Update minimum_coverage in .github/workflows/coverage.yml as necessary.
  • All other unit and integration tests passing
  • Update validation for project config yaml file changes
  • Update existing documentation
  • Run a small batch run on Kestrel/Eagle to make sure it all works if you made changes that will affect Kestrel/Eagle
  • Add to the changelog_dev.rst file and propose migration text in the pull request

@rajeee
Copy link
Contributor Author

rajeee commented Oct 14, 2024

We have decided to not pursue this path for the LoadFlexibility measure for now. Instead, the LoadFlexibility function will be built into the ResStockArgumentsPostHPXML measure. This won't require any changes to the workflow generator. This PR is archived in case we want to pursue measured based upgrade in the future.

@rajeee rajeee closed this Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant