Improve error check for FlorisModel merge function #1044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've opened this pull request prior to committing the fixed lines of code so that reviewers can see the red X followed by the green tick in the checks. The first commit exposes the issue in the tests, and the following commit fixes the issue. |
rafmudaf
force-pushed
the
merge_models
branch
from
03ade3d to
c5f30bc
Compare
misi9170
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expand error checking
The
FlorisModel.merge_floris_modelsfunction currently checks the input argument's first element for the correct type, but it requires that all elements be of the same type. See #866 (comment).This pull request adds a unit test to show that this error is not currently caught. However, another error is raised since the function will proceed assuming that all elements in the list are
FlorisModel. Then, the pull request modifies the error checking line to ensure all elements are indeedFlorisModel.