Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rubocop edits to the NZE HVAC measure #63

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
+333 −369
Open

Rubocop edits to the NZE HVAC measure #63

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions lib/measures/nze_hvac/measure.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,10 +289,10 @@ def arguments(model)
hvac_system_partition.setDefaultValue('Automatic Partition')
args << hvac_system_partition

# add an argument for ventilation schedule
# @todo add an argument for ventilation schedule

return args
end # end the arguments method
end

def run(model, runner, user_arguments)
super(model, runner, user_arguments)
Expand Down Expand Up @@ -347,6 +347,7 @@ def run(model, runner, user_arguments)
model.getThermalZones.each do |zone|
next if OpenstudioStandards::ThermalZone.thermal_zone_plenum?(zone)
next if !OpenstudioStandards::ThermalZone.thermal_zone_heated?(zone) && !OpenstudioStandards::ThermalZone.thermal_zone_cooled?(zone)

conditioned_zones << zone
end

Expand Down Expand Up @@ -430,8 +431,8 @@ def run(model, runner, user_arguments)
runner.registerFinalCondition("Added system type #{hvac_system_type} to model.")

return true
end # end the run method
end # end the measure
end
end

# this allows the measure to be used by the application
NzeHvac.new.registerWithApplication
18 changes: 9 additions & 9 deletions lib/measures/nze_hvac/measure.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
<schema_version>3.1</schema_version>
<name>nze_hvac</name>
<uid>f060dff2-b28d-4194-a6af-e66d88ddb33c</uid>
<version_id>8cbe5655-0c53-4e6d-8518-bfed32b6b4b8</version_id>
<version_modified>2024-11-16T23:47:44Z</version_modified>
<version_id>5a23df2a-8da4-419b-b102-64f88077b5d8</version_id>
<version_modified>2024-11-26T20:39:00Z</version_modified>
<xml_checksum>0E5E4776</xml_checksum>
<class_name>NzeHvac</class_name>
<display_name>NZEHVAC</display_name>
Expand Down Expand Up @@ -258,13 +258,7 @@
<filename>measure.rb</filename>
<filetype>rb</filetype>
<usage_type>script</usage_type>
<checksum>7EAD5ED0</checksum>
</file>
<file>
<filename>NZEHVAC_Test.rb</filename>
<filetype>rb</filetype>
<usage_type>test</usage_type>
<checksum>90B2A846</checksum>
<checksum>F3FAC6D8</checksum>
</file>
<file>
<filename>USA_IL_Chicago-OHare.Intl.AP.725300_TMY3.epw</filename>
Expand Down Expand Up @@ -296,6 +290,12 @@
<usage_type>test</usage_type>
<checksum>57483CB6</checksum>
</file>
<file>
<filename>nze_hvac_test.rb</filename>
<filetype>rb</filetype>
<usage_type>test</usage_type>
<checksum>BC3EA04F</checksum>
</file>
<file>
<filename>office_chicago.osm</filename>
<filetype>osm</filetype>
Expand Down
Loading