Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aggregate structure, construction & geometry branches #1883

Open
wants to merge 31 commits into
base: nrcan
Choose a base branch
from
Open

Conversation

brgix
Copy link
Collaborator

@brgix brgix commented Jan 27, 2025

A number of ongoing tasks are aiming to alter how BTAP sets, inter alia:

  • a building's general (activity) type (e.g. office vs commercial)
  • consequent structural attributes (e.g. steel vs concrete post/beam, vs wood-framed)
  • conditioned vs indirectly-conditioned (e.g. plenums) vs unconditioned (e.g. attics)
  • consequent skylight (and possibly skylight well) placement
  • subsequent linear thermal bridging assignment
  • follow-up embodied carbon take-offs

Some of the targeted branches include 1854 & 1882.

The initial plan was to merge individual branches with nrcan branch, one by one, in some preset sequence. As work progressed, that sequence couldn't necessarily be followed to the letter, as further iterations were needed. These branches are also highly interlinked - a change in one branch requiring synced changes in another. A merge with nrcan branch isn't foreseen very soon (in a month or so, yes - but not in the immediate future), which is making current harmonizing efforts a bit burdensome.

The task here is to simply create a single, intermediate branch to facilitate managing/harmonizing individual contributions (branches) before attempting a merge with nrcan branch. Continuously merging in other nrcan branch updates will continue for each of these branches individually, and for this intermediate branch, offering some flexibility to merge in some (or all) branches into nrcan branch at some point.

@brgix brgix requested a review from ckirney January 27, 2025 19:44
@brgix brgix self-assigned this Jan 27, 2025
@brgix brgix changed the base branch from master to nrcan January 28, 2025 13:23
brgix and others added 5 commits January 31, 2025 07:00
Merges cumulated changes in nrcan_450
Adds (then zeroes) door PSI-factors for NECBs
Adds building STRUCTURE parameters (BTAP)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants