Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.0.0a1 logic clipping filter warnings #365

Open
cdeline opened this issue Apr 26, 2023 · 0 comments
Open

3.0.0a1 logic clipping filter warnings #365

cdeline opened this issue Apr 26, 2023 · 0 comments

Comments

@cdeline
Copy link
Collaborator

cdeline commented Apr 26, 2023

using the logic filter with ta.filter_params['clip_filter'] = {'model':"logic"} leads to warnings about the experimental nature of the logic clipping filter. This was, in fact, the subject of a 2021 PVSC publication and has been validated, and I doubt that the core details of this implementation will change in the future. I propose removing the experimental label for our future 3.0 release. This will also clean up logfiles when we're running RdTools 1000's of times on the fleet pipeline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant