Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove warnings from logic clip filter #366

Merged

Conversation

cdeline
Copy link
Collaborator

@cdeline cdeline commented Apr 26, 2023

Code changes are covered by tests
Code changes have been evaluated for compatibility/integration with TrendAnalysis
New functions added to __init__.py
API.rst is up to date, along with other sphinx docs pages
Example notebooks are rerun and differences in results scrutinized

  • Updated changelog

Fixes #365. Logic clipping filter is published and validated, not likely to change in the future. for the 3.0 release (and 3.0.0a1 runs) it would be nice to get rid of the logfile clutter. We can still decide on whether to make it the default method or not, but the method itself is stable, or at least will be by the time of any 3.0.0 public release..

@mdeceglie
Copy link
Collaborator

I'm OK with this change. I think we can ignore all the failing tests at this stage. Some will be fixed by #362 , others have been introduced in the aggregated_filters_for_trials branch and we will clean them up when we figure out what 3.0 will really look like. Do you agree @cdeline ?

@mdeceglie mdeceglie merged commit c80c79a into aggregated_filters_for_trials Apr 28, 2023
@cdeline cdeline deleted the 365_logic_clipping_warnings branch April 28, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants