Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.11 support #432

Merged
merged 8 commits into from
Nov 3, 2023
Merged

Python 3.11 support #432

merged 8 commits into from
Nov 3, 2023

Conversation

ppinchuk
Copy link
Collaborator

@ppinchuk ppinchuk commented Nov 2, 2023

Add support for Python 3.11.
PySAM does not yet support Python 3.12 so we cannot upgrade to that yet.

@codecov-commenter
Copy link

codecov-commenter commented Nov 2, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (d4c175e) 87.02% compared to head (63db1a9) 87.06%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #432      +/-   ##
==========================================
+ Coverage   87.02%   87.06%   +0.04%     
==========================================
  Files         122      122              
  Lines       17005    17029      +24     
==========================================
+ Hits        14798    14826      +28     
+ Misses       2207     2203       -4     
Flag Coverage Δ
unittests 87.06% <86.66%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
reV/econ/econ.py 85.62% <100.00%> (+0.28%) ⬆️
reV/generation/generation.py 87.66% <100.00%> (+0.16%) ⬆️
reV/utilities/__init__.py 96.42% <100.00%> (+0.27%) ⬆️
reV/version.py 100.00% <100.00%> (ø)
setup.py 0.00% <ø> (ø)
reV/generation/base.py 83.37% <75.00%> (-0.27%) ⬇️

... and 11 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ppinchuk ppinchuk changed the title Python 3.11 and 3.12 support Python 3.11 support Nov 2, 2023
@ppinchuk ppinchuk marked this pull request as ready for review November 3, 2023 03:56
@ppinchuk ppinchuk merged commit fdfcae0 into main Nov 3, 2023
8 checks passed
@ppinchuk ppinchuk deleted the pp/python312 branch November 3, 2023 03:58
github-actions bot pushed a commit that referenced this pull request Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants