Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing techmap bug #437

Merged
merged 2 commits into from
Dec 18, 2023
Merged

Fix missing techmap bug #437

merged 2 commits into from
Dec 18, 2023

Conversation

ppinchuk
Copy link
Collaborator

Techmap now correctly created, even if pre_extract_exclusions is True.
Test included.
Also bumped GAPs version to include a fix for batch CSV input.

@ppinchuk ppinchuk added the Urgent High priority issue for NREL deliverables label Dec 18, 2023
@codecov-commenter
Copy link

codecov-commenter commented Dec 18, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (113ecf8) 87.02% compared to head (f3cd3fd) 87.07%.

Files Patch % Lines
reV/supply_curve/aggregation.py 66.66% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #437      +/-   ##
==========================================
+ Coverage   87.02%   87.07%   +0.04%     
==========================================
  Files         122      122              
  Lines       17044    17060      +16     
==========================================
+ Hits        14833    14855      +22     
+ Misses       2211     2205       -6     
Flag Coverage Δ
unittests 87.07% <72.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ppinchuk ppinchuk merged commit 0bf8745 into main Dec 18, 2023
9 checks passed
@ppinchuk ppinchuk deleted the pp/tm_fix branch December 18, 2023 23:47
github-actions bot pushed a commit that referenced this pull request Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Urgent High priority issue for NREL deliverables
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants