Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reV Geothermal EGS design temp fix #445

Merged
merged 3 commits into from
Feb 23, 2024
Merged

reV Geothermal EGS design temp fix #445

merged 3 commits into from
Feb 23, 2024

Conversation

ppinchuk
Copy link
Collaborator

Allow user to set the EGS plant design temperature to match the resource temperature just like the SAM GUI does.

We received confirmation form the SAM team that there are no plans to expose their toggleable option in PySAM, so we had to go for this workaround.

@ppinchuk ppinchuk added the feature New feature or request label Feb 23, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 23, 2024

Codecov Report

Attention: Patch coverage is 98.49246% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 87.17%. Comparing base (b9a2c8d) to head (1fbd11b).

Files Patch % Lines
tests/test_gen_geothermal.py 98.37% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #445      +/-   ##
==========================================
+ Coverage   87.12%   87.17%   +0.05%     
==========================================
  Files         122      122              
  Lines       17212    17246      +34     
==========================================
+ Hits        14996    15035      +39     
+ Misses       2216     2211       -5     
Flag Coverage Δ
unittests 87.17% <98.49%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ppinchuk ppinchuk merged commit c96002c into main Feb 23, 2024
9 checks passed
@ppinchuk ppinchuk deleted the pp/egs_temp_fix branch February 23, 2024 03:04
github-actions bot pushed a commit that referenced this pull request Feb 23, 2024
reV Geothermal EGS design temp fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants