Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix zero cost EOS bug #458

Merged
merged 6 commits into from
Jun 26, 2024
Merged

Fix zero cost EOS bug #458

merged 6 commits into from
Jun 26, 2024

Conversation

ppinchuk
Copy link
Collaborator

Refactor left a bug that would crash program if any LCOE component is set to 0 (like VOC usually is). New default cost is None (NaN), which allows 0 values to pass through normally

@ppinchuk ppinchuk self-assigned this Jun 25, 2024
@ppinchuk ppinchuk added the bug Something isn't working label Jun 25, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.59%. Comparing base (75ccf41) to head (5e128cb).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #458      +/-   ##
==========================================
+ Coverage   87.52%   87.59%   +0.06%     
==========================================
  Files         122      122              
  Lines       18070    18091      +21     
==========================================
+ Hits        15816    15846      +30     
+ Misses       2254     2245       -9     
Flag Coverage Δ
unittests 87.59% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ppinchuk ppinchuk merged commit 77f3bb5 into main Jun 26, 2024
11 checks passed
@ppinchuk ppinchuk deleted the pp/fix_voc_zero_bug branch June 26, 2024 14:58
github-actions bot pushed a commit that referenced this pull request Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants