Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vanilla wind gen with layout #465

Merged
merged 5 commits into from
Sep 12, 2024
Merged

Conversation

ppinchuk
Copy link
Collaborator

Previously, wind direction was not being extracted from the resource and passed to SAM for wind vanilla reV. Presumably this is because it was intended to be run with a single turbine fixed in the middle.

This default case is still supported in a backwards-compatible way (i.e. no wind direction resource extracted), but if a layout is specified in any SAM config, the wind direction is now pulled into the resource.

@ppinchuk ppinchuk added the bug Something isn't working label Sep 12, 2024
@ppinchuk ppinchuk self-assigned this Sep 12, 2024
@ppinchuk ppinchuk marked this pull request as ready for review September 12, 2024 01:21
@codecov-commenter
Copy link

codecov-commenter commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.69%. Comparing base (7d4a339) to head (534bb71).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #465      +/-   ##
==========================================
+ Coverage   87.63%   87.69%   +0.06%     
==========================================
  Files         122      122              
  Lines       18140    18175      +35     
==========================================
+ Hits        15897    15939      +42     
+ Misses       2243     2236       -7     
Flag Coverage Δ
unittests 87.69% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ppinchuk ppinchuk merged commit 5873cfd into main Sep 12, 2024
10 of 11 checks passed
@ppinchuk ppinchuk deleted the pp/fix_vanilla_gen_with_layout branch September 12, 2024 13:31
github-actions bot pushed a commit that referenced this pull request Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants