-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decreasing memory footprint of Tech Mapping #504
Draft
mjgleason
wants to merge
9
commits into
mg/agg_zones
Choose a base branch
from
mg/tm_mem
base: mg/agg_zones
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce memory requirements, updating test
…es, and defaults for consistnecy with supplycurve-aggregation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## mg/agg_zones #504 +/- ##
================================================
- Coverage 87.72% 87.71% -0.02%
================================================
Files 122 123 +1
Lines 18379 18445 +66
================================================
+ Hits 16123 16179 +56
- Misses 2256 2266 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗ DO NOT MERGE ❗
This PR decreases the memory footprint of Tech Mapping to enable creation of tech maps for exclusions at 30m resolution. It does so primarily by writing the results in slices to the h5 dataset, rather than building it up as an array in memory and then writing the full array to disk. There are a few other memory-saving changes as well.
The PR also introduces a new CLI command
tech-mapping
which allows running the creation of tech maps in isolation from running supply curve aggregation.This PR is technically breaking since the
TechMapping.run()
method used to return the tech map array. This functionality did not appear to be used anywhere (in the codebase or the tests), so I removed it since it more or less defeats the purpose of trying to optimize memory.Note that this is built on #503 so I have (temporarily) pointed it to the
mg/agg_zones
branch for comparison.TODOS:
batch_size
as parameter up the call chain