Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust fan W/cfm using baseline/upgrade airflows #1163

Closed
wants to merge 26 commits into from

Conversation

joseph-robertson
Copy link
Contributor

Pull Request Description

Closes #1154.

Checklist

Not all may apply:

  • Tests (and test files) have been updated
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected regression test changes on CI (checked comparison artifacts)

…101b8d7

03371101b8d7 Merge branch 'master' into watts-per-cfm-args
319f860c55f4 Merge pull request #1543 from NREL/build-res-hpxml-doc-defaults
af0b8c670105 Merge pull request #1544 from NREL/docs_formatting
111190f2692b Fix a few typos.
7d0241f96269 Add dashes to the rest. [ci skip]
ee7c106c1581 Test [ci skip]
d29c06dba79f Try unicode character to preserve dashes. [ci skip]
eef653006804 Use paragraphs in footnotes to work around readthedocs/sphinx_rtd_theme#1472
2cd420ca1ee4 Few more href updates.
445d7a40a434 Replace all measure descriptions with href.
6daa7ce3a560 Test [ci skip]
529975bb3ad3 Test [ci skip]
4b4903fdfed1 Test [ci skip]
1f8868465ee9 Test [ci skip]
356f1e743cfa Test [ci skip]
eb328e35be36 Test [ci skip]
0605b62d893b Attempt to fix docs formatting, which changed in recent weeks. [ci skip]
a2fcdf2c8096 Update readme erb to convert href to markdown.
1c6fd3dce40d Try an argument description with href.
3e68033aabe6 Merge pull request #1526 from NREL/ducted_mshp_sizing
31b63e97229a Latest results.
fae91e332319 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into ducted_mshp_sizing
8bfc8c4eb327 Merge pull request #1541 from NREL/balance_workflow_tests
f16d845e89a3 Merge branch 'balance_workflow_tests' of https://github.com/NREL/OpenStudio-HPXML into balance_workflow_tests
e44ad71caac7 Latest results.
46007f49b4db Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into balance_workflow_tests
5aef27a6ae10 Merge pull request #1542 from NREL/fix_msgpack_hourly
0656b5a5211f 🤦
e4788c4f5ab7 Update build measure argument descriptions with links to docs.
f4fcb5a921ab Missed one update.
1e59ff5253f5 Fix use of hourly msgpack file. Hit this error in a BEopt test now that most of our end uses are derived from Output:Meters instead of Output:Variables.
3dd4cba484f6 Better balance the runtime across the two workflow CI jobs.
02207f7a83c7 Merge pull request #1540 from NREL/deprecation-msgs
b251c34b737f Adds error messages for all extension elements that have been moved/deprecated since v1.0, so that the input is not silently ignored. No need to do this for non-extension elements since the XSD Schema will report errors for these situations.
5889de415f7c Update unit tests.
0f813a83fe1d Hotfix for recirc energy when multiple water heaters.
51f9d2fde585 Merge pull request #1537 from NREL/ground_temperatures2
c45fa9de0fb1 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into ground_temperatures2
6598ab6059d4 Merge pull request #1539 from NREL/fix_system_use
053e9130f24a Fix CI failures.
542804374975 Run update_measures.
fb2bf8fb8038 Merge branch 'ground_temperatures2' of github.com:NREL/OpenStudio-HPXML into ground_temperatures2
4063887f5d09 Accept nearest station in xing lookup.
9d9ad3647d76 Add comment [ci skip]
1043ac2d1b96 Fix comment [ci skip]
2b0d89bf4bae Fix possible incorrect value for system use, bug introduced in #1456. Adds error-checking to prevent this going forward. Some other minor misc cleanup.
d4ed83b66882 Merge branch 'ground_temperatures2' of github.com:NREL/OpenStudio-HPXML into ground_temperatures2
54d28d2ce6bf Skip deep ground temp calcs if no gshp.
b00bb9240310 Add test for defaulting xing values.
3a783ad4a25f Respond to review.
23f6e542ea5d Latest results.
71ac84dff44e Merge branch 'master' into ground_temperatures2
98ace8d4ac0e Update the changelog. [ci skip]
9cd53e49d11f Merge pull request #1538 from NREL/misc_cleanup
e24568fd749f Latest results.
951dc933449f Misc cleanup.
092d4981415d Latest results.
3370a534320b Convert new csv to utf8.
cde1f9aaab25 Get the units right.
27148f692cfc Missed a return.
533d2926d781 Update the changelog.
4a6174d571f5 Assign deep ground variables and use throughout.
1fbc7087565f Add deep temperature lookup based on xing model.
6c91ec33ac58 Revert shallow and deep ground temperature conflation.
4127a5dcb4a5 Merge pull request #1536 from NREL/split_workflow_tests
00b8d21b992f Remove old files. [ci skip]
fd88b9696ce4 Latest results.
004c05172b3c Fix CI failure
d2a87c7e3aa8 Update pull_request_template.md [ci skip]
ab259ce187a0 Split workflow tests, so they can be parallelized on the CI for faster turnaround time.
44b6e2730a22 Merge branch 'master' into watts-per-cfm-args
08087e56e1b1 Latest results.
91b20b687a12 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into ducted_mshp_sizing
c6f30fa3eeff Collapse new args into a single one since only a single air distribution system is supported.
41c6cee061cc Regenerate the BuildResHPXML readme file.
5af4e6167bcf Replace tasks.rb mods with hpxml_inputs.json updates.
f43e85faf8c3 Add optional blower fan efficiency args to BuildResHPXML.
8768fdd2d4f9 Latest results.
a890bb11c514 Merge branch 'ducted_mshp_sizing' of https://github.com/NREL/OpenStudio-HPXML into ducted_mshp_sizing
db9528575ba6 Add airflow rates to CI artifact.
2b7363b3820e Latest results.
790b177584a8 Treat ducted MSHPs like ASHPs for equipment adjustments in sizing.

git-subtree-dir: resources/hpxml-measures
git-subtree-split: 03371101b8d70c2955b7cef91cb7abc4ad2c7fca
@joseph-robertson joseph-robertson self-assigned this Nov 9, 2023
joseph-robertson and others added 14 commits November 9, 2023 07:28
…7fbd88a

a134d7fbd88a For now, test using a new sample file.
fc2836ec1317 Update defaults for fan adjustment and airflow maximums.
e2d50c8b8397 Update epvalidator for new hp sizing methodology enum.
49f9ba2bea97 Add new hp sizing methodology, and args for airflow rates.

git-subtree-dir: resources/hpxml-measures
git-subtree-split: a134d7fbd88a1b020090c2d6a7cf18c82a901c80
…c067af1

a6dcec067af1 Use airflow max method.

git-subtree-dir: resources/hpxml-measures
git-subtree-split: a6dcec067af1da8a7c38eb4943794f7b6465d584
…3257ce6

6d59d3257ce6 Switch from new methodology to just an input, and write a test.

git-subtree-dir: resources/hpxml-measures
git-subtree-split: 6d59d3257ce67b8a885dab3606247321e129cd83
…206ae92

7ffc8206ae92 Forgot to default the new bool arg.

git-subtree-dir: resources/hpxml-measures
git-subtree-split: 7ffc8206ae92badc4753db4ecc1e7aecbda6b00e
…b726eee

ee6abb726eee Add bool arg for fan efficiency adjustment.
fdb5f16f79b5 Latest results.
4e6438e7a197 Merge branch 'watts-per-cfm-args' into max-airflow-args
35634487355b Update hpxml inputs json after merge.
69518743ec25 Merge branch 'watts-per-cfm-args' into max-airflow-args
31c271c90d09 Merge branch 'master' into watts-per-cfm-args
8db786fe8955 Merge pull request #1545 from NREL/os370rc2
b5f15f7255f7 Fix updating of reporting measures
56d573155446 Bump sha
da6303bce2ba Update for upcoming rc3. [ci skip]
eb50907a102d Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into os370rc2
e9a227ea2a15 Merge pull request #1553 from NREL/var_spd_hp_bugfix
72c39ab5f553 Fix error if detailed performance data provided and some capacities are zero.
d861ab043c6f Fix docs formatting [ci skip]
2022425e5ee4 Merge pull request #1527 from NREL/1_and_2_speed_hvac_regressions
d5d589b4d6b7 Latest results.
49691011f844 Fix conflict resolution.
af0388c9622f Latest results.
ea1e7f021d08 Update Changelog.md [ci skip]
def58da859d5 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into 1_and_2_speed_hvac_regressions
d741ae7421b8 Merge pull request #1317 from NREL/heat_pump_detailed_performance
10f45058ecc0 Latest results.
983a79ddbbe7 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into heat_pump_detailed_performance
87bfe1aeb9d1 Merge pull request #1552 from NREL/speedup_ci
1359e4509da5 Bugfix.
a226ff50815d Speed up measure tests for reporting measures.
615443961433 Small docs change. Moved building scope description into a new HPXML Building section. [ci skip]
da1d80e09283 Merge pull request #1550 from NREL/whole_mf_timeseries_temperatures
10488e3ae508 Fix missing timeseries temperature outputs when running whole MF buildings. Add test.
22d9e4df6a72 Merge pull request #1548 from NREL/foundations_with_walls_only
6f6304820e29 Latest results.
3deebd8322d5 Update docs [ci skip]
483ffcbf4f0e Add test file.
d62712830c1c Allow above-grade basements/crawlspaces defined solely with Wall (not FoundationWall) elements.
2551567f137a Latest results.
496f2406ddf1 Fix CI failures.
64ba96c1f819 Bump to rc2.
baccc929311a Latest results.
b8837676391e Merge branch 'heat_pump_detailed_performance' of https://github.com/NREL/OpenStudio-HPXML into 1_and_2_speed_hvac_regressions
adc2d8fd3ebb Latest results.
455a0d719db4 Use sizing speed more places in hvac_sizing.rb. Update tests.
8c77d5930b32 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into heat_pump_detailed_performance
080a843adcc3 Update tests and misc cleanup.
d9348692a102 Latest results.
218dba39a7db Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into heat_pump_detailed_performance
933cf8ce1fcb CLean up changelog [ci skip]
bf81fc0b788b Merge branch 'heat_pump_detailed_performance' of https://github.com/NREL/OpenStudio-HPXML into 1_and_2_speed_hvac_regressions
ebdd135e6152 Latest results.
63caade040db Latest results.
416713c6adb6 Merge branch 'heat_pump_detailed_performance' of https://github.com/NREL/OpenStudio-HPXML into 1_and_2_speed_hvac_regressions
b55b4d78ec4d Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into heat_pump_detailed_performance
939d8693248e Latest results.
57c6489c3f2b Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into heat_pump_detailed_performance
aeb696f5791f Merge branch 'heat_pump_detailed_performance' of https://github.com/NREL/OpenStudio-HPXML into heat_pump_detailed_performance
a8a4c135a3cf fan_speed_ratio and capacity ratio override
ecb5f33bb578 Latest results.
7448398a77e4 Revert change to MSHP rated fan power. Small tweak to max_cop_82 for ductless systems.
0d6450ef1cbc Remove deprecated variable.
20534a438784 Latest results.
a23d0d1a2155 Small tweak.
2eb32c4d15ea Replaces inverse calculations with regressions. Renames variables from EIR to COP.
3e2359334424 Latest results.
c7d71f7066bf Bugfix.
609f2d3553e9 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into heat_pump_detailed_performance
e05e32269b48 Fix GSHP test failures and cleanup code.
bd656f94ccc6 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into heat_pump_detailed_performance
766132a4332a update_measures
9ece063a57d2 add nominal speed in sizing, restore get_sizing_speed
ed5b6f0395eb Latest results.
89a7d03b2aea Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into heat_pump_detailed_performance
0c0cac417f82 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into heat_pump_detailed_performance
c65b59f5bdca Merge branch 'heat_pump_detailed_performance' of https://github.com/NREL/OpenStudio-HPXML into heat_pump_detailed_performance
bf9f8fa1fde0 Get rid of additional_properties.num_speeds and other cleanup. No diffs expected.
ba2c6a687dfd Latest results.
40b5b96c12dd Bugfix.
05fca76f0bd6 Fix fan ratio calculation.
d92e6d0a816e Update unit tests to handle new sample files.
447b7e3bde29 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into heat_pump_detailed_performance
247650e36dfc Fix rated fan power in net-to-gross calculation for cases not using detailed performance data. Create method for calculating fan power using fan power curve.
09c86473c8c4 Update unit test expected values.
5e2d4408449d Latest results.
1e88e8a1e5e4 Merge branch 'heat_pump_detailed_performance' of https://github.com/NREL/OpenStudio-HPXML into heat_pump_detailed_performance
4c2df0d69e0a Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into heat_pump_detailed_performance
c3988289cd5a Fix rated fan power in net-to-gross calculation.
dbdebba3e9bc Latest results.
18b2784d9414 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into heat_pump_detailed_performance
2f6111211898 Latest results.
a544b0fdef6e Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into heat_pump_detailed_performance
1bd8bb72a7b6 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into heat_pump_detailed_performance
22871b732d24 Set fixed rated W/cfm for ductless systems.
e4a81204857a Revert use of Table:Lookup for constant values. No diffs expected.
5809cacffe7e Latest results.
fa21b59b1bf1 Use adaptive step size tol of 0.1; gives results very close to using 0.01 and had no discernible effect on runtime speed.
6ab4baa383d5 Latest results.
3bcc25dadf15 Latest results.
b2b89b8f2ab8 Simplify HVACSizing.apply_hvac_fixed_capacities method and minor code cleanup. Diffs only expected for files with detailed performance data.
0eea8a06e1aa Simplify/merge code related to capacity ratios; no diffs expected.
f89ba7f01eaf Merge branch 'heat_pump_detailed_performance' of https://github.com/NREL/OpenStudio-HPXML into heat_pump_detailed_performance
ab9f6ff2ee88 Expand sizing tests, and a little cleanup.
7b6da1096ed8 Latest results.
7e98f9540637 Update ductless max_cop_95 coefficients
6df3dea8b4b0 Merge branch 'heat_pump_detailed_performance' of https://github.com/NREL/OpenStudio-HPXML into heat_pump_detailed_performance
b506ceb84655 Need to protect from negative lookup table values on the other end of the ODB range as well; found while modeling a NEEP product. No diffs expected.
30279ccd2df2 Latest results.
7d910615823d Use constant extrapolation
18a0ddc577fc Merge branch 'heat_pump_detailed_performance' of https://github.com/NREL/OpenStudio-HPXML into heat_pump_detailed_performance
4c029939f007 cleanup for heating
48b9ae5a0098 cleanups on hvac sizing
60c787681736 Latest results.
0f2c7adb0db7 bugfix
71f2b28a358b Merge branch 'heat_pump_detailed_performance' of https://github.com/NREL/OpenStudio-HPXML into heat_pump_detailed_performance
2e03763de358 allow increase capacity for detailed performance data inputs
db4a5972aa47 Latest results.
ba031a0c1d92 Merge branch 'heat_pump_detailed_performance' of https://github.com/NREL/OpenStudio-HPXML into heat_pump_detailed_performance
4f5a98a82d9c Create range bounds for independent variables that prevent negative Table:Lookup values and add some error-checking to ensure we aren't creating Table:Lookup objects with negative values. Revert from Table:Lookup to curve objects for HVAC system types other than those using detailed performance data, given there are complexities/risks/performance considerations to using them.
64a4c9bd51b9 hvac sizing improvement for detailed performance data, some cleanups
227dfb3b37bb Refactor similar code into a single interpolate_to_odb_table_point() method. No diffs expected.
3feb77d145d2 Latest results.
597060828bef Always calculate capacity retention factor at 5F when detailed performance data provided.
acd24699a07c fix retention ci error
aa9efdd2c5c6 adaptive step size first cut
2b552f6f1823 oops, forgot to delete dead codes
3b2300d013b3 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into heat_pump_detailed_performance
e21d6f201b8b hvac sizing heating retention adjustment and cleanup
88c7cf06c028 Oops.
152602f54cfd A little more cleanup.
1609f0a2f693 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into heat_pump_detailed_performance
7e65a8751c0c Misc code cleanup; no diffs expected.
3bd9239a3ddc Latest results.
122b55a7e409 Add dataSource="software" to defaulted performance data. Remove default heating 17F datapoints, not necessary.
a07ab12f8f93 Cleanup sample files; only need CompressorType="variable speed" for files with detailed performance data.
ca8f765c0009 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into heat_pump_detailed_performance
d914a9a03d30 Latest results.
87a401538d90 Merge branch 'heat_pump_detailed_performance' of https://github.com/NREL/OpenStudio-HPXML into heat_pump_detailed_performance
65f642ddce7f fix test for new default too
f9eba735499a update the cop vs hspf coefficients
8bde279f32f2 Latest results.
2e72647ceec7 Merge branch 'heat_pump_detailed_performance' of https://github.com/NREL/OpenStudio-HPXML into heat_pump_detailed_performance
7a21680ce014 use compressor lockout temperature in table lookup
8274e22e7402 Latest results.
09cb506a0bf6 Merge branch 'heat_pump_detailed_performance' of https://github.com/NREL/OpenStudio-HPXML into heat_pump_detailed_performance
4af6da1f2b20 change the heating rated condition
6051e80075e4 Merge branch 'heat_pump_detailed_performance' of https://github.com/NREL/OpenStudio-HPXML into heat_pump_detailed_performance
98ef4d3127a7 Merge branch 'heat_pump_detailed_performance' of https://github.com/NREL/OpenStudio-HPXML into heat_pump_detailed_performance
f6803ad2437c Fix object names [ci skip]
dcc3f59c6f13 one bugfix for interpolating
f18a78d9c3b8 Latest results.
35d4abfb0572 Latest results.
4355a1b08cc1 Merge branch 'heat_pump_detailed_performance' of https://github.com/NREL/OpenStudio-HPXML into heat_pump_detailed_performance
1e1a68ea1298 add iq+detailed performance data test file
e0c35ecfa18f Merge branch 'heat_pump_detailed_performance' of https://github.com/NREL/OpenStudio-HPXML into heat_pump_detailed_performance
2323edb5a604 Fix CI failure
d8201192c278 alternative fix for iq
18029c346779 Latest results.
7b4bfc7d1381 Merge branch 'heat_pump_detailed_performance' of https://github.com/NREL/OpenStudio-HPXML into heat_pump_detailed_performance
c47592293f10 Show heating capacity retention fraction in in.xml for variable-speed HPs w/o detailed performance data. Document new default for variable-speed HPs. Round capacities/COPs when defaulted in in.xml.
2aab954fbe08 add cooling capacity ratio from max to rated
9bc83c0a7f73 Merge branch 'heat_pump_detailed_performance' of https://github.com/NREL/OpenStudio-HPXML into heat_pump_detailed_performance
ce4c29c34797 fix iq issue
5ab446dc0ccf Require CompressorType="variable speed" when providing detailed performance data (for now, at least).
2ebf00caa0dc Latest results.
180bf1568d59 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into heat_pump_detailed_performance
e5a60524d6dc Merge branch 'heat_pump_detailed_performance' of https://github.com/NREL/OpenStudio-HPXML into heat_pump_detailed_performance
bdb6d8f9e810 update wall placement cop correlation
f346a3adcc12 Latest results.
6aa21d1f39ea ignore shr warning for now, adjustment is small
4a7ebc84b5d3 Merge branch 'heat_pump_detailed_performance' of https://github.com/NREL/OpenStudio-HPXML into heat_pump_detailed_performance
4541de0a9446 Fix one CI failure
f50e6f92e149 fix unit tests for cfm/ton
5641df67bada This shouldn't be needed.
522140481aa8 Merge branch 'heat_pump_detailed_performance' of https://github.com/NREL/OpenStudio-HPXML into heat_pump_detailed_performance
09b8bceedf3b change cfm/ton to be 400
4d11f610f943 Merge branch 'heat_pump_detailed_performance' of https://github.com/NREL/OpenStudio-HPXML into heat_pump_detailed_performance
5d5f7ce1d1f4 Allow CompressorType input for MSHPs/MSACs (though it has to be variable speed). Previously we just ignored the input, but now we will throw an error if a user tries to model a single/two stage mini-split.
f0683ee953fb Merge branch 'heat_pump_detailed_performance' of https://github.com/NREL/OpenStudio-HPXML into heat_pump_detailed_performance
dd3f3df38dcc simplify constant table lookups
d0f20ae6de6b Removes HeatingCapacityRetention from HP sample files, since it is ignored. Also moves some sample files properties from tasks.rb to hpxml_inputs.json, so they go through the BuildResHPXML measure.
649eb8bed79e First pass on docs. Minor hvac.rb and EPvalidator.xml cleanup.
350cafabc806 Fix order of elements in docs.
e787345881e6 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into heat_pump_detailed_performance
d1f197b49562 Latest results.
28bb9d36bf5a method name issue
48a9031f2c3d remove one comment
a2b189eabf05 Merge branch 'heat_pump_detailed_performance' of https://github.com/NREL/OpenStudio-HPXML into heat_pump_detailed_performance
12135044d571 modify hvac sizing adjustment based on new approach, remove var speed system ft curves
63fdc9a63d1e Latest results.
c36a208e2fba deprecate hspf and seer calculation methods for mshp
393752c864e2 Merge branch 'heat_pump_detailed_performance' of https://github.com/NREL/OpenStudio-HPXML into heat_pump_detailed_performance
d04cfa248d98 fix unit test, add performance data unit test
e6528312436a Latest results.
db9c77907f4f Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into heat_pump_detailed_performance
35a61e18a99c report user-entered rated capacity instead of maximum
7c88b12b0f3b fix air flow using rated capacity. Add rated capacity as required input for reporting
e65789c1b690 revert cfm/ton
74c4288ebfd0 Merge branch 'heat_pump_detailed_performance' of https://github.com/NREL/OpenStudio-HPXML into heat_pump_detailed_performance
c443d6d82b85 fix the order issue, deprecate one more method, add some comments
be86579754f0 Add error-checking and tests for incomplete datapoint pairs.
46fff7751159 more flexibility for detailed performance data specifications
5a38d9090e15 add cop from seer for centrally ducted system
663bfde977c7 change the method to ensure nonzero capacity for detailed performance data
8c6174957f6a enforce heat pump cooling and heating detailed performance data to be provided together, allow ac detailed performance data inputs
882ae0002aa2 Merge branch 'heat_pump_detailed_performance' of https://github.com/NREL/OpenStudio-HPXML into heat_pump_detailed_performance
05238285e90b progress on cooling defaulting implementations
88e752cb7825 Latest results.
981161065f7c add ac test files
bcbf0f02f429 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into heat_pump_detailed_performance
06280319d45a use HPXML constant instead of hardcoded string
955826cbf7d0 change tests too
7c20721c7b92 address comments
09eb9a539e2a Merge branch 'heat_pump_detailed_performance' of https://github.com/NREL/OpenStudio-HPXML into heat_pump_detailed_performance
e0312e7e0176 fix test default for new defaulted capacity retention of var speed systems
36d044a17580 Latest results.
c953e2cea4d4 Merge branch 'heat_pump_detailed_performance' of https://github.com/NREL/OpenStudio-HPXML into heat_pump_detailed_performance
82e48e955fbc fix unit test, handle capacity retention inputs for 1/2 speed systems, handle capacity net to gross conversion for all dx systems
b3286c411399 Latest results.
cd44b313e7ff fix cooling only case
e9493c712443 fixed a few bugs related to 17F capacity and capacity retentions, added unit test for overriding these two inputs when user provides detailed performance data
c40dd0a0a0ca remove top level capacities for detailed performance data test files
8a1034df4f3f moved the default neep data method call to be after hvac sizing call
05b2bd723b19 change user input capacity to be rated instead of maximum
f1eef4900b4a fix autosize error
591942485785 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into heat_pump_detailed_performance
ae085206632d small fix
011233a924f8 heating default methods added
2f01ebcfb0a7 remove unnecessary data structure
c0e0d8a8532e put two fixme comments for hvac sizing
c6faa2dddd7a connect performance table for heating
98e5764b1f9a Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into heat_pump_detailed_performance
6239d9ee1c8d bugfixes
fad91b6d3d39 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into heat_pump_detailed_performance
63b01994a193 connect to table lookup
3e6ae519a96c Merge branch 'heat_pump_detailed_performance' of https://github.com/NREL/OpenStudio-HPXML into heat_pump_detailed_performance
ef1015600b71 progress
6b8be82e15d1 Latest results.
ed102a8ef53a Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into heat_pump_detailed_performance
8f116be452d0 A few refactors, add interpolation, add correction for indoor conditions
a65da7373080 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into heat_pump_detailed_performance
5ec0d4ef568e Merge branch 'heat_pump_detailed_performance' of https://github.com/NREL/OpenStudio-HPXML into heat_pump_detailed_performance
173c3e04a6ac added convert_net_to_gross method
2f3aad7f618d Latest results.
e0114e99d1ef Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into heat_pump_detailed_performance
9286bfcfd2f1 Latest results.
02ef16859ab6 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into heat_pump_detailed_performance
8e4d8f883a7c Merge branch 'heat_pump_detailed_performance' of https://github.com/NREL/OpenStudio-HPXML into heat_pump_detailed_performance
752cb34df096 save progress: added clg/htg ap data structure to store neep inputs, added placeholder for methods
13cace3efee6 Latest results.
45d917f30587 fix bicubic calculation coefficient order to be the same as E+ coefficient order
a273166c6036 change variable range for boiler
79a4a8899dfc Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into heat_pump_detailed_performance
7f1e6dc36d9e fix installation quality program and remove calc curve methods
fca5410f6b83 update hpxmls
06e249f812a5 optional parameter
55230694f3fc Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into heat_pump_detailed_performance
a6ea560387e5 cleanup and more curve replacement
e4f24eace586 Merge branch 'heat_pump_detailed_performance' of https://github.com/NREL/OpenStudio-HPXML into heat_pump_detailed_performance
280ed3689dd5 Latest results.
d93d8b929cb2 Drop support for CapacityFractionOfNominal elements; lets keep things simple for the initial implementation.
ebe25380da3d Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into heat_pump_detailed_performance
29d3ecaaa48d first cut for table lookup, not completed
88f279dc3942 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into heat_pump_detailed_performance
fdd18943a1ae Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into heat_pump_detailed_performance
d93bc6ecf496 Latest results.
e66bd05b5442 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into heat_pump_detailed_performance
f8d72f4e58d3 Latest results.
01edbccc4b0c Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into heat_pump_detailed_performance
63f1cf7f7502 Latest results.
d69dd9b41d15 update_measures
515b64deb3e5 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into heat_pump_detailed_performance
c721e70c73fd Comment [ci skip]
0f45b677a3cb Latest results.
b4bf80cf6ec7 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into heat_pump_detailed_performance
44ed0dbc394e Bugfix.
41efcfd543c1 Bugfix.
9bf1fd05852d Add inputs to HPXML class and Schematron. Create sample files.

git-subtree-dir: resources/hpxml-measures
git-subtree-split: ee6abb726eee0907de04193d768e2c3baaaccd2f
…819ae6f

522f1819ae6f Forgot to actually set the new arg value.

git-subtree-dir: resources/hpxml-measures
git-subtree-split: 522f1819ae6f862a0c07fbd5e5b3bb15cd11f491
@joseph-robertson
Copy link
Contributor Author

Superseded by #1179.

@joseph-robertson joseph-robertson deleted the watts-per-cfm-args2 branch December 7, 2023 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Account for baseline house duct size in the energy model
1 participant